# How to properly fix issues in ext/zip?

- Thread: https://externals.io/message/95655
- Original archive: https://news-web.php.net/php.internals/95655
- Started by Christoph M. Becker on 2016-09-05T16:23:23+00:00
- Messages: 3
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #95655 — Christoph M. Becker — 2016-09-05T16:23:23+00:00

URL: https://externals.io/message/95655#95655

Hi!

I've stumbled upon <https://bugs.php.net/70752> and could fix it, but
I'm not sure whether the fix should be applied to php-src/ext/zip or
rather against PECL/zip (i.e. <https://github.com/pierrejoye/php_zip>).

So, which repo is the "master" – ext/zip or PECL/zip?

-- 
Christoph M. Becker

---

## #95658 — Remi Collet — 2016-09-05T16:40:39+00:00

URL: https://externals.io/message/95655#95658 · In reply to: #95655

Le 05/09/2016 à 18:23, Christoph M. Becker a écrit :
> Hi!
> 
> I've stumbled upon <https://bugs.php.net/70752> and could fix it, but
> I'm not sure whether the fix should be applied to php-src/ext/zip or
> rather against PECL/zip (i.e. <https://github.com/pierrejoye/php_zip>).
> 
> So, which repo is the "master" – ext/zip or PECL/zip?
> 

Both should be updated.

At least php-src.

I usually take care to keep pecl/zip synced, but of course if you can
also do it, you are very welcome.



pecl/zip allow to run latest version (using latest libzip) with older
PHP version.


Remi.

---

## #95662 — Christoph M. Becker — 2016-09-05T17:28:20+00:00

URL: https://externals.io/message/95655#95662 · In reply to: #95658

> Le 05/09/2016 à 18:23, Christoph M. Becker a écrit :
>
> > […]
> 
> Both should be updated.
> 
> At least php-src.
> 
> I usually take care to keep pecl/zip synced, but of course if you can
> also do it, you are very welcome.

Okay, so I take it that updates should go to php-src/ext/zip first.
That suits me fine.  If it is helpful for you, I can file respective
issues for any updates I'll do to php-src/ext/zip.

> pecl/zip allow to run latest version (using latest libzip) with older
> PHP version.

Yes, I know, and I think it's good this way. :-)

-- 
Christoph M. Becker