# couple of PRs for master

- Thread: https://externals.io/message/88715
- Original archive: https://news-web.php.net/php.internals/88715
- Started by Ferenc Kovacs on 2015-10-07T14:13:33+00:00
- Messages: 4
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · RFCs at https://externals.io/rfc.md · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #88715 — Ferenc Kovacs — 2015-10-07T14:13:33+00:00

URL: https://externals.io/message/88715#88715

Hi,

I have a couple of pending PRs which are all small features with
outstanding bugreports/feature requests and I wasn't sure that they would
need an RFC or not, I would like to get some feedback about that:
https://github.com/php/php-src/pull/1214
https://github.com/php/php-src/pull/1204
https://github.com/php/php-src/pull/969

ps: they are all targeting master and I can merge them myself I just wanted
to make sure if they need further discussion or RFC.

-- 
Ferenc Kovács
@Tyr43l - http://tyrael.hu

---

## #88716 — Anthony Ferrara — 2015-10-07T15:27:59+00:00

URL: https://externals.io/message/88715#88716 · In reply to: #88715

Fernec,


> Hi,
>
> I have a couple of pending PRs which are all small features with
> outstanding bugreports/feature requests and I wasn't sure that they would
> need an RFC or not, I would like to get some feedback about that:
> https://github.com/php/php-src/pull/1214
> https://github.com/php/php-src/pull/1204
> https://github.com/php/php-src/pull/969
>
> ps: they are all targeting master and I can merge them myself I just wanted
> to make sure if they need further discussion or RFC.
>
> --
> Ferenc Kovács
> @Tyr43l - http://tyrael.hu

IMHO they are all simple and self-contained enough not to really need
an RFC. We could bikeshed the function names, etc, but besides that I
don't see much that would warrant an RFC here (based on my
understanding/view on the process).

Thanks

Anthony

---

## #88717 — Anatol Belski — 2015-10-07T17:07:57+00:00

URL: https://externals.io/message/88715#88717 · In reply to: #88715

Hi Ferenc,

> -----Original Message-----
> From: Ferenc Kovacs [mailto:tyra3l@gmail.com]
> Sent: Wednesday, October 7, 2015 4:14 PM
> To: PHP Internals <internals@lists.php.net>
> Subject: [PHP-DEV] couple of PRs for master
> 
> Hi,
> 
> I have a couple of pending PRs which are all small features with outstanding
> bugreports/feature requests and I wasn't sure that they would need an RFC or
> not, I would like to get some feedback about that:
> https://github.com/php/php-src/pull/1214
> https://github.com/php/php-src/pull/1204
> https://github.com/php/php-src/pull/969
> 
> ps: they are all targeting master and I can merge them myself I just wanted to
> make sure if they need further discussion or RFC.
> 
IMO it is fine to take the PRs as is into master. Since those are FRs and small, that's fine.

Regards

Anatol

---

## #88719 — Stanislav Malyshev — 2015-10-07T22:17:39+00:00

URL: https://externals.io/message/88715#88719 · In reply to: #88715

Hi!

> I have a couple of pending PRs which are all small features with
> outstanding bugreports/feature requests and I wasn't sure that they would
> need an RFC or not, I would like to get some feedback about that:
> https://github.com/php/php-src/pull/1214
> https://github.com/php/php-src/pull/1204
> https://github.com/php/php-src/pull/969

Those look uncontroversial (except for comments but I trust you'd adress
those) and simple so I don't think it needs RFC.

-- 
Stas Malyshev
smalyshev@gmail.com
