# Request for php-src karma - Thread: https://externals.io/message/86577 - Original archive: https://news-web.php.net/php.internals/86577 - Started by Christoph Becker on 2015-06-10T22:25:07+00:00 - Messages: 7 - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #86577 — Christoph Becker — 2015-06-10T22:25:07+00:00 URL: https://externals.io/message/86577#86577 Hi! I'm requesting php-src karma (cmb@), mainly for bug-fix purposes. I have already submitted several PRs[1], and several of them have already been merged. It seems to me that it might save time, if I can commit obvious and uncontroversial fixes directly instead of making PRs first. Thanks for your consideration. [1] -- Christoph M. Becker --- ## #86579 — Rasmus Lerdorf — 2015-06-10T22:40:55+00:00 URL: https://externals.io/message/86577#86579 · In reply to: #86577 > Hi! > > I'm requesting php-src karma (cmb@), mainly for bug-fix purposes. I > have already submitted several PRs[1], and several of them have already > been merged. > > It seems to me that it might save time, if I can commit obvious and > uncontroversial fixes directly instead of making PRs first. Done and thanks for all your help and patience on bugs.php.net. -Rasmus --- ## #86581 — Christoph Becker — 2015-06-10T23:00:23+00:00 URL: https://externals.io/message/86577#86581 · In reply to: #86579 Rasmus Lerdorf wrote: > > > > […] > > Done and thanks for all your help and patience on bugs.php.net. Thanks. -- Christoph M. Becker --- ## #86585 — Anatol Belski — 2015-06-11T00:44:42+00:00 URL: https://externals.io/message/86577#86585 · In reply to: #86579 Hi Rasmus, > -----Original Message----- > From: Rasmus Lerdorf [mailto:rasmus@lerdorf.com] > Sent: Thursday, June 11, 2015 12:41 AM > To: Christoph Becker; internals@lists.php.net > Subject: Re: [PHP-DEV] Request for php-src karma > > > > […] > > Done and thanks for all your help and patience on bugs.php.net. > Thanks for giving Christoph the appropriate access, he's a very valuable extension to the team. Christoph, please don't forget to note the changes in the NEWS and/or UPGRADING where appropriate. Also don't forget to check the lower branches where your fixes could be profitable. Thanks. Anatol --- ## #86592 — Christoph Becker — 2015-06-11T11:03:15+00:00 URL: https://externals.io/message/86577#86592 · In reply to: #86585 Anatol Belski wrote: > Christoph, please don't forget to note the changes in the NEWS and/or > UPGRADING where appropriate. Also don't forget to check the lower > branches where your fixes could be profitable. Thanks for the hints. As I understand it, I should inform the release managers about changes in the respective branches.[1][2] What is the best way to do so? [1] [2] (stas' comment) -- Christoph M. Becker --- ## #86596 — Anatol Belski — 2015-06-11T12:01:56+00:00 URL: https://externals.io/message/86577#86596 · In reply to: #86592 Hi Christoph, > -----Original Message----- > From: Christoph Becker [mailto:cmbecker69@gmx.de] > Sent: Thursday, June 11, 2015 1:03 PM > To: Anatol Belski; internals@lists.php.net > Subject: Re: [PHP-DEV] Request for php-src karma > > Anatol Belski wrote: > > > […] > > Thanks for the hints. As I understand it, I should inform the release managers > about changes in the respective branches.[1][2] What is the best way to do so? > > [1] > [2] (stas' comment) > Please note also that there is a number of README files in the php-src dir, like this one http://git.php.net/?p=php-src.git;a=blob;f=README.GIT-RULES . In general, if you fix a bug and it's worth it to mention, you just push a patch and add note into the NEWS. If in doubt, better to ask the RM whether the patch is ok for that particular branch, of course. Pushing to the 5.4 branch is another story as only security fixes go in there, so it has to be cleared out explicitly. The same will apply to any other branch in security mode later, fe 5.5 which active development period ends soon. Also as far as I see, the patch from the ticket you link was not merged up as in accordance to the git workflow. The NEWS file has to be updated in all the active branches but master, usually. Otherwise, if a fix in master only - so only NEWS in master. As we now have no explicit PHP-7.0 branch, NEWS should be updated in master as well until PHP-5.4 is EOL. Regards Anatol --- ## #86598 — Christoph Becker — 2015-06-11T12:13:04+00:00 URL: https://externals.io/message/86577#86598 · In reply to: #86596 Hi Anatol, Anatol Belski wrote: > Hi Christoph, > > > […] > Please note also that there is a number of README files in the php-src dir, like this one http://git.php.net/?p=php-src.git;a=blob;f=README.GIT-RULES . In general, if you fix a bug and it's worth it to mention, you just push a patch and add note into the NEWS. If in doubt, better to ask the RM whether the patch is ok for that particular branch, of course. > > Pushing to the 5.4 branch is another story as only security fixes go in there, so it has to be cleared out explicitly. The same will apply to any other branch in security mode later, fe 5.5 which active development period ends soon. Also as far as I see, the patch from the ticket you link was not merged up as in accordance to the git workflow. > > The NEWS file has to be updated in all the active branches but master, usually. Otherwise, if a fix in master only - so only NEWS in master. As we now have no explicit PHP-7.0 branch, NEWS should be updated in master as well until PHP-5.4 is EOL. Thanks for the explanation. That clarifies my questions. :) -- Christoph M. Becker