# PowerPC64 patchs - Thread: https://externals.io/message/79225 - Original archive: https://news-web.php.net/php.internals/79225 - Started by Gustavo Frederico Temple Pedrosa on 2014-11-27T12:39:20+00:00 - Messages: 13 - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #79225 — Gustavo Frederico Temple Pedrosa — 2014-11-27T12:39:20+00:00 URL: https://externals.io/message/79225#79225 Hi, internals! There are some PRs for supports of PowerPC64 https://github.com/php/php-src/pull/737 https://github.com/php/php-src/pull/919 https://github.com/php/php-src/pull/920 https://github.com/php/php-src/pull/921 https://github.com/php/php-src/pull/922 Anyone can review them, please? Remi, can you do a quick test build, please? Thanks a lot, all! --- ## #79266 — Dmitry Stogov — 2014-11-28T09:10:11+00:00 URL: https://externals.io/message/79225#79266 · In reply to: #79225 I see no problems with these patches. If all tests on PPC are passed, then they should be accepted. The patches won't affect other architectures. Anybody tested? Thanks. Dmitry. On Thu, Nov 27, 2014 at 3:39 PM, Gustavo Frederico Temple Pedrosa < gustavo.pedrosa@eldorado.org.br> wrote: > Hi, internals! > > There are some PRs for supports of PowerPC64 > > https://github.com/php/php-src/pull/737 > https://github.com/php/php-src/pull/919 > https://github.com/php/php-src/pull/920 > https://github.com/php/php-src/pull/921 > https://github.com/php/php-src/pull/922 > > Anyone can review them, please? > > Remi, can you do a quick test build, please? > > Thanks a lot, all! --- ## #79271 — Remi Collet — 2014-11-28T11:53:24+00:00 URL: https://externals.io/message/79225#79271 · In reply to: #79266 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Le 28/11/2014 10:10, Dmitry Stogov a écrit : > I see no problems with these patches. If all tests on PPC are > passed, then they should be accepted. The patches won't affect > other architectures. > > Anybody tested? I should be able to run some scratch build next week Remi. > > Thanks. Dmitry. > > On Thu, Nov 27, 2014 at 3:39 PM, Gustavo Frederico Temple Pedrosa > < gustavo.pedrosa@eldorado.org.br> wrote: > > > […] > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlR4YjQACgkQYUppBSnxahgW7wCeOw6Y/LhfahdsN+d+BrJWMZSG F88AoL7wFCZipQLZP8GMb2FvMNI9V+P4 =3UO6 -----END PGP SIGNATURE --- ## #79300 — Stanislav Malyshev — 2014-11-28T23:04:59+00:00 URL: https://externals.io/message/79225#79300 · In reply to: #79271 Hi! > I should be able to run some scratch build next week That'd be great. I thought about merging them but since I don't have any ppc64 hardware around I was not sure, but if you have some it'd be great. -- Stas Malyshev smalyshev@gmail.com --- ## #79334 — Remi Collet — 2014-12-01T10:09:09+00:00 URL: https://externals.io/message/79225#79334 · In reply to: #79225 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Le 27/11/2014 13:39, Gustavo Frederico Temple Pedrosa a écrit : > Hi, internals! > > There are some PRs for supports of PowerPC64 > > https://github.com/php/php-src/pull/737 > https://github.com/php/php-src/pull/919 > https://github.com/php/php-src/pull/920 > https://github.com/php/php-src/pull/921 > https://github.com/php/php-src/pull/922 I have run a build of master with each PR. Comments added on all. 922 merged. Notice: master on ppc64 seems in quite bad shape, we currently have 111 failed tests (with ./configure --disable-all). I will try to keep the ppc64 machine to run a few more tests. Remi. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlR8PkUACgkQYUppBSnxahjBkQCg5MWGUVT/K/0XPogocxM8vTGA AOkAoNhnlvM0es5opW7Nh7Gu27Cbzi+9 =CkYT -----END PGP SIGNATURE --- ## #79340 — Remi Collet — 2014-12-01T15:27:51+00:00 URL: https://externals.io/message/79225#79340 · In reply to: #79334 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Le 01/12/2014 11:09, Remi Collet a écrit : > Notice: master on ppc64 seems in quite bad shape, we currently > have 111 failed tests (with ./configure --disable-all). 82 fixed 29 to work on... Remi. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlR8iPcACgkQYUppBSnxahgh5wCeOHM+skY4oEP2rc85wlma7jJQ tOoAoJEU9BVdQHkFmWsljB78Tud38K/L =gtvF -----END PGP SIGNATURE --- ## #79373 — Lior Kaplan — 2014-12-02T10:01:11+00:00 URL: https://externals.io/message/79225#79373 · In reply to: #79334 Remi, Any chance to have these fixes for 5.5/5.6 as well? Kaplan > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Le 27/11/2014 13:39, Gustavo Frederico Temple Pedrosa a écrit : > > […] > > I have run a build of master with each PR. > > Comments added on all. > > 922 merged. > > > Notice: master on ppc64 seems in quite bad shape, we currently have > 111 failed tests (with ./configure --disable-all). > > I will try to keep the ppc64 machine to run a few more tests. > > > Remi. > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ > > iEYEARECAAYFAlR8PkUACgkQYUppBSnxahjBkQCg5MWGUVT/K/0XPogocxM8vTGA > AOkAoNhnlvM0es5opW7Nh7Gu27Cbzi+9 > =CkYT > -----END PGP SIGNATURE --- ## #79374 — Andrea Faulds — 2014-12-02T10:11:08+00:00 URL: https://externals.io/message/79225#79374 · In reply to: #79340 > > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Le 01/12/2014 11:09, Remi Collet a écrit : > > […] > > 82 fixed > 29 to work on... > > Remi. Would you mind revealing which tests failed? This might be important to me with bigints. -- Andrea Faulds http://ajf.me/ --- ## #79375 — Ferenc Kovacs — 2014-12-02T10:23:17+00:00 URL: https://externals.io/message/79225#79375 · In reply to: #79374 > > > […] > > Would you mind revealing which tests failed? This might be important to me > with bigints. > if anybody willing to help with the ppc64 test failures, but doesn't have access to a ppc64 machine: it is possible to run ppc64 virtual machines via qemu/kvm, I still have a couple of issues running it on Mac, but it should be easier on linux, here are some relevant links I've found: https://gmplib.org/~tege/qemu.html http://nathaniel.themccallums.org/2013/03/30/qemu-with-powerpc64-guests/ https://github.com/osuosl/packer-templates http://ftp.osuosl.org/pub/osl/openpower/openstack/ https://github.com/adrahon/vagrant-kvm -- Ferenc Kovács @Tyr43l - http://tyrael.hu --- ## #79377 — Remi Collet — 2014-12-02T10:30:31+00:00 URL: https://externals.io/message/79225#79377 · In reply to: #79373 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Le 02/12/2014 11:01, Lior Kaplan a écrit : > Remi, > > Any chance to have these fixes for 5.5/5.6 as well? All failed tests (and fix) are master only related to move to size_t and new mm. The only 5.6 issue (pack/unpack) have be fixed in 5.6+ Remi. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEUEARECAAYFAlR9lMcACgkQYUppBSnxahjsowCfWuiHd3m0TcQkHj+Qj0oXOO+k 2VsAmMGUit06VCEX/EC44tIlzTJ8U04= =EGTp -----END PGP SIGNATURE --- ## #79378 — Remi Collet — 2014-12-02T10:34:00+00:00 URL: https://externals.io/message/79225#79378 · In reply to: #79374 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Le 02/12/2014 11:11, Andrea Faulds a écrit : > Would you mind revealing which tests failed? This might be > important to me with bigints. See my previous mail in this thread failed tests are attached, but most are fixed (well, I haven't test any extension yet) But see more recent "Test suite results on bigendian" mail Only issue with new mm, Dmitry working on it (seems like related to pagesize which is 64k; not 4k) Remi. > -- Andrea Faulds http://ajf.me/ > > > > > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlR9lZcACgkQYUppBSnxahgxOQCghp/rRuzeW8jffJTrNhKJ07jl FlMAnRIdaPqxk2ZYBya4q52z0wLQRk26 =E7O4 -----END PGP SIGNATURE --- ## #79379 — Andrea Faulds — 2014-12-02T10:41:04+00:00 URL: https://externals.io/message/79225#79379 · In reply to: #79378 > > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Le 02/12/2014 11:11, Andrea Faulds a écrit : > > > […] > > See my previous mail in this thread failed tests are attached, but > most are fixed (well, I haven't test any extension yet) Ah, these aren’t the kind of tests which bigints would affect, luckily for me. ^^ -- Andrea Faulds http://ajf.me/ --- ## #79381 — Gustavo Frederico Temple Pedrosa — 2014-12-02T13:11:31+00:00 URL: https://externals.io/message/79225#79381 · In reply to: #79373 Lior, Remi performed the tests and I'm correcting now the errors. The PR #737 was closed and the PR #922 was merged :) Thanks. > From: Lior Kaplan [mailto:lior.k@zend.com] > Sent: terça-feira, 2 de dezembro de 2014 08:01 > To: Remi Collet > Cc: Gustavo Frederico Temple Pedrosa; PHP Internals > Subject: Re: [PHP-DEV] Re: PowerPC64 patchs > > Remi, > > Any chance to have these fixes for 5.5/5.6 as well? > > Kaplan > > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Le 27/11/2014 13:39, Gustavo Frederico Temple Pedrosa a écrit : > > […] > > I have run a build of master with each PR. > > Comments added on all. > > 922 merged. > > > Notice: master on ppc64 seems in quite bad shape, we currently have > 111 failed tests (with ./configure --disable-all). > > I will try to keep the ppc64 machine to run a few more tests. > > > Remi. > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ > > iEYEARECAAYFAlR8PkUACgkQYUppBSnxahjBkQCg5MWGUVT/K/0XPogocxM8vTGA > AOkAoNhnlvM0es5opW7Nh7Gu27Cbzi+9 > =CkYT > -----END PGP SIGNATURE