# domxml memleak patches into PHP_4_3?

- Thread: https://externals.io/message/774
- Original archive: https://news-web.php.net/php.internals/774
- Started by Christian Stocker on 2003-04-08T01:13:48+00:00
- Messages: 2
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #776 — Rasmus Lerdorf — 2003-04-08T00:46:49+00:00

URL: https://externals.io/message/774#776 · In reply to: #774

I think this should go in.  Like you said, for anything long-running, the 
current domxml is almost useless, so I would consider this a bug fix.

-Rasmus



> Hi
> 
> (Mainly) Rob Richards and (just a tiny little bit) me were hunting down
> some domxml memleaks (and Rob implemented DomDocument->free() method.
> Hooray ;) ). As we are rather late in the release process of PHP 4.3.2,
> I'm not sure, if it's wise to commit them now to the PHP_4_3 branch or
> if I should wait until after this release.
> 
> Furthermore, the DomDocument->free() method was a much asked feature for
> domxml (and it really helps saving memory, if you want to process a lot
> of XML-Documents in one run). Would it be totally against the release
> rule if I add that function after 4.3.2 is released to the PHP_4_3
> branch?
> 
> Anyway, the diff file (against ext/domxml HEAD, not PHP_4_3 for the time
> being) can be found at http://trash.chregu.tv/domxml.memleak.diff, if
> anyone wants to use/test it right now
> 
> chregu

---

## #774 — Christian Stocker — 2003-04-08T01:13:48+00:00

URL: https://externals.io/message/774#774

Hi

(Mainly) Rob Richards and (just a tiny little bit) me were hunting down
some domxml memleaks (and Rob implemented DomDocument->free() method.
Hooray ;) ). As we are rather late in the release process of PHP 4.3.2,
I'm not sure, if it's wise to commit them now to the PHP_4_3 branch or
if I should wait until after this release.

Furthermore, the DomDocument->free() method was a much asked feature for
domxml (and it really helps saving memory, if you want to process a lot
of XML-Documents in one run). Would it be totally against the release
rule if I add that function after 4.3.2 is released to the PHP_4_3
branch?

Anyway, the diff file (against ext/domxml HEAD, not PHP_4_3 for the time
being) can be found at http://trash.chregu.tv/domxml.memleak.diff, if
anyone wants to use/test it right now

chregu