# Can someone with Zend karma please merge PR #674?

- Thread: https://externals.io/message/74785
- Original archive: https://news-web.php.net/php.internals/74785
- Started by Levi Morrison on 2014-06-08T23:46:47+00:00
- Messages: 5
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #74785 — Levi Morrison — 2014-06-08T23:46:47+00:00

URL: https://externals.io/message/74785#74785

https://github.com/php/php-src/pull/674

It fixes bug 66622: https://bugs.php.net/bug.php?id=66622

I've prodded people on #php.pecl and nobody has had any complaints
about it, so I don't anticipate any issues; if there is an issue do
let me know.

---

## #74786 — Stas Malyshev — 2014-06-08T23:57:02+00:00

URL: https://externals.io/message/74785#74786 · In reply to: #74785

Hi!

> https://github.com/php/php-src/pull/674
> 
> It fixes bug 66622: https://bugs.php.net/bug.php?id=66622
> I've prodded people on #php.pecl and nobody has had any complaints

Didn't we just has a discussion about it an hour ago?

> about it, so I don't anticipate any issues; if there is an issue do
> let me know.

I still don't think we should move the tests around.

-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

---

## #74787 — Levi Morrison — 2014-06-09T00:05:50+00:00

URL: https://externals.io/message/74785#74787 · In reply to: #74786

> Hi!
>
> > […]
>
> Didn't we just has a discussion about it an hour ago?

No, you mentioned one tiny thing that isn't really about the bug fix.
That's hardly a conversation.

> > […]
>
> I still don't think we should move the tests around.

I disagree but it is a minor point. Others have said it makes sense to
put related tests in a folder in IRC.

I don't really care; you can easily not apply those changes.

---

## #74788 — Levi Morrison — 2014-06-09T00:10:04+00:00

URL: https://externals.io/message/74785#74788 · In reply to: #74787

> I don't really care; you can easily not apply those changes.

To clarify, those changes are in a separate commit so that's why it
would be easy to not apply them.

---

## #74790 — Levi Morrison — 2014-06-09T01:41:07+00:00

URL: https://externals.io/message/74785#74790 · In reply to: #74786

> Hi!
>
> > […]
>
> Didn't we just has a discussion about it an hour ago?
>
> > […]
>
> I still don't think we should move the tests around.

I've rebased the PR to not change the phpt locations even though I
think they are better in a subdirectory.

A local `make test` shows nothing has been broken; Travis CI will
hopefully confirm the same in a bit.