# To check in NetWare changes.

- Thread: https://externals.io/message/7409
- Original archive: https://news-web.php.net/php.internals/7409
- Started by Ananth Kesari on 2004-01-30T06:11:23+00:00
- Messages: 3
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #7409 — Ananth Kesari — 2004-01-30T06:11:23+00:00

URL: https://externals.io/message/7409#7409

Oops. I did not know that the system only accepts text/plain
attachments. Here is the attachment for TSRM diff. This is in
text format. I will send the diff for the whole project soon.

Thanks,
Ananth.

> > […]


> Our changes are spread across many files, so I am not sure if we can
> checkin at this stage of the release of PHP 5.0. Anyway, I have
> attached the diff file for TSRM. Please review the same and give me
> your comments. There are similar changes in other files. If you
think
> I should send across the diffs for other files also, then I will do
> so. Let me know.

Just make *one* diff against latest CVS of all changes? And you didn't
add an attachment (we only accept text/plain attachments here).

> In the meantime, I have a question. I am interested in contributing
> to the Open source PHP. I was thinking that the good way to start
> could be to begin working on some simple defects and fix them.
> Can you let me know if I can do that and if yes, how? I mean,
> where to look for the defects filed and what is the procedure to
> start fixing them?

Have a look at bugs.php.net, there are plenty of open bugs.

regards,
Derick

---

## #7410 — Marcus Boerger — 2004-01-30T07:01:43+00:00

URL: https://externals.io/message/7409#7410 · In reply to: #7409

Hello Ananth,

please provide a unified diff (cvs di -u) and we cannot accept
precompiler statements starting after column 0. You *must* keep
this in mind. For a full list of rules to follow you can visit
the file CODING_STANDARDS.

regards
marcus

Friday, January 30, 2004, 7:11:23 AM, you wrote:

> Oops. I did not know that the system only accepts text/plain
> attachments. Here is the attachment for TSRM diff. This is in
> text format. I will send the diff for the whole project soon.

> Thanks,
> Ananth.

> > […]
> 

> > […]
> think
> > […]

> Just make *one* diff against latest CVS of all changes? And you didn't
> add an attachment (we only accept text/plain attachments here).

> > […]

> Have a look at bugs.php.net, there are plenty of open bugs.

> regards,
> Derick




-- 
Best regards,
 Marcus                            mailto:helly@php.net

---

## #7414 — Derick Rethans — 2004-01-30T08:56:04+00:00

URL: https://externals.io/message/7409#7414 · In reply to: #7409

> Oops. I did not know that the system only accepts text/plain
> attachments. Here is the attachment for TSRM diff. This is in
> text format. I will send the diff for the whole project soon.

In unified diff pretty please? :) (cvs diff -u)

regards,
Derick