# To check in NetWare changes.

- Thread: https://externals.io/message/7399
- Original archive: https://news-web.php.net/php.internals/7399
- Started by Ananth Kesari on 2004-01-29T11:50:51+00:00
- Messages: 3
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #7399 — Ananth Kesari — 2004-01-29T11:50:51+00:00

URL: https://externals.io/message/7399#7399

Hi,

Our changes are spread across many files, so I am not sure if we can
checkin at this stage of the release of PHP 5.0. Anyway, I have
attached
the diff file for TSRM. Please review the same and give me your
comments.
There are similar changes in other files. If you think I should send
across
the diffs for other files also, then I will do so. Let me know.

In the meantime, I have a question. I am interested in contributing
to the Open source PHP. I was thinking that the good way to start
could be to begin working on some simple defects and fix them.
Can you let me know if I can do that and if yes, how? I mean,
where to look for the defects filed and what is the procedure to
start fixing them?

Thanks,
Ananth.

> > […]
Hi,

We are indeed in a feature freeze. However, if your diff is simple and
well 
written, we could consider including it (basically as a bug fix for
novell).
Please send a diff so that we can see if it's something which can go
in. It 
really depends on the extent of your patch.
If we feel it's too many changes which aren't self contained then it
might 
be a problem.

Andi

At 02:06 AM 1/22/2004 -0700, Ananth Kesari wrote:
>Hi Andi,
>
>Now that it is in code-freeze stage, when is PHP 5.0 going to be
>released?
>We have NetWare changes of approximately about 200 to 250 lines
>(maybe even more) spread across many files that include, TSRM, ZEND,
>sapi modules, extensions, ext/standard, main and netware directories.
>
>Thanks,
>Ananth.
>
> > […]
>At 04:48 AM 1/21/2004 -0700, Ananth Kesari wrote:
> > […]
is
>the
> > […]
>
>Ananth,
>
>We are in a code-freeze now. You are welcome to commit bug fixes to
the
>CVS
>but if this requires serious changes then you're going to have to
save
>them
>for 5.0.1.
>You can checkout the php5 module and commit there (on HEAD).
>
>Andi

---

## #7400 — Derick Rethans — 2004-01-29T11:56:01+00:00

URL: https://externals.io/message/7399#7400 · In reply to: #7399

> Our changes are spread across many files, so I am not sure if we can
> checkin at this stage of the release of PHP 5.0. Anyway, I have
> attached the diff file for TSRM. Please review the same and give me
> your comments. There are similar changes in other files. If you think
> I should send across the diffs for other files also, then I will do
> so. Let me know.

Just make *one* diff against latest CVS of all changes? And you didn't
add an attachment (we only accept text/plain attachments here).

> In the meantime, I have a question. I am interested in contributing
> to the Open source PHP. I was thinking that the good way to start
> could be to begin working on some simple defects and fix them.
> Can you let me know if I can do that and if yes, how? I mean,
> where to look for the defects filed and what is the procedure to
> start fixing them?

Have a look at bugs.php.net, there are plenty of open bugs.

regards,
Derick

---

## #7401 — Jani Taskinen — 2004-01-29T12:33:54+00:00

URL: https://externals.io/message/7399#7401 · In reply to: #7399

>could be to begin working on some simple defects and fix them.
>Can you let me know if I can do that and if yes, how? I mean,
>where to look for the defects filed and what is the procedure to
>start fixing them?

    Here are some (longish) urls that list only the relevant bug reports:
    
    PHP4:
    
    http://bugs.php.net/search.php?order_by=id&direction=DESC&cmd=display&status=Open&bug_ntype%5B%5D=Feature%2FChange+Request&bug_ntype%5B%5D=Documentation+problem&bug_ntype%5B%5D=Zend+Engine+2+problem&bug_ntype%5B%5D=PEAR+related&bug_ntype%5B%5D=PECL+related&bug_ntype%5B%5D=PHP-GTK+related&bug_ntype%5B%5D=Website+problem&phpver=4
    
    PHP5:
    
    http://bugs.php.net/search.php?order_by=id&direction=DESC&cmd=display&status=Open&bug_ntype%5B%5D=Feature%2FChange+Request&bug_ntype%5B%5D=Documentation+problem&bug_ntype%5B%5D=PEAR+related&bug_ntype%5B%5D=PECL+related&bug_ntype%5B%5D=PHP-GTK+related&bug_ntype%5B%5D=Website+problem&phpver=5
    
    You could start by checking which you can reproduce, and if you
    can fix them, provide a patch on this mailing list.
    
    --Jani