# failing intl test (ext/intl/tests/dateformat_format_variant2.phpt) - Thread: https://externals.io/message/73621 - Original archive: https://news-web.php.net/php.internals/73621 - Started by Ferenc Kovacs on 2014-04-07T12:48:47+00:00 - Messages: 7 - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #73621 — Ferenc Kovacs — 2014-04-07T12:48:47+00:00 URL: https://externals.io/message/73621#73621 Hi, I have never managed to make this test pass for me, even thought that I was trying with different ICU versions. I'm currently testing with ICU 52.1 from homebrew on Mavericks and with the same ICU version on debian wheezy and it fails with the same diff: 209+ 'timezone_type' => 2,^M 210+ 'timezone' => 'PDT',^M 209- 'timezone_type' => 3,^M 210- 'timezone' => 'America/Los_Angeles',^M 217+ 'timezone_type' => 2,^M 218+ 'timezone' => 'PDT',^M 217- 'timezone_type' => 3,^M 218- 'timezone' => 'America/Los_Angeles',^M 225+ 'timezone_type' => 2,^M 226+ 'timezone' => 'PDT',^M 225- 'timezone_type' => 3,^M 226- 'timezone' => 'America/Los_Angeles',^M 233+ 'timezone_type' => 2,^M 234+ 'timezone' => 'PDT',^M 233- 'timezone_type' => 3,^M 234- 'timezone' => 'America/Los_Angeles',^M 241+ 'timezone_type' => 2,^M 242+ 'timezone' => 'PDT',^M 241- 'timezone_type' => 3,^M 242- 'timezone' => 'America/Los_Angeles', Could anybody who has this test passing tell me what ICU version are you testing with? -- Ferenc Kovács @Tyr43l - http://tyrael.hu --- ## #73625 — Anatol Belski — 2014-04-07T15:45:41+00:00 URL: https://externals.io/message/73621#73625 · In reply to: #73621 Hi Ferenc, > Hi, > > > I have never managed to make this test pass for me, even thought that I > was trying with different ICU versions. I'm currently testing with ICU 52.1 > from homebrew on Mavericks and with the same ICU version on debian wheezy > and it fails with the same diff: > > 209+ 'timezone_type' => 2,^M > 210+ 'timezone' => 'PDT',^M > 209- 'timezone_type' => 3,^M > 210- 'timezone' => 'America/Los_Angeles',^M > 217+ 'timezone_type' => 2,^M > 218+ 'timezone' => 'PDT',^M > 217- 'timezone_type' => 3,^M > 218- 'timezone' => 'America/Los_Angeles',^M > 225+ 'timezone_type' => 2,^M > 226+ 'timezone' => 'PDT',^M > 225- 'timezone_type' => 3,^M > 226- 'timezone' => 'America/Los_Angeles',^M > 233+ 'timezone_type' => 2,^M > 234+ 'timezone' => 'PDT',^M > 233- 'timezone_type' => 3,^M > 234- 'timezone' => 'America/Los_Angeles',^M > 241+ 'timezone_type' => 2,^M > 242+ 'timezone' => 'PDT',^M > 241- 'timezone_type' => 3,^M > 242- 'timezone' => 'America/Los_Angeles', > > > Could anybody who has this test passing tell me what ICU version are you > testing with? > > -- > Ferenc Kovács > @Tyr43l - http://tyrael.hu > > I've forked this one into ext/intl/tests/dateformat_format_variant3.phpt and adjusted the output for 52.1. The variant 2 is worky with at least ICI 51.2, i've added the corresponding condition to the skipif. Looks like this change happens somewhere between ICU 51.2 and 52. Cheers Anatol --- ## #73626 — Alexey Zakhlestin — 2014-04-07T18:06:47+00:00 URL: https://externals.io/message/73621#73626 · In reply to: #73625 > Hi Ferenc, > > > > […] > I've forked this one into ext/intl/tests/dateformat_format_variant3.phpt > and adjusted the output for 52.1. The variant 2 is worky with at least ICI > 51.2, i've added the corresponding condition to the skipif. Looks like > this change happens somewhere between ICU 51.2 and 52. well… the question is: should something like this be tested anyway? tests should cover things which are guaranteed to work specific way by us, not by external libraries. -- Alexey Zakhlestin CTO at Grids.by/you https://github.com/indeyets PGP key: http://indeyets.ru/alexey.zakhlestin.pgp.asc --- ## #73631 — Yasuo Ohgaki — 2014-04-08T00:48:21+00:00 URL: https://externals.io/message/73621#73631 · In reply to: #73621 Hi Ferenc, > Could anybody who has this test passing tell me what ICU version are you > testing with? > I use Fedora20 and it comes with $ rpm -q libicu libicu-50.1.2-10.fc20.x86_64 and does not work. So I installed $ ll /usr/local/lib/libicu* lrwxrwxrwx. 1 root root 20 1月 30 08:44 /usr/local/lib/libicudata.so -> libicudata.so.48.1.1 lrwxrwxrwx. 1 root root 20 1月 30 08:44 /usr/local/lib/libicudata.so.48 -> libicudata.so.48.1.1 *SNIP* lrwxrwxrwx. 1 root root 18 1月 30 08:44 /usr/local/lib/libicuuc.so.48 -> libicuuc.so.48.1.1 -rwxr-xr-x. 1 root root 1713890 1月 30 08:44 /usr/local/lib/libicuuc.so.48.1.1 then it worked for me. I'm not sure exact version, but it would be following following source. (w/o debian patch) http://icu.sourcearchive.com/downloads/4.8.1.1-14/ BTW, I seems current build system has problem building with specific ICU version libs, but it works if target ICU version is installed under /usr/local. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --- ## #73632 — Yasuo Ohgaki — 2014-04-08T01:09:07+00:00 URL: https://externals.io/message/73621#73632 · In reply to: #73631 > BTW, I seems current build system has problem building with specific ICU > version libs, but it works if target ICU version is installed under > /usr/local. I meant "It seems". I haven't looked into what's wrong. Could anyone fix this issue? It would be nice to test with various ICU versions. Regards -- Yasuo Ohgaki yohgaki@ohgaki.net --- ## #73635 — Ferenc Kovacs — 2014-04-08T06:32:13+00:00 URL: https://externals.io/message/73621#73635 · In reply to: #73632 > > > > […] > > > I meant "It seems". > I haven't looked into what's wrong. Could anyone fix this issue? > It would be nice to test with various ICU versions. > > Regards > > -- > Yasuo Ohgaki > yohgaki@ohgaki.net > for building with specific ICU version from a custom location I'm using --with-icu-dir=/opt/homebrew/opt/icu4c and it seems to work just fine. could you ellaborate what errors do you experience? -- Ferenc Kovács @Tyr43l - http://tyrael.hu --- ## #73636 — Anatol Belski — 2014-04-08T07:15:18+00:00 URL: https://externals.io/message/73621#73636 · In reply to: #73626 Hi Alexey, > > > > > > […] > > well… the question is: should something like this be tested anyway? tests > should cover things which are guaranteed to work specific way by us, not > by external libraries. > > -- > Alexey Zakhlestin > CTO at Grids.by/you > https://github.com/indeyets > PGP key: http://indeyets.ru/alexey.zakhlestin.pgp.asc > > we can't test every single version, but at least we ensure some of the changes rapidly happening in ICU. There's pretty much data, and that's somehow an issue because it's causing erroneous bug reports. On the other hand, if we would reduce the tests only to the functionality within PHP responsibility, then they were quite a few. So I would say it's fine to test the way we do, at least at the time where some new ICU version arises, failing tests can show what was changed and whether PHP is fine with that. Almost that's data change, but sometimes it could be something more serious, too. Regards Anatol