# [RFC] [accepted] ldap_modify_batch

- Thread: https://externals.io/message/71186
- Original archive: https://news-web.php.net/php.internals/71186
- Started by ondra.hosek@gmail.com on 2014-01-16T14:17:44+00:00
- Messages: 6
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #71186 — ondra.hosek@gmail.com — 2014-01-16T14:17:44+00:00

URL: https://externals.io/message/71186#71186

Hello,

today, voting for ldap_modify_batch [1] ended with 5 votes in favor
and none against.

I have two questions regarding the rest of the process, given that
this is my first contribution to the PHP project:

1. What would be the easiest way to supply the changes to the project?
Open a pull request on Github? Send a patch to someone?

2. Which version should ldap_modify_batch land in? Only in 5.6 or will
it be backported? Against which branch should I submit the pull
request or patch? (master? 5.5 (newest stable)? 5.3 (oldest supported
stable)? earliest possible?)

Thanks for your help in advance!

Cheers,
~~ Ondra

[1] https://wiki.php.net/rfc/ldap_modify_batch

---

## #71187 — Mike — 2014-01-16T15:04:35+00:00

URL: https://externals.io/message/71186#71187 · In reply to: #71186

> Hello,
> 
> today, voting for ldap_modify_batch [1] ended with 5 votes in favor
> and none against.

Congrats to your first contribution!

> I have two questions regarding the rest of the process, given that
> this is my first contribution to the PHP project:
> 
> 1. What would be the easiest way to supply the changes to the project?
> Open a pull request on Github? Send a patch to someone?

Definitely open a PR on github, that should be the easiest.

> 2. Which version should ldap_modify_batch land in? Only in 5.6 or will
> it be backported? Against which branch should I submit the pull
> request or patch? (master? 5.5 (newest stable)? 5.3 (oldest supported
> stable)? earliest possible?)

Definitely not in 5.3, probably not in 5.4 and IMO fine for 5.5.
So whatever RMs think is appropriate, either 5.5 or 5.6, RMs?


-- 
Regards,
Mike

---

## #71204 — Stas Malyshev — 2014-01-17T09:21:03+00:00

URL: https://externals.io/message/71186#71204 · In reply to: #71186

Hi!

> 2. Which version should ldap_modify_batch land in? Only in 5.6 or will
> it be backported? Against which branch should I submit the pull
> request or patch? (master? 5.5 (newest stable)? 5.3 (oldest supported
> stable)? earliest possible?)

Looking at the patch, I don't see a problem having it in 5.4 and 5.5.
5.3 is security fixes only, so it can't be there.

And yes, best way to do it is to create a pull on github, let people
review it and then have somebody merge it.
-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

---

## #71398 — ondra.hosek@gmail.com — 2014-01-22T07:36:30+00:00

URL: https://externals.io/message/71186#71398 · In reply to: #71187

> 
> > […]
>
> Definitely not in 5.3, probably not in 5.4 and IMO fine for 5.5.
> So whatever RMs think is appropriate, either 5.5 or 5.6, RMs?

RMs: what's your take on this?

Cheers,
~~ Ondra

---

## #71409 — Ferenc Kovacs — 2014-01-22T13:37:54+00:00

URL: https://externals.io/message/71186#71409 · In reply to: #71398

> 
> > […]
>
> RMs: what's your take on this?
>
> Cheers,
> ~~ Ondra
>

I agree with Stas here, it could go to 5.4 and upwards.

-- 
Ferenc Kovács
@Tyr43l - http://tyrael.hu

---

## #71423 — ondra.hosek@gmail.com — 2014-01-23T08:00:16+00:00

URL: https://externals.io/message/71186#71423 · In reply to: #71409

> I agree with Stas here, it could go to 5.4 and upwards.

Alright, I've opened a pull request against 5.4:

https://github.com/php/php-src/pull/571

Cheers,
~~ Ondra