# [VOTE] Default character encoding - Thread: https://externals.io/message/70779 - Original archive: https://news-web.php.net/php.internals/70779 - Started by Yasuo Ohgaki on 2013-12-20T01:06:09+00:00 - Messages: 29 - Page 1 of 2: messages 1 to 25 (25 per page, add `?page=N` to the URL) - Next page: https://externals.io/message/70779.md?page=2 - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #70779 — Yasuo Ohgaki — 2013-12-20T01:06:09+00:00 URL: https://externals.io/message/70779#70779 Hi all, I've opened up default character encoding RFC for voting. https://wiki.php.net/rfc/default_encoding This RFC proposes consolidating character encoding setting. Vote ends 2014/01/03. Thank you for voting! Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --- ## #70788 — Levi Morrison — 2013-12-20T20:25:47+00:00 URL: https://externals.io/message/70779#70788 · In reply to: #70779 > > Vote ends 2014/01/03. > Would you please consider extending the vote one more week because of the holiday season / end of year festivities? Thanks. --- ## #70790 — Andrea Faulds — 2013-12-20T21:07:03+00:00 URL: https://externals.io/message/70779#70790 · In reply to: #70789 > Yasuo Ohgaki wrote: > > […] > > Not directly related to this vote, but ... how does one get to see the > bottom of the page? There are no scroll bars, and page down does not > work? I presume that the current voting IS at the bottom of the page? > Some CSS change seems to have broke it. While it's fine for me in modern Firefox, trying it in Opera Mini on my phone, Android Browser (2.3.6 Gingerbread) or IE8 (Windows XP) fails and I can't scroll down. I'd suggest you try using a newer browser until this is fixed. -- Andrea Faulds http://ajf.me/ --- ## #70789 — Lester Caine — 2013-12-20T21:07:19+00:00 URL: https://externals.io/message/70779#70789 · In reply to: #70779 Yasuo Ohgaki wrote: > Hi all, > > I've opened up default character encoding RFC for voting. > > https://wiki.php.net/rfc/default_encoding > > This RFC proposes consolidating character encoding setting. > Vote ends 2014/01/03. > > Thank you for voting! Not directly related to this vote, but ... how does one get to see the bottom of the page? There are no scroll bars, and page down does not work? I presume that the current voting IS at the bottom of the page? -- Lester Caine - G8HFL ----------------------------- Contact - http://lsces.co.uk/wiki/?page=contact L.S.Caine Electronic Services - http://lsces.co.uk EnquirySolve - http://enquirysolve.com/ Model Engineers Digital Workshop - http://medw.co.uk Rainbow Digital Media - http://rainbowdigitalmedia.co.uk --- ## #70793 — Rasmus Lerdorf — 2013-12-20T22:46:28+00:00 URL: https://externals.io/message/70779#70793 · In reply to: #70792 > Forwarded to right place ;) > > Andrea Faulds wrote: > > […] > > I'm on the current version of Seamonkey on Linux already ... > > This 'responsive' theme is simply not working for me. I'd changed the > font size to 150% to make it readable, so the table of contents had > droped to the bottom and is currently inaccessible. I'd not realised it > WAS there as I could not scroll down. Ditch the 'fixed bottom' ... it's > not any use and is preventing a normal scroll bar appearing. > > Actually I'm now seeing several problems with each of the scale change > setups. Where should wiki bugs be reported? Did you shift-reload the page? This was fixed hours ago. At least the fixed header/footer stuff. -Rasmus --- ## #70792 — Lester Caine — 2013-12-20T22:46:36+00:00 URL: https://externals.io/message/70779#70792 · In reply to: #70790 Forwarded to right place ;) Andrea Faulds wrote: > Some CSS change seems to have broke it. While it's fine for me in modern > Firefox, trying it in Opera Mini on my phone, Android Browser (2.3.6 > Gingerbread) or IE8 (Windows XP) fails and I can't scroll down. > > I'd suggest you try using a newer browser until this is fixed. I'm on the current version of Seamonkey on Linux already ... This 'responsive' theme is simply not working for me. I'd changed the font size to 150% to make it readable, so the table of contents had droped to the bottom and is currently inaccessible. I'd not realised it WAS there as I could not scroll down. Ditch the 'fixed bottom' ... it's not any use and is preventing a normal scroll bar appearing. Actually I'm now seeing several problems with each of the scale change setups. Where should wiki bugs be reported? -- Lester Caine - G8HFL ----------------------------- Contact - http://lsces.co.uk/wiki/?page=contact L.S.Caine Electronic Services - http://lsces.co.uk EnquirySolve - http://enquirysolve.com/ Model Engineers Digital Workshop - http://medw.co.uk Rainbow Digital Media - http://rainbowdigitalmedia.co.uk --- ## #70796 — Lester Caine — 2013-12-21T01:06:36+00:00 URL: https://externals.io/message/70779#70796 · In reply to: #70793 Rasmus Lerdorf wrote: > > > […] > Did you shift-reload the page? This was fixed hours ago. At least the > fixed header/footer stuff. Partially working better now ... But the first time I looked was only a few hours ago perhaps ten minutes before I posted. The layout is simply wrong. Having a fixed little block floating in the middle of the 'large' layout, and the table of contents not then fixed on the right is just strange, but I have to stretch the browser out to get that ... 'middle' mode is a lot more readable. On the 'middle' layout which is the one I'm getting when I have the font at a suitable size, having the table of content at the bottom is just wrong, it should be either a popout at the top, or simply on top! And the fixed bar getting hidden under the right hand side makes it difficult to get at. In 'small' mode, there is a button for the top menu, but it does not work? All I get is the truncated heading, body, toc and a big footer block. Part of the problem is probably due to the changes in the way firefox/seamonkey now handles 'scaling' of pages with our having lost the much better ability to simply change font size. Now everything is scaled and that makes the style used by sites more 'invasive' when font sizes are set for better readability. But readability is equally bad on Dolphin on the android devices with 1/3 of the screen now blank so one has to scroll a lot more to read something which used to fill the whole screen. Devices have moved on considerably from what people think is the right settings for 'default' widths :( If I could convince the website to provide 'middle' mode on the android devices things would be a lot more readable. -- Lester Caine - G8HFL ----------------------------- Contact - http://lsces.co.uk/wiki/?page=contact L.S.Caine Electronic Services - http://lsces.co.uk EnquirySolve - http://enquirysolve.com/ Model Engineers Digital Workshop - http://medw.co.uk Rainbow Digital Media - http://rainbowdigitalmedia.co.uk --- ## #70797 — Lester Caine — 2013-12-21T01:17:45+00:00 URL: https://externals.io/message/70779#70797 · In reply to: #70796 Lester Caine wrote: > In 'small' mode, there is a button for the top menu, but it does not work? Found that the 'hot spot' for the button is restricted to a small area to the top right hand corner ... easier to hit with a touch screen ... but easy to miss with the mouse unless you move to the right area. -- Lester Caine - G8HFL ----------------------------- Contact - http://lsces.co.uk/wiki/?page=contact L.S.Caine Electronic Services - http://lsces.co.uk EnquirySolve - http://enquirysolve.com/ Model Engineers Digital Workshop - http://medw.co.uk Rainbow Digital Media - http://rainbowdigitalmedia.co.uk --- ## #70798 — Yasuo Ohgaki — 2013-12-21T01:31:04+00:00 URL: https://externals.io/message/70779#70798 · In reply to: #70788 Hi Levi, On Sat, Dec 21, 2013 at 5:25 AM, Levi Morrison wrote: > Would you please consider extending the vote one more week because of the > holiday season / end of year festivities? Thanks. Good suggestion! I'll extend a week. Thank you. -- Yasuo Ohgaki yohgaki@ohgaki.net --- ## #70799 — Yasuo Ohgaki — 2013-12-21T01:32:51+00:00 URL: https://externals.io/message/70779#70799 · In reply to: #70789 Hi Lester, > Not directly related to this vote, but ... how does one get to see the > bottom of the page? There are no scroll bars, and page down does not work? > I presume that the current voting IS at the bottom of the page? https://wiki.php.net/rfc/default_encoding#vote This link would work. Thank you for point it out. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --- ## #70800 — Andrea Faulds — 2013-12-21T03:08:18+00:00 URL: https://externals.io/message/70779#70800 · In reply to: #70799 > > https://wiki.php.net/rfc/default_encoding#vote > > This link would work. > Thank you for point it out. > Actually, if you're affected by this, it doesn't work :( -- Andrea Faulds http://ajf.me/ --- ## #70802 — chobie — 2013-12-21T07:27:05+00:00 URL: https://externals.io/message/70779#70802 · In reply to: #70779 I'm getting confused when reading your rfc. > mbstring.http_input (Default: php.output_encoding) Is this correct? I think `(Defualt: php.input_encoding)` is correct. 2013/12/20 Yasuo Ohgaki : > Hi all, > > I've opened up default character encoding RFC for voting. > > https://wiki.php.net/rfc/default_encoding > > This RFC proposes consolidating character encoding setting. > Vote ends 2014/01/03. > > Thank you for voting! > > Regards, > > -- > Yasuo Ohgaki > yohgaki@ohgaki.net --- ## #70804 — Yasuo Ohgaki — 2013-12-21T08:38:51+00:00 URL: https://externals.io/message/70779#70804 · In reply to: #70802 > I'm getting confused when reading your rfc. > > > […] > > Is this correct? I think `(Defualt: php.input_encoding)` is correct. > Thank you for the correction. I'll fix this now! Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --- ## #71288 — Yasuo Ohgaki — 2014-01-20T00:48:09+00:00 URL: https://externals.io/message/70779#71288 · In reply to: #70779 HI all, > I've opened up default character encoding RFC for voting. > > https://wiki.php.net/rfc/default_encoding > > This RFC proposes consolidating character encoding setting. > Vote ends 2014/01/03. > Since this RFC is accepted, I've created PR for review. https://github.com/php/php-src/pull/568 Please comment. Thank you. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --- ## #71420 — Yasuo Ohgaki — 2014-01-23T04:17:39+00:00 URL: https://externals.io/message/70779#71420 · In reply to: #71288 Hi all, > Since this RFC is accepted, I've created PR for review. > > https://github.com/php/php-src/pull/568 > > Please comment. Thank you. If there is no comment, I'll commit this later. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --- ## #71579 — Stas Malyshev — 2014-01-26T06:22:10+00:00 URL: https://externals.io/message/70779#71579 · In reply to: #71420 Hi! > > […] > > > If there is no comment, I'll commit this later. I see that some tests on Travis segfault with this patch. Could you please check what's going on? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 --- ## #71582 — Yasuo Ohgaki — 2014-01-26T09:20:23+00:00 URL: https://externals.io/message/70779#71582 · In reply to: #71579 Hi Stas, On Sun, Jan 26, 2014 at 3:22 PM, Stas Malyshev wrote: > I see that some tests on Travis segfault with this patch. Could you > please check what's going on? > It's because these tests were skipped by mistake. They were enabled only for 5.3 and less :( Typical configuration works, but it's better to be resolved soon bugs. I don't have much time now, so I hope someone has time to take care... Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --- ## #71595 — Stas Malyshev — 2014-01-26T20:15:13+00:00 URL: https://externals.io/message/70779#71595 · In reply to: #71582 Hi! > Typical configuration works, but it's better to be resolved soon bugs. > I don't have much time now, so I hope someone has time to take care... Well, we can not merge a patch that segfaults. So until this is fixed, that patch is a no go. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 --- ## #71603 — Yasuo Ohgaki — 2014-01-26T22:18:00+00:00 URL: https://externals.io/message/70779#71603 · In reply to: #71595 Hi Stas, On Mon, Jan 27, 2014 at 5:15 AM, Stas Malyshev wrote: > > […] > > Well, we can not merge a patch that segfaults. So until this is fixed, > that patch is a no go. The patch is not causing segfaults. Zend engine is segfaulting for zend_multibyte tests. It's a separate issue. You'll see segfaults in 5.4 and up without my patch. I've merged zend_multibyte tests fixes already. That's the reason why you see failing tests on 5.4 and up. It's a different issue and if nobody is willing to fix. I'll fix zend_multibyte next month. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --- ## #71607 — Stas Malyshev — 2014-01-26T22:29:25+00:00 URL: https://externals.io/message/70779#71607 · In reply to: #71603 Hi! > The patch is not causing segfaults. > > Zend engine is segfaulting for zend_multibyte tests. > It's a separate issue. You'll see segfaults in 5.4 and up without > my patch. No, I don't see segfaults on Travis tests without your patch, but I do see it with your patch. Which tests are segfaulting without your patch for you? This needs to be fixed ASAP, segfaults in core code is not a good thing. > I've merged zend_multibyte tests fixes already. That's the reason why you > see failing tests on 5.4 and up. I'm not sure I understand what you mean? If those are test fixes, how come they cause tests to fail? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 --- ## #71608 — Yasuo Ohgaki — 2014-01-26T22:31:31+00:00 URL: https://externals.io/message/70779#71608 · In reply to: #71603 > On Mon, Jan 27, 2014 at 5:15 AM, Stas Malyshev wrote: > > > […] > > > The patch is not causing segfaults. > > Zend engine is segfaulting for zend_multibyte tests. > It's a separate issue. You'll see segfaults in 5.4 and up without > my patch. > > I've merged zend_multibyte tests fixes already. That's the reason why you > see failing tests on 5.4 and up. > > It's a different issue and if nobody is willing to fix. I'll fix > zend_multibyte > next month. > For the record, I committed this patch to 5.4 and up. As you can see, the patch is simply re-enabled tests for 5.4 and up. (Note: there is no mbstring.script_encoding INI for 5.4 and up. It's removed.) The segfaults of zend engine are irrelevant for this proposal. commit e769c96a1102f33e5783c35b7a7eedf5d81be7b9 Author: Yasuo Ohgaki Date: Sun Jan 19 13:28:48 2014 +0900 Enable zend.multibyte tests. Tipcal configuration works, but most tests fail. diff --git a/ext/mbstring/tests/zend_multibyte-01.phpt b/ext/mbstring/tests/zend_multibyte-01.phpt index d96e0f0..f2403ab 100644 --- a/ext/mbstring/tests/zend_multibyte-01.phpt +++ b/ext/mbstring/tests/zend_multibyte-01.phpt @@ -1,14 +1,9 @@ --TEST-- zend multibyte (1) --SKIPIF-- - --INI-- -mbstring.script_encoding=Shift_JIS +zend.multibyte=On +zend.script_encoding=Shift_JIS mbstring.internal_encoding=Shift_JIS --FILE-- wrote: > > […] > > No, I don't see segfaults on Travis tests without your patch, but I do > see it with your patch. Which tests are segfaulting without your patch > for you? This needs to be fixed ASAP, segfaults in core code is not a > good thing. Hmm, then it's my issue. I'll check it ASAP. Thank you. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --- ## #71610 — Stas Malyshev — 2014-01-26T22:35:49+00:00 URL: https://externals.io/message/70779#71610 · In reply to: #71608 Hi! > For the record, I committed this patch to 5.4 and up. You seem to be talking about different patch. The patch I am talking about is https://github.com/php/php-src/pull/568, it was not committed anywhere (and definitely not in 5.4 as it is targeted to be in 5.6) and Travis shows segfaults on it (see https://travis-ci.org/php/php-src/builds/17247814) which are not it regular master Travis tests. > The segfaults of zend engine are irrelevant for this proposal. I disagree, segfaults caused by the patch are very relevant. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 --- ## #71611 — Yasuo Ohgaki — 2014-01-26T22:42:39+00:00 URL: https://externals.io/message/70779#71611 · In reply to: #71610 Hi Stas, On Mon, Jan 27, 2014 at 7:35 AM, Stas Malyshev wrote: > > […] > > You seem to be talking about different patch. The patch I am talking > about is https://github.com/php/php-src/pull/568, it was not committed > anywhere (and definitely not in 5.4 as it is targeted to be in 5.6) and > Travis shows segfaults on it (see > https://travis-ci.org/php/php-src/builds/17247814) which are not it > regular master Travis tests. > > > […] > > I disagree, segfaults caused by the patch are very relevant. I fetched and merged changes from original php-src into my fork. I shouldn't have done that :( I'm guessing that's the reason why we see failed tests. Finding out what's wrong now. Just a moment. It takes time for rebuild and full tests. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --- ## #71613 — Yasuo Ohgaki — 2014-01-26T22:52:10+00:00 URL: https://externals.io/message/70779#71613 · In reply to: #71611 Hi Stas, > On Mon, Jan 27, 2014 at 7:35 AM, Stas Malyshev wrote: > > > […] > > > I fetched and merged changes from original php-src into my fork. > I shouldn't have done that :( > > I'm guessing that's the reason why we see failed tests. > Finding out what's wrong now. Just a moment. > It takes time for rebuild and full tests. > I'm running several rebuild and full tests now. It will take a while. If there is problem, I'll fix them in this pull request. Anyway, sorry for the confusion. For the time being, we may mark zend_multibyte tests as XFAIL. I'll make time to fix them later. What do you think? Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --- Next page: https://externals.io/message/70779.md?page=2