# Review requested: use-function patch

- Thread: https://externals.io/message/70068
- Original archive: https://news-web.php.net/php.internals/70068
- Started by Igor Wiedler on 2013-11-09T19:08:59+00:00
- Messages: 6
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #70068 — Igor Wiedler — 2013-11-09T19:08:59+00:00

URL: https://externals.io/message/70068#70068

Hello internals,

It’s been a while since the use-function RFC was accepted (reminder: https://wiki.php.net/rfc/use_function). The last few edge case bugs that had come up have now been fixed. As far as I’m concerned, the patch is complete.

It would be great to get some more review to ensure there are no issues in the implementation. And once that’s done, it can be merged.

The patch is at: https://github.com/php/php-src/pull/526

Thanks,

Igor

---

## #70111 — Igor Wiedler — 2013-11-14T13:11:45+00:00

URL: https://externals.io/message/70068#70111 · In reply to: #70068

Hi,

Just bumping this thread, since it didn’t receive any attention at all.

Thanks,

Igor



> Hello internals,
> 
> It’s been a while since the use-function RFC was accepted (reminder: https://wiki.php.net/rfc/use_function). The last few edge case bugs that had come up have now been fixed. As far as I’m concerned, the patch is complete.
> 
> It would be great to get some more review to ensure there are no issues in the implementation. And once that’s done, it can be merged.
> 
> The patch is at: https://github.com/php/php-src/pull/526
> 
> Thanks,
> 
> Igor

---

## #70114 — Michael Wallner — 2013-11-14T14:42:40+00:00

URL: https://externals.io/message/70068#70114 · In reply to: #70111

> Hi,
>
> Just bumping this thread, since it didn’t receive any attention at all.

Sorry!
Igor, did you fully merge my fixes branch yet?



-- 
Regards,
Mike

---

## #70115 — Michael Wallner — 2013-11-14T14:45:23+00:00

URL: https://externals.io/message/70068#70115 · In reply to: #70114

> 
> > […]
>
> Sorry!
> Igor, did you fully merge my fixes branch yet?

There's a fix for which I obviously did not create a PR:
https://github.com/m6w6/php-src/compare/igorw:use-function...use-function


-- 
Regards,
Mike

---

## #70116 — Igor Wiedler — 2013-11-14T15:15:26+00:00

URL: https://externals.io/message/70068#70116 · In reply to: #70115

> 
> > […]
> 
> There's a fix for which I obviously did not create a PR:
> https://github.com/m6w6/php-src/compare/igorw:use-function...use-function

I missed that patch. But it looks like Adam did an alternate fix:

* https://github.com/igorw/php-src/commit/9711c58bc4236c0e2e482af9b20581e78af0c7ca

If that is not sufficient, can you please send an updated pull request against the current branch?

Thanks!

Igor

---

## #70150 — Michael Wallner — 2013-11-15T06:59:25+00:00

URL: https://externals.io/message/70068#70150

> https://github.com/igorw/php-src/
commit/9711c58bc4236c0e2e482af9b20581e78af0c7ca
> 
> If that is not sufficient, can you please send an updated pull request
> against the current branch?

It is sufficient but comes with an extra alloc/free.