# phar bug #65028 - Thread: https://externals.io/message/68276 - Original archive: https://news-web.php.net/php.internals/68276 - Started by Stas Malyshev on 2013-07-22T08:09:44+00:00 - Messages: 7 - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #68276 — Stas Malyshev — 2013-07-22T08:09:44+00:00 URL: https://externals.io/message/68276#68276 Hi! I was looking at bug https://bugs.php.net/bug.php?id=65028 and looks like it happens because phar writes manifest after HALT_COMPILER(); ?> and first 4 bytes of manifest are manifest length (little-endian), but when it read the header, it checks if there's \r\n after ?>. So if length has lowest byte 0x0d or 0x0a, bad things happen. I've created https://github.com/php/php-src/pull/392 to fix this problem, however I'd like somebody with more familiarity with phar details to take a look if it's the best way to do it. P.S.: BTW, who is official phar maintainer now? I'm seeing that last commit from anybody listed as maintainer is 4 years ago... Is it time to update ownership? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 --- ## #68299 — Ferenc Kovacs — 2013-07-24T16:21:02+00:00 URL: https://externals.io/message/68276#68299 · In reply to: #68276 hi we don't have a maintainer for phar as far as I know. Ralph volunteered(twice) to take over phar but was pretty much ignored. He is the last person that I know looking into the phar code and fixing stuff so maybe he could review your changes. On Mon, Jul 22, 2013 at 10:09 AM, Stas Malyshev wrote: > Hi! > > I was looking at bug https://bugs.php.net/bug.php?id=65028 and looks > like it happens because phar writes manifest after HALT_COMPILER(); ?> > and first 4 bytes of manifest are manifest length (little-endian), but > when it read the header, it checks if there's \r\n after ?>. So if > length has lowest byte 0x0d or 0x0a, bad things happen. > > I've created https://github.com/php/php-src/pull/392 to fix this > problem, however I'd like somebody with more familiarity with phar > details to take a look if it's the best way to do it. > > P.S.: BTW, who is official phar maintainer now? I'm seeing that last > commit from anybody listed as maintainer is 4 years ago... Is it time to > update ownership? > -- > Stanislav Malyshev, Software Architect > SugarCRM: http://www.sugarcrm.com/ > (408)454-6900 ext. 227 > > -- > > > > -- Ferenc Kovács @Tyr43l - http://tyrael.hu --- ## #68300 — Sebastian Bergmann — 2013-07-24T16:24:01+00:00 URL: https://externals.io/message/68276#68300 · In reply to: #68276 Am 22.07.2013 10:09, schrieb Stas Malyshev: > P.S.: BTW, who is official phar maintainer now? I'm seeing that last > commit from anybody listed as maintainer is 4 years ago... Is it time > to update ownership? As Ferenc pointed out, Ralph volunteered for it. PHAR is too vital a part of PHP, IMHO, to be without a maintainer. -- Sebastian Bergmann Co-Founder and Principal Consultant http://sebastian-bergmann.de/ http://thePHP.cc/ --- ## #68301 — Stas Malyshev — 2013-07-24T16:46:19+00:00 URL: https://externals.io/message/68276#68301 · In reply to: #68300 Hi! > As Ferenc pointed out, Ralph volunteered for it. PHAR is too vital a > part of PHP, IMHO, to be without a maintainer. Well, if he's still up to it I think we should list him as a maintainer. Ralph? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 --- ## #68356 — Michael Wallner — 2013-08-02T06:12:08+00:00 URL: https://externals.io/message/68276#68356 · In reply to: #68301 > Hi! > > > […] > > Well, if he's still up to it I think we should list him as a maintainer. > Ralph? So are we finally ready to give karma?! Ralph are you ready? :) -- Regards, Mike --- ## #68366 — Ralph Schindler — 2013-08-04T20:46:05+00:00 URL: https://externals.io/message/68276#68366 · In reply to: #68301 > Well, if he's still up to it I think we should list him as a maintainer. > Ralph? Yes, I am ready to get back on this horse. Stas, I will address your questions on my original PR this week, perhaps we can get it to a place where you can close it out. -ralph --- ## #68498 — Rajneesh Shetty — 2013-08-12T18:02:07+00:00 URL: https://externals.io/message/68276#68498 Hello Ralph! I am a new subscriber to the PHP list & am not sure of the details of the bug you mention #65028... Was this post Microsoft SQL integration or prior to it? Regards, Rajneesh http://my.opera.com/shettyrn/about/ Rajneesh N. Shetty Tel : (+61)468371858 ________________________________________ From: Ralph Schindler [ralph@ralphschindler.com] Sent: Monday, 5 August 2013 6:46 AM To: internals@lists.php.net Subject: Re: [PHP-DEV] phar bug #65028 > Well, if he's still up to it I think we should list him as a maintainer. > Ralph? Yes, I am ready to get back on this horse. Stas, I will address your questions on my original PR this week, perhaps we can get it to a place where you can close it out. -ralph