# Who's incharge of github pull requests?

- Thread: https://externals.io/message/67709
- Original archive: https://news-web.php.net/php.internals/67709
- Started by Lior Kaplan on 2013-06-16T14:02:46+00:00
- Messages: 4
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #67709 — Lior Kaplan — 2013-06-16T14:02:46+00:00

URL: https://externals.io/message/67709#67709

Hi,

It seems the list of pull requests on github is getting bigger, who's
inchange to review it?
https://github.com/php/php-src/pulls

I must say that my experience so far in trying to push patches through the
bug system
or pull request is quite deprsing (comparing to other open source projects):
https://liorkaplan.wordpress.com/2013/06/05/getting-patches-into-php/

Kaplan

---

## #67873 — Felipe Pena — 2013-06-26T14:28:19+00:00

URL: https://externals.io/message/67709#67873 · In reply to: #67709

Hi,

I saw some patches from you (mentioned in the blog post) has been pushed to git.

About the FTP patch, as it requires further testing and an environment
for such, and we do not have an active maintainer currently for the
extension. It tend to have a delay until anyone with free time (most
of we are volunteers), and cares about testing the patch for such
extension, to get it applied.

Thanks for contributing!


2013/6/16 Lior Kaplan <lior.k@zend.com>:
> Hi,
>
> It seems the list of pull requests on github is getting bigger, who's
> inchange to review it?
> https://github.com/php/php-src/pulls
>
> I must say that my experience so far in trying to push patches through the
> bug system
> or pull request is quite deprsing (comparing to other open source projects):
> https://liorkaplan.wordpress.com/2013/06/05/getting-patches-into-php/
>
> Kaplan



-- 
Regards,
Felipe Pena

---

## #67882 — Lior Kaplan — 2013-06-26T15:23:35+00:00

URL: https://externals.io/message/67709#67882 · In reply to: #67873

Hi Felipe,

Indeed I saw more responsiveness for the pull requests (mine and others),
thanks.

The question was about the process of reviewing these requests.
1. Do we have someone in charge (making sure they pass some minimum
requirements) or this is done sporadically ?
2. If we do it sporadically, how do we make sure things aren't lost or get
stuck (causing us to lose good patches).

Yes, most of us are volunteers (both the developers and the patch senders)
and this reflects on time issues. With that said, both sides have interest
of seeing more patches sent and accepted.

As I have experience with this on other projects, I'm trying to help
improve the status here. Of course, I'm willing to personally help here, so
I'm not just asking you guys to handle this yourselves.

Kaplan



> Hi,
>
> I saw some patches from you (mentioned in the blog post) has been pushed
> to git.
>
> About the FTP patch, as it requires further testing and an environment
> for such, and we do not have an active maintainer currently for the
> extension. It tend to have a delay until anyone with free time (most
> of we are volunteers), and cares about testing the patch for such
> extension, to get it applied.
>
> Thanks for contributing!
>
>
> 2013/6/16 Lior Kaplan <lior.k@zend.com>:
> > […]
> the
> > […]
> projects):
> > […]
>
>
>
> --
> Regards,
> Felipe Pena

---

## #67912 — Felipe Pena — 2013-06-26T23:02:00+00:00

URL: https://externals.io/message/67709#67912 · In reply to: #67882

2013/6/26 Lior Kaplan <lior.k@zend.com>:
> Hi Felipe,
>
> Indeed I saw more responsiveness for the pull requests (mine and others),
> thanks.
>
> The question was about the process of reviewing these requests.
> 1. Do we have someone in charge (making sure they pass some minimum
> requirements) or this is done sporadically ?

There are some core devs looking and triaging pull requests, but
nobody is officially in charge to. Everyone with the needed karma can
to do it.

> 2. If we do it sporadically, how do we make sure things aren't lost or get
> stuck (causing us to lose good patches).
>
> Yes, most of us are volunteers (both the developers and the patch senders)
> and this reflects on time issues. With that said, both sides have interest
> of seeing more patches sent and accepted.
>
> As I have experience with this on other projects, I'm trying to help improve
> the status here. Of course, I'm willing to personally help here, so I'm not
> just asking you guys to handle this yourselves.
>
> Kaplan
>
>

Cool, so ask for a git account and join us! http://www.php.net/git-php.php


> 
> > […]
>
>



--
Regards,
Felipe Pena