# If you want to avoid annoying CS commits - Thread: https://externals.io/message/674 - Original archive: https://news-web.php.net/php.internals/674 - Started by Sterling Hughes on 2003-04-04T16:09:19+00:00 - Messages: 10 - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #674 — Sterling Hughes — 2003-04-04T16:09:19+00:00 URL: https://externals.io/message/674#674 Howdy, Due to recent discussions, I have an idea for avoiding the whole mess of annoying coding standards commits that Jani and Derick constantly make. Follow the coding standards! Geeze Luise, its not that hard, and the coding standards are there for a (good) reason. If you object to some of the standards, discuss that, but the source code should follow a unified style: we have agreed to this a long time ago. Don't yell at Jani and Derick when you screw up; and if you really can't stand it, move your extension to PECL. -Sterling -- "The computer programmer is a creator of universes for which he alone is responsible. Universes of virtually unlimited complexity can be created in the form of computer programs." - Joseph Weizenbaum --- ## #680 — Sterling Hughes — 2003-04-04T16:44:44+00:00 URL: https://externals.io/message/674#680 · In reply to: #678 > Sterling, you are missing some important points here. > > > […] > > If you look at my code, 99% of it follows the coding styles, > because I've adopted the PHP style as my personal one. > > The commit I recently backed out related mostly to Zeev's > "terse" style. While I'm not particular fond of it, there is > also no reason why it absolutely has to be realigned. > > I barked at Derick for trying to police me with his docref > pet stuff. I just noticed that someone has committed that to > CODING_STANDARDS, although there has never been a consensus > regarding its introduction. As such, I consider it to be > void. > Ahh, well, you should follow the coding standards regardless, or rather change them. I've just removed docref and assert bogusness from the files, so, in that case, you are no longer in violation. (you should throw a party. ;-) What I was objecting to was less contraversial, long term coding standards, for example: if (foo) bar = 1; instead of : if (foo) { bar = 1; } Its really quite simple to follow, and if you want to avoid annoying CS commits, just follow the standards. -Sterling -- "The three most dangerous things in the world are a programmer with a soldering iron, a hardware type with a program patch and a user with an idea." - Unknown --- ## #675 — Lukas Smith — 2003-04-04T16:45:15+00:00 URL: https://externals.io/message/674#675 · In reply to: #674 > From: Sterling Hughes [mailto:sterling@bumblebury.com] > Sent: Friday, April 04, 2003 6:09 PM > Geeze Luise, its not that hard, and the coding standards are there for a > (good) reason. If you object to some of the standards, discuss that, > but the source code should follow a unified style: we have agreed to > this a long time ago. Don't yell at Jani and Derick when you screw up; > and if you really can't stand it, move your extension to PECL. Even in PECL you have to follow the php coding standards. Regards, Lukas --- ## #678 — Sascha Schumann — 2003-04-04T16:54:02+00:00 URL: https://externals.io/message/674#678 · In reply to: #674 Sterling, you are missing some important points here. > Geeze Luise, its not that hard, and the coding standards are there for a > (good) reason. If you object to some of the standards, discuss that, If you look at my code, 99% of it follows the coding styles, because I've adopted the PHP style as my personal one. The commit I recently backed out related mostly to Zeev's "terse" style. While I'm not particular fond of it, there is also no reason why it absolutely has to be realigned. I barked at Derick for trying to police me with his docref pet stuff. I just noticed that someone has committed that to CODING_STANDARDS, although there has never been a consensus regarding its introduction. As such, I consider it to be void. - Sascha --- ## #684 — Derick Rethans — 2003-04-04T17:12:07+00:00 URL: https://externals.io/message/674#684 · In reply to: #678 > I barked at Derick for trying to police me with his docref > pet stuff. 1. It's not my stuff 2. I'm not particulairy fond of it either, but that doesn't mean I don't use it in my code for the PHP project.You may object or not, but if it's generally adopted you should too. It's not playing police here, it's just common sense between the developers of a big project like PHP. Personal opinions are not always the ones that should be followed. Derick -- "my other box is your windows PC" ------------------------------------------------------------------------- Derick Rethans http://derickrethans.nl/ PHP Magazine - PHP Magazine for Professionals http://php-mag.net/ --- ## #687 — Sascha Schumann — 2003-04-04T17:16:46+00:00 URL: https://externals.io/message/674#687 · In reply to: #684 Derick, your attempts at setting rules are misguided. - Sascha --- ## #693 — Derick Rethans — 2003-04-04T17:45:03+00:00 URL: https://externals.io/message/674#693 · In reply to: #687 > Derick, your attempts at setting rules are misguided. I'm not setting any rules, I'm just trying to push ways of effective collaboration due to the adoption of the same standards for everbody. Derick -- "my other box is your windows PC" ------------------------------------------------------------------------- Derick Rethans http://derickrethans.nl/ PHP Magazine - PHP Magazine for Professionals http://php-mag.net/ --- ## #694 — Sascha Schumann — 2003-04-04T17:50:05+00:00 URL: https://externals.io/message/674#694 · In reply to: #693 > I'm not setting any rules, I'm just trying to push ways of effective > collaboration due to the adoption of the same standards for everbody. You are in no position to push anything. Try 'encouraging' or 'convincing' the next time. - Sascha --- ## #698 — Derick Rethans — 2003-04-04T18:27:25+00:00 URL: https://externals.io/message/674#698 · In reply to: #694 > > […] > > You are in no position to push anything. > > Try 'encouraging' or 'convincing' the next time. The difference between 'pushing' and 'encouraging' is tought in management school. The semantical difference is NULL. Derick -- "my other box is your windows PC" ------------------------------------------------------------------------- Derick Rethans http://derickrethans.nl/ PHP Magazine - PHP Magazine for Professionals http://php-mag.net/ --- ## #699 — Sascha Schumann — 2003-04-04T18:35:37+00:00 URL: https://externals.io/message/674#699 · In reply to: #698 > The difference between 'pushing' and 'encouraging' is tought in > management school. The semantical difference is NULL. Derick, you need to realize that you lack authority. Someone without authority cannot push anything what so ever. Or to put it differently: A bully pushes. A peer encourages. - Sascha