# re2c --no-generation-date

- Thread: https://externals.io/message/64142
- Original archive: https://news-web.php.net/php.internals/64142
- Started by Sebastian Bergmann on 2012-12-04T08:21:14+00:00
- Messages: 5
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #64142 — Sebastian Bergmann — 2012-12-04T08:21:14+00:00

URL: https://externals.io/message/64142#64142

Any objections to applying the attached patch? This would suppress date
 output in the generated output so that (hopefully) files generated by
 re2c are not changed during the build just because of the date.

---

## #64153 — Stas Malyshev — 2012-12-05T05:06:33+00:00

URL: https://externals.io/message/64142#64153 · In reply to: #64142

Hi!

>  Any objections to applying the attached patch? This would suppress date
>  output in the generated output so that (hopefully) files generated by
>  re2c are not changed during the build just because of the date.

I think it is a great idea. If we ever need a date for checked in files,
we have it on git commit, date in the text is not useful anyway.
-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

---

## #64154 — Sebastian Bergmann — 2012-12-05T07:06:51+00:00

URL: https://externals.io/message/64142#64154 · In reply to: #64153

> > […]
> 
> I think it is a great idea. If we ever need a date for checked in files,
> we have it on git commit, date in the text is not useful anyway.

 Okay. But does the patch look okay? Is it sufficient? How can I force a
 rebuild of all files generated through re2c to remove the date from the
 files? To which branches should the patch be applied? Thanks!

---

## #64170 — Stas Malyshev — 2012-12-06T07:58:21+00:00

URL: https://externals.io/message/64142#64170 · In reply to: #64154

Hi!

>  Okay. But does the patch look okay? Is it sufficient? How can I force a
>  rebuild of all files generated through re2c to remove the date from the
>  files? To which branches should the patch be applied? Thanks!

I think 5.5, since we're not touching 5.4 that much anymore, especially
not in the parser department.
I'm not sure how to force rebuild of all files except for manually doing
it, though.
-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

---

## #64171 — Sebastian Bergmann — 2012-12-06T08:33:07+00:00

URL: https://externals.io/message/64142#64171 · In reply to: #64170

Am 06.12.2012 08:58, schrieb Stas Malyshev:
> I think 5.5, since we're not touching 5.4 that much anymore, especially
> not in the parser department.

 I committed the patch to PHP-5.5 and merged it to master from there.

-- 
Sebastian Bergmann                    Co-Founder and Principal Consultant
http://sebastian-bergmann.de/                           http://thePHP.cc/