# [RFC] Property Accessors v1.2 Consensus Changes

- Thread: https://externals.io/message/63963
- Original archive: https://news-web.php.net/php.internals/63963
- Started by Clint Priest on 2012-11-19T00:19:31+00:00
- Messages: 3
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #63963 — Clint Priest — 2012-11-19T00:19:31+00:00

URL: https://externals.io/message/63963#63963

Can anyone who has an interest in this project please review over the 
"Current Consensus Changes" section of this document:

https://wiki.php.net/rfc/propertygetsetsyntax-as-implemented/change-requests

Lets hear if there are any other concerns, otherwise in the next couple 
of days I will integrate these changes into the main RFC document and 
begin work on the changes from 1.1 -> 1.2.

Still left open (undecided) is internal accessor method visibility and 
callability.  Primarily this is between Stas and Nikita, I prefer not 
visible (makes more sense to me) but callable (less difficult to 
implement, simpler for the code).  I would appreciate some more input on 
this topic from anyone interested.

How long is it before 5.5 is in feature-freeze?  I'm guessing at this 
point that this will not make the 5.5 release, but depends on the powers 
that be.

-Clint

-- 
-Clint

---

## #63964 — Levi Morrison — 2012-11-19T01:24:05+00:00

URL: https://externals.io/message/63963#63964 · In reply to: #63963

> Can anyone who has an interest in this project please review over the
> "Current Consensus Changes" section of this document:
>
> https://wiki.php.net/rfc/propertygetsetsyntax-as-implemented/change-requests
>
> Lets hear if there are any other concerns, otherwise in the next couple of
> days I will integrate these changes into the main RFC document and begin
> work on the changes from 1.1 -> 1.2.
>
> Still left open (undecided) is internal accessor method visibility and
> callability.  Primarily this is between Stas and Nikita, I prefer not
> visible (makes more sense to me) but callable (less difficult to implement,
> simpler for the code).  I would appreciate some more input on this topic
> from anyone interested.
>
> How long is it before 5.5 is in feature-freeze?  I'm guessing at this point
> that this will not make the 5.5 release, but depends on the powers that be.
>
> -Clint

I'm sad to see the short-hand notation dropped. Other than that, it
looks decent. I support accessors shadowing properties.

---

## #63974 — Nikita Popov — 2012-11-19T15:36:35+00:00

URL: https://externals.io/message/63963#63974 · In reply to: #63963

> Can anyone who has an interest in this project please review over the
> "Current Consensus Changes" section of this document:
>
> https://wiki.php.net/rfc/**propertygetsetsyntax-as-**
> implemented/change-requests<https://wiki.php.net/rfc/propertygetsetsyntax-as-implemented/change-requests>
>
> Lets hear if there are any other concerns, otherwise in the next couple of
> days I will integrate these changes into the main RFC document and begin
> work on the changes from 1.1 -> 1.2.
>
> Still left open (undecided) is internal accessor method visibility and
> callability.  Primarily this is between Stas and Nikita, I prefer not
> visible (makes more sense to me) but callable (less difficult to implement,
> simpler for the code).  I would appreciate some more input on this topic
> from anyone interested.
>
> How long is it before 5.5 is in feature-freeze?  I'm guessing at this
> point that this will not make the 5.5 release, but depends on the powers
> that be.
>
> -Clint
>

The changes look good to me. Two notes:

1. The "internal accessor method visibility and callability" point should
really be "should accessors be implemented as magic methods?" Might help to
clarify what the discussion was actually about.

2. I never really meant the "DateTime $date;" syntax as just a shorthand
notation for the automatic setter with typehint. Rather it was meant as an
alternative way to do the typehinting in the first place. I.e. instead of
public $date { set(DateTime $date) {} } you would do public DateTime $date
{ set($date) { } } (like in C# for example). I would have preferred this
way (mainly because it allows to typehint even without specifying
accessors), but I can also live without it ^^

Thanks for your work on this,
Nikita