# Merging fix for quoted_printable_encode() - Thread: https://externals.io/message/62288 - Original archive: https://news-web.php.net/php.internals/62288 - Started by Lars Strojny on 2012-08-20T15:25:09+00:00 - Messages: 4 - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #62288 — Lars Strojny — 2012-08-20T15:25:09+00:00 URL: https://externals.io/message/62288#62288 Hi everybody, I would like to merge https://github.com/php/php-src/pull/120 in HEAD, 5_4 and 5_3 to fix splitting of soft line breaks. Any concerns? With regards, Lars --- ## #62302 — Stas Malyshev — 2012-08-20T18:30:33+00:00 URL: https://externals.io/message/62288#62302 · In reply to: #62288 Hi! > Hi everybody, > > I would like to merge https://github.com/php/php-src/pull/120 in HEAD, 5_4 and 5_3 to fix splitting of soft line breaks. Any concerns? Yes. For 5.3, it does not look like a critical bug, so it shouldn't be there. Also, the tests are still not there - so they should be added before the merge can happen. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 --- ## #62308 — Lars Strojny — 2012-08-20T20:03:59+00:00 URL: https://externals.io/message/62288#62308 · In reply to: #62302 Hi Stas, I would prefer it int 5.3 as well as it might break mailing systems using `quoted_printable_encode()`. I’ll add the test from the comments as well. Am 20.08.2012 um 20:30 schrieb Stas Malyshev : > Yes. For 5.3, it does not look like a critical bug, so it shouldn't be > there. Also, the tests are still not there - so they should be added > before the merge can happen. --- ## #62317 — Lars Strojny — 2012-08-20T21:57:23+00:00 URL: https://externals.io/message/62288#62317 · In reply to: #62308 Hi everybody, patch + test merged to master and 5.4. I would really like to merge it to 5.3 as well but if others disagree I could live without it. With regards, Lars Am 20.08.2012 um 22:03 schrieb Lars Strojny : > Hi Stas, > > I would prefer it int 5.3 as well as it might break mailing systems using `quoted_printable_encode()`. I’ll add the test from the comments as well. > > Am 20.08.2012 um 20:30 schrieb Stas Malyshev : > > > […]