# #61421 for 5.3/4

- Thread: https://externals.io/message/60974
- Original archive: https://news-web.php.net/php.internals/60974
- Started by Pierre Joye on 2012-06-27T06:20:12+00:00
- Messages: 4
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · RFCs at https://externals.io/rfc.md · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #60974 — Pierre Joye — 2012-06-27T06:20:12+00:00

URL: https://externals.io/message/60974#60974

hi,

I would like to merge the patch from #61421 to all active branches (RMs as CC).

It is not a new function nor does it add new features but new
constants to support more algorithms for the signature verification.

Is it ok?

Cheers,
-- 
Pierre

---

## #60975 — Stas Malyshev — 2012-06-27T06:44:53+00:00

URL: https://externals.io/message/60974#60975 · In reply to: #60974

Hi!

> I would like to merge the patch from #61421 to all active branches (RMs as CC).
> 
> It is not a new function nor does it add new features but new
> constants to support more algorithms for the signature verification.

Don't see any problem with it.

-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

---

## #60976 — johannes@schlueters.de — 2012-06-27T09:18:11+00:00

URL: https://externals.io/message/60974#60976 · In reply to: #60975

> Hi!
> 
> > […]
> 
> Don't see any problem with it.

It's a feature .. but acceptable -)

johannes

---

## #60978 — Pierre Joye — 2012-06-27T09:23:38+00:00

URL: https://externals.io/message/60974#60978 · In reply to: #60976

On Wed, Jun 27, 2012 at 11:18 AM, Johannes Schlüter
<johannes@schlueters.de> wrote:
> 
> > […]
>
> It's a feature .. but acceptable -)

Not per se, a grey area where only adding constants could be fine.
Anything else or more complicated is not. But why I ask :)

Waiting David's reply and then I will merge it.

Cheers,
-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org