# fix for 61418 breaks win32 build

- Thread: https://externals.io/message/59130
- Original archive: https://news-web.php.net/php.internals/59130
- Started by Stas Malyshev on 2012-03-23T05:26:22+00:00
- Messages: 3
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #59130 — Stas Malyshev — 2012-03-23T05:26:22+00:00

URL: https://externals.io/message/59130#59130

Hi!

Commit 714f1ff4b37c5101b3c61ea108a3d415f41e50df is breaking win32 build
and causing bug #61482. I am reverting this commit. Gustavo, please
check the code and see if you can improve the fix so it does not break
win32. The reproduction details are in the bug 61482.
-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

---

## #59133 — Gustavo Lopes — 2012-03-23T09:37:26+00:00

URL: https://externals.io/message/59130#59133 · In reply to: #59130

On Fri, 23 Mar 2012 06:26:22 +0100, Stas Malyshev <smalyshev@sugarcrm.com>  
wrote:

> Commit 714f1ff4b37c5101b3c61ea108a3d415f41e50df is breaking win32 build
> and causing bug #61482. I am reverting this commit. Gustavo, please
> check the code and see if you can improve the fix so it does not break
> win32. The reproduction details are in the bug 61482.

Actually, Dmitry and I were discussing this issue yesterday on IRC (check  
your logs). He too detected the problem and had reverted the fix for bug  
#61418.

The fix for bug #61482 may be simple and I will both reinstate my fix for  
bug #61418 and correct it, but I'll only be able to test it more  
thoroughly during the weekend.

-- 
Gustavo Lopes

---

## #59142 — Stas Malyshev — 2012-03-23T17:14:53+00:00

URL: https://externals.io/message/59130#59142 · In reply to: #59133

Hi!

> Actually, Dmitry and I were discussing this issue yesterday on IRC (check  
> your logs). He too detected the problem and had reverted the fix for bug  
> #61418.

Sorry, I don't watch IRC lately.

> The fix for bug #61482 may be simple and I will both reinstate my fix for  
> bug #61418 and correct it, but I'll only be able to test it more  
> thoroughly during the weekend.

OK, I'll see if my windows test machine works fine with that fix in the
evening.
-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227