# merging test improvement to PHP_5_4

- Thread: https://externals.io/message/57427
- Original archive: https://news-web.php.net/php.internals/57427
- Started by Ferenc Kovacs on 2012-01-19T19:07:49+00:00
- Messages: 5
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #57427 — Ferenc Kovacs — 2012-01-19T19:07:49+00:00

URL: https://externals.io/message/57427#57427

Hi,

I fixed https://bugs.php.net/bug.php?id=52078, I would like to add the test
improvement to the 5.4 branch also, is it ok to commit, or should I wait
the release with it?

see http://svn.php.net/viewvc?view=revision&revision=322460

-- 
Ferenc Kovács
@Tyr43l - http://tyrael.hu

---

## #57428 — Rafael Kassner — 2012-01-19T19:12:11+00:00

URL: https://externals.io/message/57427#57428 · In reply to: #57427

I guess 5.4 branch is under code freeze.

http://marc.info/?l=php-internals&m=132617955007428&w=2



> Hi,
>
> I fixed https://bugs.php.net/bug.php?id=52078, I would like to add the
> test
> improvement to the 5.4 branch also, is it ok to commit, or should I wait
> the release with it?
>
> see http://svn.php.net/viewvc?view=revision&revision=322460
>
> --
> Ferenc Kovács
> @Tyr43l - http://tyrael.hu
>



-- 
Atenciosamente,
Rafael Kassner

---

## #57429 — Ferenc Kovacs — 2012-01-19T19:23:32+00:00

URL: https://externals.io/message/57427#57429 · In reply to: #57428

And this is why I asked it.

"The following may be considered for inclusion:
- Unit tests & test fixes
..

Please still ask RMs for approval prior to committing even if your patch
falls into these categories."



> I guess 5.4 branch is under code freeze.
>
> http://marc.info/?l=php-internals&m=132617955007428&w=2
>
>
> 
>
> > […]
>
>
>
> --
> Atenciosamente,
> Rafael Kassner
>
>


-- 
Ferenc Kovács
@Tyr43l - http://tyrael.hu

---

## #57431 — Stas Malyshev — 2012-01-19T19:30:48+00:00

URL: https://externals.io/message/57427#57431 · In reply to: #57427

Hi!

> I fixed https://bugs.php.net/bug.php?id=52078, I would like to add the test
> improvement to the 5.4 branch also, is it ok to commit, or should I wait
> the release with it?

Please hold it, we are announcing RC6 soon and plan to release in 2 
weeks, in this period I'd like to keep the SVN as stable as possible.
-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

---

## #57434 — Ferenc Kovacs — 2012-01-19T21:35:49+00:00

URL: https://externals.io/message/57427#57434 · In reply to: #57431

On Thu, Jan 19, 2012 at 8:30 PM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:

> Hi!
>
>
>  I fixed https://bugs.php.net/bug.php?**id=52078<https://bugs.php.net/bug.php?id=52078>,
> > […]
>
> Please hold it, we are announcing RC6 soon and plan to release in 2 weeks,
> in this period I'd like to keep the SVN as stable as possible.
>
>
ok

-- 
Ferenc Kovács
@Tyr43l - http://tyrael.hu