# commit rights for ext/pdo folder

- Thread: https://externals.io/message/57161
- Original archive: https://news-web.php.net/php.internals/57161
- Started by marius adrian popa on 2011-12-31T10:56:47+00:00
- Messages: 2
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #57161 — marius adrian popa — 2011-12-31T10:56:47+00:00

URL: https://externals.io/message/57161#57161

There are some tests that needs to be skiped for firebird driver

I have made the changes in test but i can't commit them

added firebird driver case for the test bug 43139
--This line, and those below, will be ignored--

M    php-src/trunk/ext/pdo/tests/bug_43139.phpt
M    php-src/branches/PHP_5_3/ext/pdo/tests/bug_43139.phpt
M    php-src/branches/PHP_5_4/ext/pdo/tests/bug_43139.phpt

svn diff
Index: php-src/trunk/ext/pdo/tests/bug_43139.phpt
===================================================================
--- php-src/trunk/ext/pdo/tests/bug_43139.phpt	(revision 321556)
+++ php-src/trunk/ext/pdo/tests/bug_43139.phpt	(working copy)
@@ -20,6 +20,8 @@
 $from = '';
 if ($db->getAttribute(PDO::ATTR_DRIVER_NAME) == 'oci') {
 	$from = 'from dual';
+} else if ($db->getAttribute(PDO::ATTR_DRIVER_NAME) == 'firebird') {
+	$from = 'FROM RDB$DATABASE';
 }



the related bug with some of the proposed changes (i take one by one
and check if it makes sense to skip some of the patches)

http://bugs.php.net/55663

---

## #57166 — Matteo Beccati — 2012-01-02T11:44:50+00:00

URL: https://externals.io/message/57161#57166 · In reply to: #57161

> There are some tests that needs to be skiped for firebird driver
> 
> I have made the changes in test but i can't commit them

I've committed the fix, although someone else will need to jump in and
grant you karma ;)

Happy holidays!


Cheers
-- 
Matteo Beccati

Development & Consulting - http://www.beccati.com/