# Bug 60596 - With Patch

- Thread: https://externals.io/message/57091
- Original archive: https://news-web.php.net/php.internals/57091
- Started by Anthony Ferrara on 2011-12-24T17:22:25+00:00
- Messages: 2
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #57091 — Anthony Ferrara — 2011-12-24T17:22:25+00:00

URL: https://externals.io/message/57091#57091

Hey all,

I found a superfluous if statement while investigating another issue.
I submitted a bug to clean it up and attached a patch:

https://bugs.php.net/bug.php?id=60596

It's on line 56 of /ext/spl/spl_engine.c :
http://lxr.php.net/xref/PHP_TRUNK/ext/spl/spl_engine.c#56

It's really simple, and would likely be optimized away by the compiler
anyway, but I figured it was worth cleaning up...

Thanks,

Anthony

---

## #57095 — keisial@gmail.com — 2011-12-24T23:01:49+00:00

URL: https://externals.io/message/57091#57095 · In reply to: #57091

> It's really simple, and would likely be optimized away by the compiler
> anyway, but I figured it was worth cleaning up...
Yep, it's straightforward.

I'm not sure if it makes a difference or not.
IS_DOUBLE is between IS_LONG and IS_BOOL so the compiler could be choosing
in the range instead, with the if.