# Patch for Bug #60164 / Phar __HALT_COMPILER() scanning issue

- Thread: https://externals.io/message/56245
- Original archive: https://news-web.php.net/php.internals/56245
- Started by Ralph Schindler on 2011-11-10T19:44:10+00:00
- Messages: 3
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #56245 — Ralph Schindler — 2011-11-10T19:44:10+00:00

URL: https://externals.io/message/56245#56245

Hey all,

I've spent a bunch of time tracking down this issue (which was 
intermittent at best) and have identified the problem and have a patch 
for the solution.

Details here: https://bugs.php.net/bug.php?id=60164

The attached patch is against trunk, PHP_5_4, & PHP_5_3.

Seeing as though I've supplied patches in the past (see release notes), 
that I've spend significant time on understanding the Phar extension, 
and am able to fix issues there now, I'd like to be the one to commit 
this patch if internals is in agreement.

So, how about it?

-ralph

---

## #56247 — Rasmus Lerdorf — 2011-11-10T19:51:58+00:00

URL: https://externals.io/message/56245#56247 · In reply to: #56245

> Hey all,
> 
> I've spent a bunch of time tracking down this issue (which was
> intermittent at best) and have identified the problem and have a patch
> for the solution.
> 
> Details here: https://bugs.php.net/bug.php?id=60164
> 
> The attached patch is against trunk, PHP_5_4, & PHP_5_3.
> 
> Seeing as though I've supplied patches in the past (see release notes),
> that I've spend significant time on understanding the Phar extension,
> and am able to fix issues there now, I'd like to be the one to commit
> this patch if internals is in agreement.
> 
> So, how about it?

Go for it. I assume the patch doesn't break any existing tests?

-Rasmus

---

## #56255 — Ralph Schindler — 2011-11-10T21:57:27+00:00

URL: https://externals.io/message/56245#56255 · In reply to: #56247

All of the existing tests run.

I will make one change as per C. Jones request to use a const for the 
hard coded 1024 window (since it's used twice).

Also, I am unable to run the php-tests.php with the -m (valgrind) on my 
mac, so I'll need to run those on linux before I commit.

In the mean time, I'll request an account.

Thanks!
Ralph


> 
> > […]
>
> Go for it. I assume the patch doesn't break any existing tests?
>
> -Rasmus