# unsolved issues

- Thread: https://externals.io/message/56128
- Original archive: https://news-web.php.net/php.internals/56128
- Started by Pierre Joye on 2011-11-07T18:41:42+00:00
- Messages: 3
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #56128 — Pierre Joye — 2011-11-07T18:41:42+00:00

URL: https://externals.io/message/56128#56128

Is_a has a patch attached to the bug. Tests pass etc.

---

## #56139 — Stas Malyshev — 2011-11-08T04:42:30+00:00

URL: https://externals.io/message/56128#56139 · In reply to: #56128

Hi!

> Is_a has a patch attached to the bug. Tests pass etc.

I'm looking at bug 55475, there are two patches there:

is_a_5.4_alternative and final_patch_for_5_4_and_HEAD. Which one do you 
mean?

The latter has:

-	if (zend_lookup_class_ex(class_name, class_name_len, NULL, 0, &ce 
TSRMLS_CC) == FAILURE) {
+	if (zend_lookup_class_ex(class_name, class_name_len, NULL, &ce 
TSRMLS_CC) == FAILURE) {

which can't be right.

-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

---

## #56151 — Alan Knowles — 2011-11-08T09:28:30+00:00

URL: https://externals.io/message/56128#56151 · In reply to: #56139

Fixed that one.

https://bugs.php.net/patch-display.php?bug_id=55475&patch=final_patch_for_5_4_and_HEAD_v2&revision=latest 
<https://bugs.php.net/patch-display.php?bug_id=55475&patch=final_patch_for_5_4_and_HEAD_v2&revision=latest>

The alternative patch was to use the argument to enable/disable 
autoloader - which does not really solve the BC issues unfortunately.

The only discussion was to whether is_subclass_of should not support the 
extra arg, since there was not strong opinions either way, it's probably 
better to keep it simple and leave it the same as PHP5.3.

Regrds
Alan


> Hi!
>
> > […]
>
> I'm looking at bug 55475, there are two patches there:
>
> is_a_5.4_alternative and final_patch_for_5_4_and_HEAD. Which one do 
> you mean?
>
> The latter has:
>
> -    if (zend_lookup_class_ex(class_name, class_name_len, NULL, 0, &ce 
> TSRMLS_CC) == FAILURE) {
> +    if (zend_lookup_class_ex(class_name, class_name_len, NULL, &ce 
> TSRMLS_CC) == FAILURE) {
>
> which can't be right.