# session.cache_limiter empty string?

- Thread: https://externals.io/message/55781
- Original archive: https://news-web.php.net/php.internals/55781
- Started by Karoly Negyesi on 2011-10-11T17:42:47+00:00
- Messages: 3
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #55781 — Karoly Negyesi — 2011-10-11T17:42:47+00:00

URL: https://externals.io/message/55781#55781

Hi,

I am trying to understand php_session_cache_limiter but my knowledge
is, well, limited :)

Setting session.cache_limiter to an empty string doesn't send headers.
Is this just an artefact of if (!strcasecmp(lim->name,
PS(cache_limiter))) not matching the empty string or does if
(PS(cache_limiter)[0] == '\0') return 0; deliberately stop it?

Ie. what should I add to the documentation for people who don't want
PHP to send anything?

Thanks

Karoly Negyesi

---

## #56664 — Yasuo Ohgaki — 2011-11-28T21:44:27+00:00

URL: https://externals.io/message/55781#56664 · In reply to: #55781

Hi Karoly,

2011/10/12 Karoly Negyesi <karoly@negyesi.net>:
> Setting session.cache_limiter to an empty string doesn't send headers.
> Is this just an artefact of if (!strcasecmp(lim->name,
> PS(cache_limiter))) not matching the empty string or does if
> (PS(cache_limiter)[0] == '\0') return 0; deliberately stop it?
>
> Ie. what should I add to the documentation for people who don't want
> PHP to send anything?

If I remember correctly, old doc was referred as "none". Any invalid
cache limiter name will be ignored, though.

It may be good idea to raise notice error for invalid limiter name and
introduce "none" limiter.

Any comments?

--
Yasuo Ohgaki
yohgaki@ohgaki.net

---

## #56667 — Yasuo Ohgaki — 2011-11-29T01:03:14+00:00

URL: https://externals.io/message/55781#56667 · In reply to: #56664

2011/11/29 Yasuo Ohgaki <yohgaki@ohgaki.net>:
> Hi Karoly,
>
> 2011/10/12 Karoly Negyesi <karoly@negyesi.net>:
> > […]
>
> If I remember correctly, old doc was referred as "none". Any invalid
> cache limiter name will be ignored, though.
>
> It may be good idea to raise notice error for invalid limiter name and
> introduce "none" limiter.
>
> Any comments?
>

Hi Karoly,

Failing silently in case of typo is not good.
Could you file feature request to bugs.php.net?

I'll make patch for trunk and commit it unless there is objection.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net
