# Tokyo/Kyoto Cabinet in 5.4 - Thread: https://externals.io/message/55672 - Original archive: https://news-web.php.net/php.internals/55672 - Started by Hannes Magnusson on 2011-09-30T11:37:39+00:00 - Messages: 7 - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #55672 — Hannes Magnusson — 2011-09-30T11:37:39+00:00 URL: https://externals.io/message/55672#55672 Hi Tokyo Cabinet support was added to ext/dba "recently".. but Tokyo Cabinet is about to die these days, and getting replaced with Kyoto Cabinet. Shouldn't we drop tokyo cabinet support, before we ever make a stable release with it, so we don't have to maintain it? Preferably replace it with Kyoto Cabinet support I suppose. -Hannes --- ## #55673 — Sebastian Bergmann — 2011-09-30T12:04:05+00:00 URL: https://externals.io/message/55672#55673 · In reply to: #55672 Am 30.09.2011 13:37, schrieb Hannes Magnusson: > Shouldn't we drop tokyo cabinet support, before we ever make a stable > release with it, so we don't have to maintain it? +1 for removing it (if Tokyo Cabinet indeed is dead). > Preferably replace it with Kyoto Cabinet support I suppose. -0 for adding support for Kyoto Cabinet this late in the process. -- Sebastian Bergmann Co-Founder and Principal Consultant http://sebastian-bergmann.de/ http://thePHP.cc/ --- ## #55675 — Michael Maclean — 2011-09-30T16:29:47+00:00 URL: https://externals.io/message/55672#55675 · In reply to: #55672 > Preferably replace it with Kyoto Cabinet support I suppose. I added the TC support initially, so I can look at replacing it over the weekend. -- Cheers, Michael --- ## #56845 — Hannes Magnusson — 2011-12-08T13:58:13+00:00 URL: https://externals.io/message/55672#56845 · In reply to: #55675 > > > > […] > > > I added the TC support initially, so I can look at replacing it over the > weekend. Whats the status on this? -Hannes --- ## #59369 — Hannes Magnusson — 2012-04-06T15:51:39+00:00 URL: https://externals.io/message/55672#59369 · In reply to: #56845 On Thu, Dec 8, 2011 at 14:58, Hannes Magnusson wrote: > > > […] > > Whats the status on this? So... Apparently we release 5.4 with support for it. What is the current plan then? Keep a useless feature in 5.4 for the remainder of the series or..? -Hannes --- ## #59463 — Geoffrey Sneddon — 2012-04-08T15:03:37+00:00 URL: https://externals.io/message/55672#59463 · In reply to: #55672 > Tokyo Cabinet support was added to ext/dba "recently".. but Tokyo > Cabinet is about to die these days, and getting replaced with Kyoto > Cabinet. > Shouldn't we drop tokyo cabinet support, before we ever make a stable > release with it, so we don't have to maintain it? > Preferably replace it with Kyoto Cabinet support I suppose. Is it actually dead? [1] still states: "I'll maintain the both of Tokyo Cabinet and Kyoto Cabinet because their values are different", as well as noting that Tokyo Cabinet is quicker in the single-threaded case. Given that both are maintained, as far as I can tell, as Tokyo Cabinet is quicker in the single-threaded case, as most PHP applications are, there is no reason to remove it. All for adding Kyoto Cabinet support, though. /gsnedders [1]: http://fallabs.com/kyotocabinet/spex.html --- ## #59465 — Michael Maclean — 2012-04-08T16:23:13+00:00 URL: https://externals.io/message/55672#59465 · In reply to: #59463 > Is it actually dead? [1] still states: "I'll maintain the both of Tokyo > Cabinet and Kyoto Cabinet because their values are different", as well > as noting that Tokyo Cabinet is quicker in the single-threaded case. > > Given that both are maintained, as far as I can tell, as Tokyo Cabinet > is quicker in the single-threaded case, as most PHP applications are, > there is no reason to remove it. I don't believe Tokyo is dead, either. I've got half a patch for Kyoto support too, so I'll send that along when it's working. -- Cheers, Michael