# Merge fix for #54918 (r311748) to 5.4?

- Thread: https://externals.io/message/55627
- Original archive: https://news-web.php.net/php.internals/55627
- Started by Pierre Joye on 2011-09-26T08:42:41+00:00
- Messages: 4
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #55627 — Pierre Joye — 2011-09-26T08:42:41+00:00

URL: https://externals.io/message/55627#55627

hi,

It may be good to merge
http://svn.php.net/viewvc?view=revision&revision=311748 to 5.4 too.
This commit is about issues similar to the one describe in #54918.

Any reason not to do it before next beta/rc?

Cheers,
-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

---

## #55628 — Hannes Magnusson — 2011-09-26T09:06:18+00:00

URL: https://externals.io/message/55627#55628 · In reply to: #55627

> hi,
>
> It may be good to merge
> http://svn.php.net/viewvc?view=revision&revision=311748 to 5.4 too.
> This commit is about issues similar to the one describe in #54918.
>

If it gets merged, don't forget
http://svn.php.net/viewvc?view=revision&revision=316134 and
http://svn.php.net/viewvc?view=revision&revision=316135

-Hannes

---

## #55629 — Stas Malyshev — 2011-09-26T17:08:37+00:00

URL: https://externals.io/message/55627#55629 · In reply to: #55627

Hi!


> It may be good to merge
> http://svn.php.net/viewvc?view=revision&revision=311748 to 5.4 too.
> This commit is about issues similar to the one describe in #54918.
>
> Any reason not to do it before next beta/rc?

I'm not sure I understand this patch completely. I understand that if 
one of the MINITs fails, this patch just continues. But we have tons of 
code that assumes all basic MINITs worked - we always use variables 
initialized in these MINITs without checking, etc. So does it really 
make sense to continue if one of basic MINITs fail? On regular module 
loading, MINIT failure is E_CORE_ERROR, why not here?
-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

---

## #55674 — David Soria Parra — 2011-09-30T13:06:39+00:00

URL: https://externals.io/message/55627#55674 · In reply to: #55629

> Hi!
>
> 
> > […]
>
> I'm not sure I understand this patch completely. I understand that if 
> one of the MINITs fails, this patch just continues. But we have tons of 
> code that assumes all basic MINITs worked - we always use variables 
> initialized in these MINITs without checking, etc. So does it really 
> make sense to continue if one of basic MINITs fail? On regular module 
> loading, MINIT failure is E_CORE_ERROR, why not here?

I'm not sure about this too. Is there a reason why we continue to MINIT
the other basic modules if one fails ?