# A couple of missing directories if configure.js is forgotten. - Thread: https://externals.io/message/55452 - Original archive: https://news-web.php.net/php.internals/55452 - Started by Richard Quadling on 2011-09-15T14:20:24+00:00 - Messages: 5 - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #55452 — Richard Quadling — 2011-09-15T14:20:24+00:00 URL: https://externals.io/message/55452#55452 Hi. Sometimes I remove Release prior to nmake to make sure everything builds clean. 2 directories fail to get build Release\win32 Release\devel The attached patch fixes that. Index: win32/build/Makefile =================================================================== --- win32/build/Makefile (revision 316815) +++ win32/build/Makefile (working copy) @@ -91,7 +91,7 @@ @echo Recreating build dirs @if not exist $(BUILD_DIR) mkdir $(BUILD_DIR) @cd $(BUILD_DIR) - @for %D in ($(BUILD_DIRS_SUB)) do @if not exist %D @mkdir %D > NUL + @for %D in ($(BUILD_DIRS_SUB) devel win32) do @if not exist %D @mkdir %D > NUL @if not exist $(BUILD_DIR_DEV) @mkdir $(BUILD_DIR_DEV) > NUL @cd "$(PHP_SRC_DIR)" Richard. -- Richard Quadling Twitter : EE : Zend : PHPDoc @RQuadling : e-e.com/M_248814.html : bit.ly/9O8vFY : bit.ly/lFnVea --- ## #55463 — Pierre Joye — 2011-09-15T21:52:07+00:00 URL: https://externals.io/message/55452#55463 · In reply to: #55462 hi Richard, Can you open a bug for each of your patches please? Thanks! 2011/9/15 Ángel González : > Richard Quadling wrote: > > […] > > Shouldn't you add them to BUILD_DIRS_SUB instead? > > > -- > > > > -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org --- ## #55462 — keisial@gmail.com — 2011-09-15T21:55:25+00:00 URL: https://externals.io/message/55452#55462 · In reply to: #55452 Richard Quadling wrote: > Hi. > > Sometimes I remove Release prior to nmake to make sure everything builds clean. > > 2 directories fail to get build > > Release\win32 > Release\devel > > The attached patch fixes that. > > - @for %D in ($(BUILD_DIRS_SUB)) do @if not exist %D @mkdir %D> NUL > + @for %D in ($(BUILD_DIRS_SUB) devel win32) do @if not exist %D @mkdir %D> NUL > > > > Richard. Shouldn't you add them to BUILD_DIRS_SUB instead? --- ## #55473 — Richard Quadling — 2011-09-16T12:18:24+00:00 URL: https://externals.io/message/55452#55473 · In reply to: #55463 Sure thing. https://bugs.php.net/bug.php?id=55709 and https://bugs.php.net/bug.php?id=55710 2011/9/15 Pierre Joye : > hi Richard, > > Can you open a bug for each of your patches please? Thanks! > > 2011/9/15 Ángel González : > > […] > > > > -- > Pierre > > @pierrejoye | http://blog.thepimp.net | http://www.libgd.org > -- Richard Quadling Twitter : EE : Zend : PHPDoc @RQuadling : e-e.com/M_248814.html : bit.ly/9O8vFY : bit.ly/lFnVea --- ## #55474 — Richard Quadling — 2011-09-16T12:30:21+00:00 URL: https://externals.io/message/55452#55474 · In reply to: #55462 2011/9/15 Ángel González : > Richard Quadling wrote: > > […] > > Shouldn't you add them to BUILD_DIRS_SUB instead? > > Yep! See bug https://bugs.php.net/bug.php?id=55710 with latest patch. It was an edge case for the win32 directory caused by having pecl/win32service configured for building. Any extension with win32 in it would have caused the issue. -- Richard Quadling Twitter : EE : Zend : PHPDoc @RQuadling : e-e.com/M_248814.html : bit.ly/9O8vFY : bit.ly/lFnVea