# Borked SKIPIFs (PHP_5_4)

- Thread: https://externals.io/message/55246
- Original archive: https://news-web.php.net/php.internals/55246
- Started by Ulf Wendel on 2011-09-06T14:40:55+00:00
- Messages: 4
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #55246 — Ulf Wendel — 2011-09-06T14:40:55+00:00

URL: https://externals.io/message/55246#55246

Hi,

annoyed by run-tests.php ignoring borked SKIPIF sections, I hacked it to 
bail out at me if something seemed suspicious. Maintainers may want to 
have a look at:

Fatal/Parse error @ SKIPIF = SKIPIF non functional

   BORK 883/9126 [Zend/tests/bug31683.phpt]
   BORK 4037/9248 [ext/phar/tests/fopen_edgecases2.phpt
   BORK 8443/9248 [ext/standard/tests/strings/md5_file.phpt]
   BORK 8514/9248 [ext/standard/tests/strings/sha1_file.phpt]

Warnings/Notices @ SKIPIF = SKIPIF should work fine

   BORK 4451/9248 [ext/posix/tests/posix_getpgid_error.phpt]
   BORK 4452/9248 [ext/posix/test/posix_getpgid_variation.phpt]
   BORK 4865/9248 [ext/session/test/rfc1867_invalid_settings.phpt]
   BORK 7328/9248 [ext/standard/tests/file/php_fd_wrapper_04.phpt]

My PHP was built with pretty much nothing but MySQL stuff enabled. A 
fair number of tests has probably been skipped.

The run-tests.php hack I used is not worth sharing. All I did was check 
if SKIPIF returns any output after removal of "-d display_errors=0". In 
other words I made the assumption that SKIPIF sections must not output 
anything but "skip <message>" or the like, which causes false positives.

Ulf





Details:


BORK 883/9126 [Zend/tests/bug31683.phpt]

Warning: require_once(skipif.inc): failed to open stream: No such file 
or directory in 
/home/nixnutz/php/php-src/branches/PHP_5_4/Zend/tests/bug31683.skip.php 
on line 1
Fatal error: require_once(): Failed opening required 'skipif.inc' 
(include_path='.:/usr/local/lib/php') in 
/home/nixnutz/php/php-src/branches/PHP_5_4/Zend/tests/bug31683.skip.php 
on line 1


BORK 4037/9248 [ext/phar/tests/fopen_edgecases2.phpt

Fatal error: Call to undefined function php_version() in 
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/phar/tests/fopen_edgecases2.skip.php 
on line 2


BORK 4451/9248 [ext/posix/tests/posix_getpgid_error.phpt]

Notice: Use of undefined constant posix_getpgid - assumed 
'posix_getpgid' in 
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/posix/tests/posix_getpgid_error.skip.php 
on line 2
  [] ext/posix/tests/posix_getpgid_error.phpt


BORK 4452/9248 [ext/posix/test/posix_getpgid_variation.phpt]

Notice: Use of undefined constant posix_getpgid - assumed 
'posix_getpgid' in 
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/posix/tests/posix_getpgid_variation.skip.php 
on line 2


BORK 4865/9248 [ext/session/test/rfc1867_invalid_settings.phpt]

Warning: PHP Startup: session.upload_progress.freq must be greater than 
or equal to zero in Unknown on line 0


BORK 4866/9248 [ext/session/tests/rfc1867_invalid_settings_2.phpt]

Warning: PHP Startup: session.upload_progress.freq cannot be over 100% 
in Unknown on line 0


BORK 7328/9248 [ext/standard/tests/file/php_fd_wrapper_04.phpt]

Warning: include(skipif.inc): failed to open stream: No such file or 
directory in 
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/standard/tests/file/php_fd_wrapper_04.skip.php 
on line 1 
 


Warning: include(): Failed opening 'skipif.inc' for inclusion 
(include_path='.:/usr/local/lib/php') in 
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/standard/tests/file/php_fd_wrapper_04.skip.php 
in line 1


BORK 8443/9248 [ext/standard/tests/strings/md5_file.phpt]

Parse error: syntax error, unexpected '!', expecting '(' in 
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/standard/tests/strings/md5_file.skip.php 
on line 6


BORK 8514/9248 [ext/standard/tests/strings/sha1_file.phpt]

Parse error: syntax error, unexpected '!', expecting '(' in 
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/standard/tests/strings/sha1_file.skip.php 
on line 6

---

## #55248 — Pierre Joye — 2011-09-06T16:19:49+00:00

URL: https://externals.io/message/55246#55248 · In reply to: #55246

hi Ulf,

I fixed two. Feel free to fix the other as well if you have time.


> Hi,
>
> annoyed by run-tests.php ignoring borked SKIPIF sections, I hacked it to
> bail out at me if something seemed suspicious. Maintainers may want to have
> a look at:
>
> Fatal/Parse error @ SKIPIF = SKIPIF non functional
>
>  BORK 883/9126 [Zend/tests/bug31683.phpt]
>  BORK 4037/9248 [ext/phar/tests/fopen_edgecases2.phpt
>  BORK 8443/9248 [ext/standard/tests/strings/md5_file.phpt]
>  BORK 8514/9248 [ext/standard/tests/strings/sha1_file.phpt]
>
> Warnings/Notices @ SKIPIF = SKIPIF should work fine
>
>  BORK 4451/9248 [ext/posix/tests/posix_getpgid_error.phpt]
>  BORK 4452/9248 [ext/posix/test/posix_getpgid_variation.phpt]
>  BORK 4865/9248 [ext/session/test/rfc1867_invalid_settings.phpt]
>  BORK 7328/9248 [ext/standard/tests/file/php_fd_wrapper_04.phpt]
>
> My PHP was built with pretty much nothing but MySQL stuff enabled. A fair
> number of tests has probably been skipped.
>
> The run-tests.php hack I used is not worth sharing. All I did was check if
> SKIPIF returns any output after removal of "-d display_errors=0". In other
> words I made the assumption that SKIPIF sections must not output anything
> but "skip <message>" or the like, which causes false positives.
>
> Ulf
>
>
>
>
>
> Details:
>
>
> BORK 883/9126 [Zend/tests/bug31683.phpt]
>
> Warning: require_once(skipif.inc): failed to open stream: No such file or
> directory in
> /home/nixnutz/php/php-src/branches/PHP_5_4/Zend/tests/bug31683.skip.php on
> line 1
> Fatal error: require_once(): Failed opening required 'skipif.inc'
> (include_path='.:/usr/local/lib/php') in
> /home/nixnutz/php/php-src/branches/PHP_5_4/Zend/tests/bug31683.skip.php on
> line 1
>
>
> BORK 4037/9248 [ext/phar/tests/fopen_edgecases2.phpt
>
> Fatal error: Call to undefined function php_version() in
> /home/nixnutz/php/php-src/branches/PHP_5_4/ext/phar/tests/fopen_edgecases2.skip.php
> on line 2
>
>
> BORK 4451/9248 [ext/posix/tests/posix_getpgid_error.phpt]
>
> Notice: Use of undefined constant posix_getpgid - assumed 'posix_getpgid' in
> /home/nixnutz/php/php-src/branches/PHP_5_4/ext/posix/tests/posix_getpgid_error.skip.php
> on line 2
>  [] ext/posix/tests/posix_getpgid_error.phpt
>
>
> BORK 4452/9248 [ext/posix/test/posix_getpgid_variation.phpt]
>
> Notice: Use of undefined constant posix_getpgid - assumed 'posix_getpgid' in
> /home/nixnutz/php/php-src/branches/PHP_5_4/ext/posix/tests/posix_getpgid_variation.skip.php
> on line 2
>
>
> BORK 4865/9248 [ext/session/test/rfc1867_invalid_settings.phpt]
>
> Warning: PHP Startup: session.upload_progress.freq must be greater than or
> equal to zero in Unknown on line 0
>
>
> BORK 4866/9248 [ext/session/tests/rfc1867_invalid_settings_2.phpt]
>
> Warning: PHP Startup: session.upload_progress.freq cannot be over 100% in
> Unknown on line 0
>
>
> BORK 7328/9248 [ext/standard/tests/file/php_fd_wrapper_04.phpt]
>
> Warning: include(skipif.inc): failed to open stream: No such file or
> directory in
> /home/nixnutz/php/php-src/branches/PHP_5_4/ext/standard/tests/file/php_fd_wrapper_04.skip.php
> on line 1
>
>
> Warning: include(): Failed opening 'skipif.inc' for inclusion
> (include_path='.:/usr/local/lib/php') in
> /home/nixnutz/php/php-src/branches/PHP_5_4/ext/standard/tests/file/php_fd_wrapper_04.skip.php
> in line 1
>
>
> BORK 8443/9248 [ext/standard/tests/strings/md5_file.phpt]
>
> Parse error: syntax error, unexpected '!', expecting '(' in
> /home/nixnutz/php/php-src/branches/PHP_5_4/ext/standard/tests/strings/md5_file.skip.php
> on line 6
>
>
> BORK 8514/9248 [ext/standard/tests/strings/sha1_file.phpt]
>
> Parse error: syntax error, unexpected '!', expecting '(' in
> /home/nixnutz/php/php-src/branches/PHP_5_4/ext/standard/tests/strings/sha1_file.skip.php
> on line 6
>
> --
> 
> 
>
>



-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

---

## #55249 — Ulf Wendel — 2011-09-06T16:53:34+00:00

URL: https://externals.io/message/55246#55249 · In reply to: #55248

Hi Pierre, hi all,

those three should be left:

   BORK 8514/9248 [ext/standard/tests/strings/sha1_file.phpt]
   BORK 8443/9248 [ext/standard/tests/strings/md5_file.phpt]
   BORK 7328/9248 [ext/standard/tests/file/php_fd_wrapper_04.phpt]

They might take more than 1 second (verbally) to fix. Leaving to someone 
else to have a 30 seconds look... ;-)

Ulf

---

## #55252 — Pierre Joye — 2011-09-06T17:06:45+00:00

URL: https://externals.io/message/55246#55252 · In reply to: #55249

> Hi Pierre, hi all,
>
> those three should be left:
>
>  BORK 8514/9248 [ext/standard/tests/strings/sha1_file.phpt]
>  BORK 8443/9248 [ext/standard/tests/strings/md5_file.phpt]

those are fixed already :)

>  BORK 7328/9248 [ext/standard/tests/file/php_fd_wrapper_04.phpt]
>
> They might take more than 1 second (verbally) to fix. Leaving to someone
> else to have a 30 seconds look... ;-)
>
> Ulf
>
> --
> 
> 
>
>



-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org