# ext/pcre/tests/006.phpt - Thread: https://externals.io/message/55130 - Original archive: https://news-web.php.net/php.internals/55130 - Started by Ferenc Kovacs on 2011-09-03T01:10:31+00:00 - Messages: 5 - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #55130 — Ferenc Kovacs — 2011-09-03T01:10:31+00:00 URL: https://externals.io/message/55130#55130 Hi, I started debugging why ext/pcre/tests/006.phpt fails, I've pinpointed the guilty commit: http://svn.php.net/viewvc?view=revision&revision=311323 it seems that the behavior was depending on the backtrack limit, but I'm not sure what to do with the test. should I simply delete? or can we change the patter in such way that it would return `NULL` again? I'm not even sure what are we testing there. :/ -- Ferenc Kovács @Tyr43l - http://tyrael.hu --- ## #55168 — Stas Malyshev — 2011-09-04T04:49:18+00:00 URL: https://externals.io/message/55130#55168 · In reply to: #55130 Hi! > http://svn.php.net/viewvc?view=revision&revision=311323 > it seems that the behavior was depending on the backtrack limit, but > I'm not sure what to do with the test. > should I simply delete? or can we change the patter in such way that > it would return `NULL` again? > I'm not even sure what are we testing there. :/ This tests works for me. What is the failure in your case? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 --- ## #55183 — Alexey Shein — 2011-09-04T10:41:11+00:00 URL: https://externals.io/message/55130#55183 · In reply to: #55168 It fails for me too, but only in PHP_5_3 branch, PHP_5_4 and trunk are ok. It seems it starts to fail after Rasmus's default backtrack limit increasion (as Tyrael pointed in his message), which was fixed for PHP_5_4 and trunk in this commit: http://svn.php.net/viewvc?view=revision&revision=312110. Maybe PHP_5_3 branch should be changed accordingly? 2011/9/4 Stas Malyshev : > Hi! > > > > […] > > This tests works for me. What is the failure in your case? > -- > Stanislav Malyshev, Software Architect > SugarCRM: http://www.sugarcrm.com/ > (408)454-6900 ext. 227 > > -- > > > > -- Regards, Shein Alexey --- ## #55187 — Ferenc Kovacs — 2011-09-04T12:21:41+00:00 URL: https://externals.io/message/55130#55187 · In reply to: #55183 thanks, I should have mentioned that I was playing with the 5_3 branch. > It fails for me too, but only in PHP_5_3 branch, PHP_5_4 and trunk are > ok. It seems it starts to fail after Rasmus's default backtrack limit > increasion (as Tyrael pointed in his message), which was fixed for > PHP_5_4 and trunk in this commit: > http://svn.php.net/viewvc?view=revision&revision=312110. Maybe PHP_5_3 > branch should be changed accordingly? > > 2011/9/4 Stas Malyshev : > > […] > > > > -- > Regards, > Shein Alexey > -- Ferenc Kovács @Tyr43l - http://tyrael.hu --- ## #55188 — Ferenc Kovacs — 2011-09-04T13:29:54+00:00 URL: https://externals.io/message/55130#55188 · In reply to: #55183 > It fails for me too, but only in PHP_5_3 branch, PHP_5_4 and trunk are > ok. It seems it starts to fail after Rasmus's default backtrack limit > increasion (as Tyrael pointed in his message), which was fixed for > PHP_5_4 and trunk in this commit: > http://svn.php.net/viewvc?view=revision&revision=312110. Maybe PHP_5_3 > branch should be changed accordingly? > I've just did that, thanks for the tip. http://svn.php.net/viewvc/php/php-src/branches/PHP_5_3/ext/pcre/tests/006.phpt?r1=316107&r2=316106&pathrev=316107 -- Ferenc Kovács @Tyr43l - http://tyrael.hu