# drop bison 1.x?

- Thread: https://externals.io/message/55069
- Original archive: https://news-web.php.net/php.internals/55069
- Started by Pierre Joye on 2011-09-01T18:58:03+00:00
- Messages: 3
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #55069 — Pierre Joye — 2011-09-01T18:58:03+00:00

URL: https://externals.io/message/55069#55069

Please show me one system relying on it?  13 years old...

Even if the plan is to drop it in 5.4+ for now.

And yes the diff in the messages make testing harder as it should be. Other
would have noticed it already as many tests fail because of that.
On Sep 1, 2011 8:44 PM, "Hannes Magnusson" <hannes.magnusson@gmail.com>
wrote:

---

## #55074 — Hannes Magnusson — 2011-09-01T20:54:57+00:00

URL: https://externals.io/message/55069#55074 · In reply to: #55069

> Please show me one system relying on it?  13 years old...
>

Your own test box before Rasmus pointed it out to you when you where
changing the tests.

Forcing people to upgrade this kind of software between bugfix
releases doesn't give us anything other then annoyed users.


> Even if the plan is to drop it in 5.4+ for now.

Fair enough.


> And yes the diff in the messages make testing harder as it should be. Other
> would have noticed it already as many tests fail because of that.

So it works just fine? There are no security or related bugs in the
older versions? Or even performance reasons?

There is no reason for us to test error messages from third party
software, and it doesn't cost us any more work to support it..

-Hannes

---

## #55075 — Ferenc Kovacs — 2011-09-01T22:04:38+00:00

URL: https://externals.io/message/55069#55075 · In reply to: #55074

On Thu, Sep 1, 2011 at 10:54 PM, Hannes Magnusson
<hannes.magnusson@gmail.com> wrote:
> 
> > […]
>
> Your own test box before Rasmus pointed it out to you when you where
> changing the tests.
>
> Forcing people to upgrade this kind of software between bugfix
> releases doesn't give us anything other then annoyed users.
>
>
> > […]
>
> Fair enough.
>
>
> > […]
>
> So it works just fine? There are no security or related bugs in the
> older versions? Or even performance reasons?
>
> There is no reason for us to test error messages from third party
> software, and it doesn't cost us any more work to support it..
>
> -Hannes
>
> --
> 
> 
>
>

I'm not sure that I understand this correctly, so let me ask this:
Pierre do you want to change this because of this two broken tests:
http://news.php.net/php.internals/55048 ?
AFAIK it isn't directly related to different versions of bison, but to
this change in 5.4 :
https://wiki.php.net/rfc/improved-parser-error-message
and yes, this means that we have to support a diverging set of tests
for those cases when the test depends on the parse error messages.
I think it is safe to revert your changes for those two tests in the 5.3 branch.

-- 
Ferenc Kovács
@Tyr43l - http://tyrael.hu