# drop bison 1.x?

- Thread: https://externals.io/message/55052
- Original archive: https://news-web.php.net/php.internals/55052
- Started by Pierre Joye on 2011-09-01T09:22:40+00:00
- Messages: 3
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #55052 — Pierre Joye — 2011-09-01T09:22:40+00:00

URL: https://externals.io/message/55052#55052

Hi,

It would help a lot to test the parser if we drop bison 1.x support.
It won't change anything in the parser rules or in the code base but
only the way we test it. Bison version 1.x has different messages than
2.x (formats and contents). It causes some tests to fail because of
these different messages.

I wonder if we could simply stop to support bison 1.x in 5.3 and later
or at least in 5.4+. But if we do it in 5.4+ only it will be harder to
maintain both tests synced and compared the results between the two
branches (eventual BC breaks or similar breakages).

Comments?

Cheers,
-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

---

## #55066 — Pierre Joye — 2011-09-01T17:14:21+00:00

URL: https://externals.io/message/55052#55066 · In reply to: #55052

I will simply drop 1.4 support by Monday if there is no opposition.

Cheers,


> Hi,
>
> It would help a lot to test the parser if we drop bison 1.x support.
> It won't change anything in the parser rules or in the code base but
> only the way we test it. Bison version 1.x has different messages than
> 2.x (formats and contents). It causes some tests to fail because of
> these different messages.
>
> I wonder if we could simply stop to support bison 1.x in 5.3 and later
> or at least in 5.4+. But if we do it in 5.4+ only it will be harder to
> maintain both tests synced and compared the results between the two
> branches (eventual BC breaks or similar breakages).
>
> Comments?
>
> Cheers,
> --
> Pierre
>
> @pierrejoye | http://blog.thepimp.net | http://www.libgd.org
>



-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

---

## #55068 — Hannes Magnusson — 2011-09-01T18:44:35+00:00

URL: https://externals.io/message/55052#55068 · In reply to: #55066

Thats not something you do in a bugfix release.

Is different error messages really the only reason you want to drop 1.x?
Seems like a bad reason.
Why are we testing error messages from a 3rd party software anyway?

-Hannes


> I will simply drop 1.4 support by Monday if there is no opposition.
>
> Cheers,
>
> 
> > […]
>
>
>
> --
> Pierre
>
> @pierrejoye | http://blog.thepimp.net | http://www.libgd.org