# 5.3.6-13 -> 5.3.7-1 test result diff - Thread: https://externals.io/message/54805 - Original archive: https://news-web.php.net/php.internals/54805 - Started by ondrej@sury.org on 2011-08-22T22:21:48+00:00 - Messages: 6 - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #54805 — ondrej@sury.org — 2011-08-22T22:21:48+00:00 URL: https://externals.io/message/54805#54805 This is stripped down bug list diff (only + or - lines included) between *Debian* 5.3.6-13 and 5.3.7-1 (almost same patch list, removed patches were merged upstream). Ideally the FAILED test list should be empty, so we (the packagers) would know that we created the regression in the distribution, we stop the build and fix the regression (or the test). You can find the full test-results at http://www.sury.org/php-tests/ O. ===================================================================== FAILED TEST SUMMARY --------------------------------------------------------------------- +Bug #55156 (ReflectionClass::getDocComment() returns comment even though the class has none) [Zend/tests/bug55156.phpt] -DateTime::diff() add() sub() -- absolute [ext/date/tests/DateTime_diff_add_sub-absolute.phpt] -DateTime::diff() add() sub() -- dates [ext/date/tests/DateTime_diff_add_sub-dates.phpt] -DateTime::diff() add() sub() -- february [ext/date/tests/DateTime_diff_add_sub-february.phpt] -DateTime::diff() add() sub() -- massive [ext/date/tests/DateTime_diff_add_sub-massive.phpt] -Bug #51819 (Case discrepancy in timezone names cause Uncaught exception and fatal error) [ext/date/tests/bug51819.phpt] -Bug #51994 (date_parse_from_format is parsing invalid date using 'yz' format) [ext/date/tests/bug51994.phpt] -Test `gmstrftime()` function : usage variation - Checking Preferred date and time representation other than on Windows. [ext/date/tests/gmstrftime_variation22.phpt] -Test `strftime()` function : usage variation - Checking Preferred date and time representation other than on Windows. [ext/date/tests/strftime_variation22.phpt] +DateTime::diff() days -- spring type2 type2 [ext/date/tests/DateTime_days-spring-type2-type2.phpt] +DateTime::diff() days -- spring type2 type3 [ext/date/tests/DateTime_days-spring-type2-type3.phpt] +DateTime::diff() days -- spring type3 type2 [ext/date/tests/DateTime_days-spring-type3-type2.phpt] +DateTime::diff() days -- spring type3 type3 [ext/date/tests/DateTime_days-spring-type3-type3.phpt] +DateTime::sub() -- dates [ext/date/tests/DateTime_sub-dates.phpt] +DateTime::sub() -- february [ext/date/tests/DateTime_sub-february.phpt] -DOMDocument::$validateOnParse - effectual determination (dom_document_validate_on_parse_read/dom_document_validate_on_parse_write) [ext/dom/test/DOMDocument_validate_on_parse_variation.phpt] -Test 5: HTML Test [ext/dom/tests/dom005.phpt] +DOMDocument::relaxNGValidate() should fail on invalid RelaxNG file source [ext/dom/tests/DOMDocument_relaxNGValidate_error2.phpt] +API vs. SQL LAST_INSERT_ID() [ext/mysqli/tests/mysqli_last_insert_id.phpt] +Bug #54992: Stream not closed and error not returned when SSL CN_match fails [ext/openssl/tests/bug54992.phpt] +preg_replace() with array of failing regular expressions [ext/pcre/tests/006.phpt] -SimpleXML: XPath [ext/simplexml/tests/008.phpt] -ext/sockets - socket_strerror - basic test [ext/sockets/tests/socket_strerror.phpt] +Bug #48601 (xpath() returns `FALSE` for legitimate query) [ext/simplexml/tests/bug48601.phpt] -Test `copy()` function: usage variations - destination file names(empty string, nulls & bools) [ext/standard/tests/file/copy_variation4.phpt] -Test `file_put_contents()` function : usage variation - obscure filenames [ext/standard/tests/file/file_put_contents_variation8.phpt] -Test `fscanf()` function: usage variations - unsigned int formats with integer values [ext/standard/tests/file/fscanf_variation39.phpt] -Test `fscanf()` function: usage variations - tracking file pointer while reading [ext/standard/tests/file/fscanf_variation55.phpt] Test `lstat()` and `stat()` functions: usage variations - effects of `touch()` on link [ext/standard/tests/file/lstat_stat_variation6.phpt] -Test `readfile()` function : variation - various invalid paths [ext/standard/tests/file/readfile_variation10.phpt] -Test `rand()` function : usage variations - different data types as $min argument [ext/standard/tests/math/mt_rand_variation1.phpt] -Test `mt_rand()` function : usage variations - different data types as $max argument [ext/standard/tests/math/mt_rand_variation2.phpt] -serialize()/unserialize()/var_dump() [ext/standard/tests/serialize/001.phpt] -Test `serialize()` & `unserialize()` functions: arrays (circular references) [ext/standard/tests/serialize/serialization_arrays_001.phpt] -Test `serialize()` & `unserialize()` functions: objects [ext/standard/tests/serialize/serialization_objects_001.phpt] -Test `serialize()` & `unserialize()` functions: objects (variations) [ext/standard/tests/serialize/serialization_objects_002.phpt] -Test `serialize()` & `unserialize()` functions: objects (abstract classes) [ext/standard/tests/serialize/serialization_objects_003.phpt] -Test `printf()` function (64bit) [ext/standard/tests/strings/printf_64bit.phpt] -Test `sscanf()` function : basic functionality - unsigned format [ext/standard/tests/strings/sscanf_basic6.phpt] -msg_send() data types when not serializing [ext/sysvmsg/tests/006.phpt] +Check the `php_ini_loaded_file()` function [ext/standard/tests/php_ini_loaded_file.phpt] -- Ondřej Surý This is stripped down bug list diff (only + or - lines included) > between *Debian* 5.3.6-13 and 5.3.7-1 (almost same patch list, removed > patches were merged upstream). Ideally the FAILED test list should be > empty, so we (the packagers) would know that we created the regression > in the distribution, we stop the build and fix the regression (or the > test). > > You can find the full test-results at http://www.sury.org/php-tests/ > > O. > >  ===================================================================== >  FAILED TEST SUMMARY >  --------------------------------------------------------------------- > +Bug #55156 (ReflectionClass::getDocComment() returns comment even > though the class has none) [Zend/tests/bug55156.phpt] > -DateTime::diff() add() sub() -- absolute > [ext/date/tests/DateTime_diff_add_sub-absolute.phpt] > -DateTime::diff() add() sub() -- dates > [ext/date/tests/DateTime_diff_add_sub-dates.phpt] > -DateTime::diff() add() sub() -- february > [ext/date/tests/DateTime_diff_add_sub-february.phpt] > -DateTime::diff() add() sub() -- massive > [ext/date/tests/DateTime_diff_add_sub-massive.phpt] > -Bug #51819 (Case discrepancy in timezone names cause Uncaught > exception and fatal error) [ext/date/tests/bug51819.phpt] > -Bug #51994 (date_parse_from_format is parsing invalid date using 'yz' > format) [ext/date/tests/bug51994.phpt] > -Test `gmstrftime()` function : usage variation - Checking Preferred > date and time representation other than on Windows. > [ext/date/tests/gmstrftime_variation22.phpt] > -Test `strftime()` function : usage variation - Checking Preferred date > and time representation other than on Windows. > [ext/date/tests/strftime_variation22.phpt] > +DateTime::diff() days -- spring type2 type2 > [ext/date/tests/DateTime_days-spring-type2-type2.phpt] > +DateTime::diff() days -- spring type2 type3 > [ext/date/tests/DateTime_days-spring-type2-type3.phpt] > +DateTime::diff() days -- spring type3 type2 > [ext/date/tests/DateTime_days-spring-type3-type2.phpt] > +DateTime::diff() days -- spring type3 type3 > [ext/date/tests/DateTime_days-spring-type3-type3.phpt] > +DateTime::sub() -- dates [ext/date/tests/DateTime_sub-dates.phpt] > +DateTime::sub() -- february [ext/date/tests/DateTime_sub-february.phpt] > -DOMDocument::$validateOnParse - effectual determination > (dom_document_validate_on_parse_read/dom_document_validate_on_parse_write) > [ext/dom/test/DOMDocument_validate_on_parse_variation.phpt] > -Test 5: HTML Test [ext/dom/tests/dom005.phpt] > +DOMDocument::relaxNGValidate() should fail on invalid RelaxNG file > source [ext/dom/tests/DOMDocument_relaxNGValidate_error2.phpt] > +API vs. SQL LAST_INSERT_ID() [ext/mysqli/tests/mysqli_last_insert_id.phpt] > +Bug #54992: Stream not closed and error not returned when SSL > CN_match fails [ext/openssl/tests/bug54992.phpt] > +preg_replace() with array of failing regular expressions > [ext/pcre/tests/006.phpt] > -SimpleXML: XPath [ext/simplexml/tests/008.phpt] > -ext/sockets - socket_strerror - basic test > [ext/sockets/tests/socket_strerror.phpt] > +Bug #48601 (xpath() returns `FALSE` for legitimate query) > [ext/simplexml/tests/bug48601.phpt] > -Test `copy()` function: usage variations - destination file names(empty > string, nulls & bools) [ext/standard/tests/file/copy_variation4.phpt] > -Test `file_put_contents()` function : usage variation - obscure > filenames [ext/standard/tests/file/file_put_contents_variation8.phpt] > -Test `fscanf()` function: usage variations - unsigned int formats with > integer values [ext/standard/tests/file/fscanf_variation39.phpt] > -Test `fscanf()` function: usage variations - tracking file pointer > while reading [ext/standard/tests/file/fscanf_variation55.phpt] >  Test `lstat()` and `stat()` functions: usage variations - effects of > `touch()` on link [ext/standard/tests/file/lstat_stat_variation6.phpt] > -Test `readfile()` function : variation - various invalid paths > [ext/standard/tests/file/readfile_variation10.phpt] > -Test `rand()` function : usage variations - different data types as > $min argument [ext/standard/tests/math/mt_rand_variation1.phpt] > -Test `mt_rand()` function : usage variations - different data types as > $max argument [ext/standard/tests/math/mt_rand_variation2.phpt] > -serialize()/unserialize()/var_dump() [ext/standard/tests/serialize/001.phpt] > -Test `serialize()` & `unserialize()` functions: arrays (circular > references) [ext/standard/tests/serialize/serialization_arrays_001.phpt] > -Test `serialize()` & `unserialize()` functions: objects > [ext/standard/tests/serialize/serialization_objects_001.phpt] > -Test `serialize()` & `unserialize()` functions: objects (variations) > [ext/standard/tests/serialize/serialization_objects_002.phpt] > -Test `serialize()` & `unserialize()` functions: objects (abstract > classes) [ext/standard/tests/serialize/serialization_objects_003.phpt] > -Test `printf()` function (64bit) [ext/standard/tests/strings/printf_64bit.phpt] > -Test `sscanf()` function : basic functionality - unsigned format > [ext/standard/tests/strings/sscanf_basic6.phpt] > -msg_send() data types when not serializing [ext/sysvmsg/tests/006.phpt] > +Check the `php_ini_loaded_file()` function > [ext/standard/tests/php_ini_loaded_file.phpt] > > -- > Ondřej Surý > > -- > > > > -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org --- ## #54807 — Stas Malyshev — 2011-08-22T22:31:56+00:00 URL: https://externals.io/message/54805#54807 · In reply to: #54806 Hi! > hi Ondrej! > > As far I remember, Daniel fixed some of the (numerous) failing > datetime tests. Can you try to give it a run using current 5.3 branche > pls? We still have tons of failures in DateTime IIRC and that's because of the buggy three-letter timezones. As far as I know, it's still not fixed - would be great if we could have it for 5.4 release. Derick? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 --- ## #54810 — Daniel Convissor — 2011-08-23T02:33:22+00:00 URL: https://externals.io/message/54805#54810 · In reply to: #54807 Hi Stas: > > We still have tons of failures in DateTime IIRC and that's because > of the buggy three-letter timezones. There are bugs with both type 1 (regularly created datetimes) and type 2 (datetimes created using three letter timezones) timezone objects when it comes to the daylight/standard time transition. I've composed a first draft of an RFC on how PHP should behave regarding these transitions and am refining it with Derick. I hope it will be finished soon. Once that's done, the code can be fixed to match the expected behavior. > not fixed - would be great if we could have it for 5.4 release. > Derick? Yes, it would be great for this to be in 5.4. Thanks, --Dan -- T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y data intensive web and database programming http://www.AnalysisAndSolutions.com/ 4015 7th Ave #4, Brooklyn NY 11232 v: 718-854-0335 f: 718-854-0409 --- ## #54815 — ondrej@sury.org — 2011-08-23T07:09:37+00:00 URL: https://externals.io/message/54805#54815 · In reply to: #54810 Hi all, On Tue, Aug 23, 2011 at 04:33, Daniel Convissor wrote: > Hi Stas: > > > > […] > > There are bugs with both type 1 (regularly created datetimes) and type 2 > (datetimes created using three letter timezones) timezone objects when > it comes to the daylight/standard time transition.  I've composed a > first draft of an RFC on how PHP should behave regarding these > transitions and am refining it with Derick.  I hope it will be finished > soon.  Once that's done, the code can be fixed to match the expected > behavior. > > > > […] > > Yes, it would be great for this to be in 5.4. I probably don't know enough about procedures here. But if you know that the tests are failing, you should move them to XFAIL category, don't you? So if there is a test which falls into the FAILED, you can stop the build and investigate what went wrong. This will also allow you to do automated tests on nightly builds and make the tests mandatory before the release by enforcing the policy by some release scripts. Or make the tests mandatory on every build with option to turn them (selectively) off. I will also try to automate this process in the Debian packages (saving list of failed tests somewhere and comparing them to the results of the build). But that doesn't mean the results will be same as vanilla PHP (embedded vs shared libraries, some Debian specific patches, etc.) and same on different systems with different libraries. O. -- Ondřej Surý > I probably don't know enough about procedures here. But if you know > that the tests are failing, you should move them to XFAIL category, > don't you? The tests that are expected to fail are marked XFAIL. The two other of my date tests that were failing had bugs in the test (sorry). One of those have already been fixed and I'm working on fixing the other one. Thanks, --Dan -- T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y data intensive web and database programming http://www.AnalysisAndSolutions.com/ 4015 7th Ave #4, Brooklyn NY 11232 v: 718-854-0335 f: 718-854-0409