# Coverity Scan - Thread: https://externals.io/message/54432 - Original archive: https://news-web.php.net/php.internals/54432 - Started by Rasmus Lerdorf on 2011-08-07T03:07:01+00:00 - Messages: 6 - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #54432 — Rasmus Lerdorf — 2011-08-07T03:07:01+00:00 URL: https://externals.io/message/54432#54432 Coverity has run a new scan of trunk and there are a lot of valid issues. You have probably noticed that I have started to fix some of them, but there are 500+ to go, so I could use some help. The following people already have Coverity accounts: andi, antony, colder, derick, dmitry, helly, iliaa, jcogg, joey, kmori, mike, nickpj, nlopess, phoddie, rui, sas, scottmac, sean, sesser, slif, steph, tgoldstein, thiago, wez and zeev If you would like to help out and you don't have an account, please send me an email or catch me on irc and I will get you set up. Once you have an account, go to: http://scan.coverity.com/rung2.html And click on the "Sign in" link next to PHP If you start working on fixing one of these, please assign it to yourself first within the Coverity UI so others will know. -Rasmus --- ## #54454 — Scott MacVicar — 2011-08-08T07:18:50+00:00 URL: https://externals.io/message/54432#54454 · In reply to: #54432 > Coverity has run a new scan of trunk and there are a lot of valid > issues. You have probably noticed that I have started to fix some of > them, but there are 500+ to go, so I could use some help. The following > people already have Coverity accounts: > > andi, antony, colder, derick, dmitry, helly, iliaa, jcogg, joey, kmori, > mike, nickpj, nlopess, phoddie, rui, sas, scottmac, sean, sesser, slif, > steph, tgoldstein, thiago, wez and zeev > > If you would like to help out and you don't have an account, please send > me an email or catch me on irc and I will get you set up. > > Once you have an account, go to: > > http://scan.coverity.com/rung2.html > > And click on the "Sign in" link next to PHP > > If you start working on fixing one of these, please assign it to > yourself first within the Coverity UI so others will know. All these changes to PHP 5.3 scare me, I was hoping we'd see 5.3.7 released sooner but after all these changes I think we'll need some more RCs out. Thoughts ilia? - S --- ## #54459 — Ilia Alshanetsky — 2011-08-08T10:47:25+00:00 URL: https://externals.io/message/54432#54459 · In reply to: #54454 Scott, I've looked through most of the changes (some are even mine ;-) ) and they seem to be fairly harmless initialization tweaks etc... As it stands I think we should be in good shape to package 5.3.7 on Wed and finally get it out of the door. > > > > […] > > All these changes to PHP 5.3 scare me, I was hoping we'd see 5.3.7 released sooner but after all these changes I think we'll need some more RCs out. > > Thoughts ilia? > > - S --- ## #54485 — Joey Smith — 2011-08-09T06:45:49+00:00 URL: https://externals.io/message/54432#54485 · In reply to: #54432 > Coverity has run a new scan of trunk and there are a lot of valid > issues. You have probably noticed that I have started to fix some of > them, but there are 500+ to go, so I could use some help. The following > people already have Coverity accounts: > > andi, antony, colder, derick, dmitry, helly, iliaa, jcogg, joey, kmori, > mike, nickpj, nlopess, phoddie, rui, sas, scottmac, sean, sesser, slif, > steph, tgoldstein, thiago, wez and zeev > > If you would like to help out and you don't have an account, please send > me an email or catch me on irc and I will get you set up. > > Once you have an account, go to: > > http://scan.coverity.com/rung2.html > > And click on the "Sign in" link next to PHP > > If you start working on fixing one of these, please assign it to > yourself first within the Coverity UI so others will know. > > -Rasmus A lot of the 'STACK_USE' ones seem to be false positives; it's reporting when the stack "exceeds the maximum single use of 1024 bytes" - that 1024 is a Coverity-configurable value which defaults to 1024. --- ## #54486 — Rasmus Lerdorf — 2011-08-09T07:19:53+00:00 URL: https://externals.io/message/54432#54486 · In reply to: #54485 On 08/08/2011 11:45 PM, Joey Smith wrote > A lot of the 'STACK_USE' ones seem to be false positives; it's reporting > when the stack "exceeds the maximum single use of 1024 bytes" - that 1024 > is a Coverity-configurable value which defaults to 1024. Yup, we can simply mark those as intentional/ignore although it wouldn't be a bad idea to have a quick look at each one to see if we really need to chew up 1k of stack on each of those occasions. People using PHP in embedded systems would appreciate that, I bet. -Rasmus --- ## #54488 — Joey Smith — 2011-08-09T07:45:19+00:00 URL: https://externals.io/message/54432#54488 · In reply to: #54486 > On 08/08/2011 11:45 PM, Joey Smith wrote > > […] > > Yup, we can simply mark those as intentional/ignore although it wouldn't > be a bad idea to have a quick look at each one to see if we really need > to chew up 1k of stack on each of those occasions. People using PHP in > embedded systems would appreciate that, I bet. > > -Rasmus Quite a few of the ones I looked at were reporting it due to MAXPATHLEN, which I imagine we probably want to leave untouched - I'll just mark those as intentional/ignore.