# Magic quotes removal previous patch - Thread: https://externals.io/message/54111 - Original archive: https://news-web.php.net/php.internals/54111 - Started by Pierre Joye on 2011-07-20T19:44:28+00:00 - Messages: 12 - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #54111 — Pierre Joye — 2011-07-20T19:44:28+00:00 URL: https://externals.io/message/54111#54111 hi, Please find as attachment the previous patch to remove the magic quotes. The log I was using back then was (5 years ago already, mq resists :): Log: - remove magic_quotes_gpc, magic_quotes_runtime, magic_quotes_sybase (calling ini_set('magic_....') returns 0|false - get_magic_quotes_gpc, get_magic_quotes_runtime are kept but always return false - set_magic_quotes_runtime raises an `E_CORE_ERROR` Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org --- ## #54112 — Pierrick Charron — 2011-07-20T20:23:07+00:00 URL: https://externals.io/message/54111#54112 · In reply to: #54111 Hi, I have a more recent one on my laptop. I'll update it tonight or tomorrow to make sure it work on 5.4 and send it in this thread. Pierrick > hi, > > Please find as attachment the previous patch to remove the magic quotes. > > The log I was using back then was (5 years ago already, mq resists :): > > Log: > - remove magic_quotes_gpc, magic_quotes_runtime, magic_quotes_sybase > (calling ini_set('magic_....') returns 0|false > - get_magic_quotes_gpc, get_magic_quotes_runtime are kept but always > return false > - set_magic_quotes_runtime raises an `E_CORE_ERROR` > > Cheers, > -- > Pierre > > @pierrejoye | http://blog.thepimp.net | http://www.libgd.org --- ## #54113 — Pierrick Charron — 2011-07-21T00:18:58+00:00 URL: https://externals.io/message/54111#54113 · In reply to: #54111 I tried to send the patch as a .txt file but it seems my mail was not send to internals since i don't see it on news.php.net. Anyway you'll find patch (code + tests) here : - http://www.adoy.net/php/remove-magic-quotes.txt - http://www.adoy.net/php/remove-magic-quotes-tests.txt Pierrick > > hi, > > Please find as attachment the previous patch to remove the magic quotes. > > The log I was using back then was (5 years ago already, mq resists :): > >  Log: >  - remove magic_quotes_gpc, magic_quotes_runtime, magic_quotes_sybase >  (calling ini_set('magic_....') returns 0|false >  - get_magic_quotes_gpc, get_magic_quotes_runtime are kept but always > return false >  - set_magic_quotes_runtime raises an `E_CORE_ERROR` > > Cheers, > -- > Pierre > > @pierrejoye | http://blog.thepimp.net | http://www.libgd.org --- ## #54116 — Pierre Joye — 2011-07-21T09:19:34+00:00 URL: https://externals.io/message/54111#54116 · In reply to: #54113 hi Pierrick! Thanks for the updated patch :) Now the only question remaining is which level warning we should use for the setter. I'm happy with E_CORE. Objections? > I tried to send the patch as a .txt file but it seems my mail was not > send to internals since i don't see it on news.php.net. > > Anyway you'll find patch (code + tests) here : > - http://www.adoy.net/php/remove-magic-quotes.txt > - http://www.adoy.net/php/remove-magic-quotes-tests.txt > > Pierrick > > > > […] > -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org --- ## #54117 — Richard Quadling — 2011-07-21T09:30:21+00:00 URL: https://externals.io/message/54111#54117 · In reply to: #54116 > hi Pierrick! > > Thanks for the updated patch :) > > Now the only question remaining is which level warning we should use > for the setter. I'm happy with E_CORE. Objections? > Baited breath .... I've got the champagne on ice ... so long mq! -- Richard Quadling Twitter : EE : Zend : PHPDoc @RQuadling : e-e.com/M_248814.html : bit.ly/9O8vFY : bit.ly/lFnVea --- ## #54118 — Pierrick Charron — 2011-07-21T10:28:59+00:00 URL: https://externals.io/message/54111#54118 · In reply to: #54116 I'm also ok with E_CORE. Pierrick > hi Pierrick! > > Thanks for the updated patch :) > > Now the only question remaining is which level warning we should use > for the setter. I'm happy with E_CORE. Objections? > > > > […] > > > > -- > Pierre > > @pierrejoye | http://blog.thepimp.net | http://www.libgd.org --- ## #54119 — Gwynne Raskind — 2011-07-21T10:31:33+00:00 URL: https://externals.io/message/54111#54119 · In reply to: #54118 +1 to E_CORE. -- Gwynne > I'm also ok with E_CORE. > > Pierrick > > > > […] --- ## #54120 — Paul Dragoonis — 2011-07-21T10:46:29+00:00 URL: https://externals.io/message/54111#54120 · In reply to: #54119 On Thu, Jul 21, 2011 at 11:31 AM, Gwynne Raskind wrote: > +1 to E_CORE. No objections against it, so +1 E_CORE > > -- Gwynne > > > > > > […] --- ## #54121 — Keloran — 2011-07-21T11:51:27+00:00 URL: https://externals.io/message/54111#54121 · In reply to: #54120 +1 E_CORE On Thu, Jul 21, 2011 at 11:46 AM, Paul Dragoonis wrote: > On Thu, Jul 21, 2011 at 11:31 AM, Gwynne Raskind > wrote: > > […] > > No objections against it, so +1 E_CORE > > > […] > wrote: > > […] > pierrick@webstart.fr> wrote: > > […] > quotes. > > […] > :): > > […] --- ## #54122 — Adam Harvey — 2011-07-21T16:54:33+00:00 URL: https://externals.io/message/54111#54122 · In reply to: #54116 > Now the only question remaining is which level warning we should use > for the setter. I'm happy with E_CORE. Objections? None here. +1 for `E_CORE_ERROR` — it's exactly what it's for. Adam --- ## #54127 — Pierre Joye — 2011-07-22T11:30:06+00:00 URL: https://externals.io/message/54111#54127 · In reply to: #54122 patch applied to trunk and 5.4, had to resist not to apply it to 5.3 :D > > > […] > > None here. +1 for `E_CORE_ERROR` — it's exactly what it's for. > > Adam > -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org --- ## #54128 — Richard Quadling — 2011-07-22T11:33:17+00:00 URL: https://externals.io/message/54111#54128 · In reply to: #54127 > patch applied to trunk and 5.4, had to resist not to apply it to 5.3 :D As the great collective once said, Resistance is futile. Surrender to your inner-borg. -- Richard Quadling Twitter : EE : Zend : PHPDoc @RQuadling : e-e.com/M_248814.html : bit.ly/9O8vFY : bit.ly/lFnVea