# [PATCH] mbstring warning fixes

- Thread: https://externals.io/message/5339
- Original archive: https://news-web.php.net/php.internals/5339
- Started by Joe Orton on 2003-11-11T15:45:35+00:00
- Messages: 2
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #5339 — Joe Orton — 2003-11-11T15:45:35+00:00

URL: https://externals.io/message/5339#5339

4.3/ext/mbstring/mbstring.c: In function `php_mb_gpc_encoding_converter':
4.3/ext/mbstring/mbstring.c:3729: warning: `ret' might be used uninitialized in this function
4.3/ext/mbstring/mbstring.c: In function `php_mb_gpc_encoding_detector':
4.3/ext/mbstring/mbstring.c:3792: warning: `encoding' might be used uninitialized in this function

I'm not sure what the right fixes are here, e.g. below makes the
warnings go away...

Index: ext/mbstring/mbstring.c
===================================================================
RCS file: /repository/php-src/ext/mbstring/mbstring.c,v
retrieving revision 1.142.2.37
diff -u -r1.142.2.37 mbstring.c
--- ext/mbstring/mbstring.c	6 Nov 2003 15:41:36 -0000	1.142.2.37
+++ ext/mbstring/mbstring.c	11 Nov 2003 15:41:27 -0000
@@ -3726,7 +3726,7 @@
 		TSRMLS_DC)
 {
 	int i;
-	mbfl_string string, result, *ret;
+	mbfl_string string, result, *ret = NULL;
 	enum mbfl_no_encoding from_encoding, to_encoding;
 	mbfl_buffer_converter *convd;
 
@@ -3789,7 +3789,7 @@
 {
 	mbfl_string string;
 	enum mbfl_no_encoding *elist;
-	enum mbfl_no_encoding encoding;
+	enum mbfl_no_encoding encoding = mbfl_no_encoding_invalid;
 	mbfl_encoding_detector *identd = NULL; 
 
 	int size, *list;

---

## #5356 — Rui Hirokawa — 2003-11-11T22:20:17+00:00

URL: https://externals.io/message/5339#5356 · In reply to: #5339

Thank you for sending patch.
I applied your first patch to cvs, but, the second change 
was already applied in cvs.

Rui

On Tue, 11 Nov 2003 15:45:35 +0000
Joe Orton <jorton@redhat.com> wrote:

> 4.3/ext/mbstring/mbstring.c: In function `php_mb_gpc_encoding_converter':
> 4.3/ext/mbstring/mbstring.c:3729: warning: `ret' might be used uninitialized in this function
> 4.3/ext/mbstring/mbstring.c: In function `php_mb_gpc_encoding_detector':
> 4.3/ext/mbstring/mbstring.c:3792: warning: `encoding' might be used uninitialized in this function
> 
> I'm not sure what the right fixes are here, e.g. below makes the
> warnings go away...
> 
> Index: ext/mbstring/mbstring.c
> ===================================================================
> RCS file: /repository/php-src/ext/mbstring/mbstring.c,v
> retrieving revision 1.142.2.37
> diff -u -r1.142.2.37 mbstring.c
> --- ext/mbstring/mbstring.c	6 Nov 2003 15:41:36 -0000	1.142.2.37
> +++ ext/mbstring/mbstring.c	11 Nov 2003 15:41:27 -0000
> @@ -3726,7 +3726,7 @@
>  		TSRMLS_DC)
>  {
>  	int i;
> -	mbfl_string string, result, *ret;
> +	mbfl_string string, result, *ret = NULL;
>  	enum mbfl_no_encoding from_encoding, to_encoding;
>  	mbfl_buffer_converter *convd;
>  
> @@ -3789,7 +3789,7 @@
>  {
>  	mbfl_string string;
>  	enum mbfl_no_encoding *elist;
> -	enum mbfl_no_encoding encoding;
> +	enum mbfl_no_encoding encoding = mbfl_no_encoding_invalid;
>  	mbfl_encoding_detector *identd = NULL; 
>  
>  	int size, *list;


-- 
Rui Hirokawa <rui_hirokawa@ybb.ne.jp