# [Patch] GeoIP Tests

- Thread: https://externals.io/message/53029
- Original archive: https://news-web.php.net/php.internals/53029
- Started by Mike Willbanks on 2011-06-06T14:37:09+00:00
- Messages: 2
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #53029 — Mike Willbanks — 2011-06-06T14:37:09+00:00

URL: https://externals.io/message/53029#53029

I've gone through the GeoIP extension and ensured all of the tests now pass.

Bug Report: http://pecl.php.net/bugs/bug.php?id=22749
Patch File: http://blog.digitalstruct.com/patches/geoip-svn-tests.patch.txt

Also, it looks like the GeoIP extension is based on an extremely old
version, I am going to start looking to update this to get all of the new
constants that should exist into the extension.
A slight amount of behavior changed and should have been noted previously
for the test as "CA" is no longer a valid country code w/o a region in the
timeZone.c area of the GeoIP C API.

Someone with karma want to review and apply the patch for the tests?

Regards,

Mike

---

## #53030 — Pierre Joye — 2011-06-06T14:38:36+00:00

URL: https://externals.io/message/53029#53030 · In reply to: #53029

hi,

please use pecl-dev to talk about pecl's packages.

Thanks for your work!


> I've gone through the GeoIP extension and ensured all of the tests now pass.
>
> Bug Report: http://pecl.php.net/bugs/bug.php?id=22749
> Patch File: http://blog.digitalstruct.com/patches/geoip-svn-tests.patch.txt
>
> Also, it looks like the GeoIP extension is based on an extremely old
> version, I am going to start looking to update this to get all of the new
> constants that should exist into the extension.
> A slight amount of behavior changed and should have been noted previously
> for the test as "CA" is no longer a valid country code w/o a region in the
> timeZone.c area of the GeoIP C API.
>
> Someone with karma want to review and apply the patch for the tests?
>
> Regards,
>
> Mike
>



-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org