# patch review

- Thread: https://externals.io/message/51801
- Original archive: https://news-web.php.net/php.internals/51801
- Started by tbrasta@gmail.com on 2011-04-03T10:58:07+00:00
- Messages: 5
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #51801 — tbrasta@gmail.com — 2011-04-03T10:58:07+00:00

URL: https://externals.io/message/51801#51801

Hi,

can somebody review the following patch:
http://bugs.php.net/bug.php?id=54369

I am willing the bug is fixed in the next PHP release and ready to do a
job if something is wrong with the patch.

Thank you

Regards,
Tomas

---

## #51803 — Peter Beverloo — 2011-04-03T11:30:06+00:00

URL: https://externals.io/message/51801#51803 · In reply to: #51801

2011/4/3 Tomas Brastavičius <tbrasta@gmail.com>:
> Hi,
>
> can somebody review the following patch:
> http://bugs.php.net/bug.php?id=54369
>
> I am willing the bug is fixed in the next PHP release and ready to do a
> job if something is wrong with the patch.
>
> Thank you
>
> Regards,
> Tomas
>
>
> --
> 
> 
>

The parsing change you are proposing is invalid per RFC 1738.  The
destination (hostname and port) and the url-path are to be divided by
a slash, whereas the query string and the fragment are part of the
latter.

See sections 3.3 and 5 of the RFC[1] for more information.  Web
browsers and other user-facing software may accept this, but will
immediately update the displayed URL to a valid variant by inserting
the slash.

Regards,
Peter Beverloo

[1] http://tools.ietf.org/html/rfc1738.html

---

## #51804 — Pascal COURTOIS — 2011-04-03T11:41:19+00:00

URL: https://externals.io/message/51801#51804 · In reply to: #51803

Le 03/04/2011 13:30, Peter Beverloo a écrit :
 
> The parsing change you are proposing is invalid per RFC 1738.  

  RFC 1738 has been obsoleted by RFC 3986

http://tools.ietf.org/html/rfc3986

---

## #51805 — Tomas Kuliavas — 2011-04-03T12:07:52+00:00

URL: https://externals.io/message/51801#51805 · In reply to: #51801

2011.04.03 13:58 Tomas Brastavičius rašė:
> Hi,
>
> can somebody review the following patch:
> http://bugs.php.net/bug.php?id=54369
>
> I am willing the bug is fixed in the next PHP release and ready to do a
> job if something is wrong with the patch.

Check url encoding documentation first.
http://en.wikipedia.org/wiki/Percent-encoding

Then fix your $url value

---

## #51806 — Pierre Joye — 2011-04-03T12:18:43+00:00

URL: https://externals.io/message/51801#51806 · In reply to: #51805

Please post relevant comments and information to the bug report
directly. It will make our work and review easier.

Thanks,

On Sun, Apr 3, 2011 at 2:07 PM, Tomas Kuliavas
<tokul@users.sourceforge.net> wrote:
> 2011.04.03 13:58 Tomas Brastavičius rašė:
> > […]
>
> Check url encoding documentation first.
> http://en.wikipedia.org/wiki/Percent-encoding
>
> Then fix your $url value
>
>
> --
> 
> 
>
>



-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org