# path for #39863 etc. in trunk?

- Thread: https://externals.io/message/51581
- Original archive: https://news-web.php.net/php.internals/51581
- Started by Stas Malyshev on 2011-03-07T01:14:07+00:00
- Messages: 4
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #51581 — Stas Malyshev — 2011-03-07T01:14:07+00:00

URL: https://externals.io/message/51581#51581

Hi!

What's the status of patch for NULL-in-filename issue for trunk? I see 
patch for 5.3 was made by Pierre 3.5 months ago with note "trunk will 
have patch later", but nothing happened as it seems. Anybody's working 
on it?
-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

---

## #51584 — Pierre Joye — 2011-03-07T06:46:26+00:00

URL: https://externals.io/message/51581#51584 · In reply to: #51581

hi Stas,

Yes, there was a discussion in progress about adding or not a input
parameter for filenames to do all the checks. That's the only stopping
point back then (in January afair). I will check&post again the
question and proposal to see if we can get that sorted now.

Cheers,


> Hi!
>
> What's the status of patch for NULL-in-filename issue for trunk? I see patch
> for 5.3 was made by Pierre 3.5 months ago with note "trunk will have patch
> later", but nothing happened as it seems. Anybody's working on it?
> --
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227
>



-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

---

## #51585 — Stas Malyshev — 2011-03-07T07:03:59+00:00

URL: https://externals.io/message/51581#51585 · In reply to: #51584

Hi!

> Yes, there was a discussion in progress about adding or not a input
> parameter for filenames to do all the checks. That's the only stopping
> point back then (in January afair). I will check&post again the
> question and proposal to see if we can get that sorted now.

If there are questions about better implementation etc., we have to just 
check in the 5.3 fix and we can refactor it later. I think it's not good 
that we allow trunk to have security-related patch not synchronized with 
5.3 for months. I wonder if we have more like this.
-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

---

## #51586 — Pierre Joye — 2011-03-07T07:36:14+00:00

URL: https://externals.io/message/51581#51586

It was not about a better implentation, such changes are not possible in
5.3.

The goal is to avoid many code duplication and makes sure than any new code
has this check in place.

I can't think of any other similar patches not present in trunk.


Hi!



> Yes, there was a discussion in progress about adding or not a input
> parameter for filenames to...
If there are questions about better implementation etc., we have to just
check in the 5.3 fix and we can refactor it later. I think it's not good
that we allow trunk to have security-related patch not synchronized with 5.3
for months. I wonder if we have more like this.
-- 

Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227