# [PATCH][ZE2] zend_highlight.c <font> change

- Thread: https://externals.io/message/5048
- Original archive: https://news-web.php.net/php.internals/5048
- Started by GPHemsley@aol.com on 2003-10-28T20:10:48+00:00
- Messages: 2
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #5048 — GPHemsley@aol.com — 2003-10-28T20:10:48+00:00

URL: https://externals.io/message/5048#5048

In your diff, you have this line: + zend_printf("<span style=\"color: 
%s\";>\n", last_color); 

There's a semicolon (;) in the <span> tag (marked in red, if available). If 
that was meant to be part of the style attribute (like style=\"color: %s;\">), 
then it is in the wrong place. And also, if that is the place it's supposed to 
be, then you missed one on the +    zend_printf("<span style=\"color: %s\">", 
last_color); line.

If I'm wrong, forgive me.

Sincerely, 
Gordon Hemsley

---

## #5053 — Lisa Seelye — 2003-10-28T22:29:30+00:00

URL: https://externals.io/message/5048#5053 · In reply to: #5048

> In your diff, you have this line: + zend_printf("<span style=\"color:
> %s\";>\n", last_color);
>  
> There's a semicolon (;) in the <span> tag (marked in red, if
> available). If that was meant to be part of the style attribute (like
> style=\"color: %s;\">), then it is in the wrong place. And also, if
> that is the place it's supposed to be, then you missed one on
> the +    zend_printf("<span style=\"color: %s\">", last_color); line.

Yes quite right on missing the last semicolon.

Truly having it there or not is personal preference.  My preference is
to use semicolons at the end of each style definition, but since in this
context the user can't add any additional styles then it makes sense to
omit it.

-- 
Regards,
-Lisa
<Vix ulla tam iniqua pax, quin bello vel aequissimo sit potior