# [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/standard/file.c branches/PHP_5_3/ext/standard/file.h branches/PHP_5_3/ext/standard/ftp_fopen_wrapper.c branches/PHP_5_3/ext/standard/http_fopen_wrapper.c branch

- Thread: https://externals.io/message/50013
- Original archive: https://news-web.php.net/php.internals/50013
- Started by Pierre Joye on 2010-10-30T15:56:36+00:00
- Messages: 2
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #50013 — Pierre Joye — 2010-10-30T15:56:36+00:00

URL: https://externals.io/message/50013#50013

hi,


> The From: header is actually valid in http (see section 14.21 of RFC 2616) and is appropriately used in PHP, as it is.
>
> Yes, this should arguably be a context option for http/ftp wrappers, though one could argue it's a global setting that happens to reflect on those wrappers.
>
> In any case, that is a matter outside the realm of bug fixing; I merely made the ini setting that currently exists work correctly.
>
> Sorry for the top posting.

This directive is documented only to be used with FTP.


Yes it would be nice to fully support the HTTP RFC, but not by making
this implementation more ugly. Also new features should go to trunk.

I  suggest to actually fix the reported bug and do the right changes
and additions in trunk.

Cheers,
-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

---

## #50014 — Gustavo Lopes — 2010-10-30T16:14:04+00:00

URL: https://externals.io/message/50013#50014 · In reply to: #50013

On Sat, 30 Oct 2010 16:56:36 +0100, Pierre Joye <pierre.php@gmail.com>  
wrote:

> This directive is documented only to be used with FTP.

The documentation was wrong, and has also been fixed. According to the bug  
report, this directive has been used for http for the last 8 years.

>
> Yes it would be nice to fully support the HTTP RFC, but not by making
> this implementation more ugly. Also new features should go to trunk.
>
> I  suggest to actually fix the reported bug and do the right changes
> and additions in trunk.
>

I repeat, there were no additions here. The only bug in that report was  
that cfg_get_string was being used to retrieve the value of the ini  
directive, which is wrong because then PHP doesn't know anything about the  
directive expect by putting it in the hash table that results from ini  
parsing.

In particular, ini_set cannot then be used to change the value of the  
directive through the script.

In fact, after removing these usages of cfg_get_string, only two usages  
remain in php-src, both in PDO.

Regards

-- 
Gustavo Lopes