# PDO DBLIB Release Candidate? - Thread: https://externals.io/message/48994 - Original archive: https://news-web.php.net/php.internals/48994 - Started by Stanley Sufficool on 2010-07-02T14:11:43+00:00 - Messages: 11 - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #48994 — Stanley Sufficool — 2010-07-02T14:11:43+00:00 URL: https://externals.io/message/48994#48994 Can I get an affirmation if the pdo dblib code will be accepted in 5.2 and 5.3 branches? --- ## #48995 — Kalle Sommer Nielsen — 2010-07-02T14:16:39+00:00 URL: https://externals.io/message/48994#48995 · In reply to: #48994 Hi Stanley 2010/7/2 Stanley Sufficool : > Can I get an affirmation if the pdo dblib code will be accepted in 5.2 > and 5.3 branches? You need to talk to each of the release masters for this. If the merges contains new features then it shouldn't go into 5.2, like the LastInsertId you recently did. For 5.3 its a possibility if Johannes agrees on it, I looked at the commits and I think they would be fit for 5.3. -- regards, Kalle Sommer Nielsen kalle@php.net --- ## #48996 — Pierre Joye — 2010-07-02T14:19:23+00:00 URL: https://externals.io/message/48994#48996 · In reply to: #48994 hi, For current releases, I don't think we should. The 2nd RCs have released yesterday and it would really rock we can get the final out asap (I suspect we may need one more RC...). Cheers, > Can I get an affirmation if the pdo dblib code will be accepted in 5.2 > and 5.3 branches? > > -- > PDO Working Group Mailing List (http://pdo.php.net) > > > -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org --- ## #48998 — Christopher Jones — 2010-07-02T15:45:08+00:00 URL: https://externals.io/message/48994#48998 · In reply to: #48994 > Can I get an affirmation if the pdo dblib code will be accepted in 5.2 > and 5.3 branches? > It shouldn't go into 5.2 if it introduces new functionality. You might backport the crash/leak bug fixes if Ilia is OK with that. Depending if how compatible (UI + protocol) it is with 5.3, then Johannes may accept it into 5.3.4. I'm concerned that recent PDO changes (including Ilia's merge of inTransaction() for Postgres) haven't been documented. Lack of accurate documentation won't help the consistency of further PDO driver changes. Chris -- Email: christopher.jones@oracle.com Tel: +1 650 506 8630 Blog: http://blogs.oracle.com/opal/ Free PHP Book: http://tinyurl.com/ugpomhome --- ## #48999 — Stanley Sufficool — 2010-07-03T18:40:55+00:00 URL: https://externals.io/message/48994#48999 · In reply to: #48998 On Fri, Jul 2, 2010 at 8:45 AM, Christopher Jones wrote: > > > > > […] > > It shouldn't go into 5.2 if it introduces new functionality.  You > might backport the crash/leak bug fixes if Ilia is OK with that. Patches for the OOM for 5.2 and 5.3 are attached to BUG #50755 http://bugs.php.net/bug.php?id=50755 There has been feedback on this bug that indicates other are needing this fix as well. This prevents people from developing bigger applications on non-MS Platforms to support SQL Server and Sybase. I would argue that the additional fixes in trunk fix bugs rather than introducing new functionality since they were already in the PDO specification and they do not break BC. I do not see why this would be held out of releases. This passes *most* PDO tests and passes other tests in ext/pdo_dblib/tests. The PDO tests that fail, AFAIK have always failed. FWIW, Microsoft has a monopoly on a fully functional PDO mssql driver which is only implemented on MS platforms. If we want portability of PHP applications, then the PDO DBLIB driver must be fully functional on releases. BTW, This extension is experimental and subject to change. Well it did, and they were warned. Happy Independence Day, Stan > > Depending if how compatible (UI + protocol) it is with 5.3, then > Johannes may accept it into 5.3.4. > > I'm concerned that recent PDO changes (including Ilia's merge of > inTransaction() for Postgres) haven't been documented.  Lack of > accurate documentation won't help the consistency of further PDO > driver changes. > > Chris > > -- > Email: christopher.jones@oracle.com > Tel:  +1 650 506 8630 > Blog:  http://blogs.oracle.com/opal/ > Free PHP Book: http://tinyurl.com/ugpomhome --- ## #49000 — Pierre Joye — 2010-07-03T20:07:20+00:00 URL: https://externals.io/message/48994#49000 · In reply to: #48999 hi, > I would argue that the additional fixes in trunk fix bugs rather than > introducing new functionality since they were already in the PDO > specification and they do not break BC. I do not see why this would be > held out of releases. They should, only not right now in 5.3.3/5.2.14 as we are in the second release candidates. The reasons why we should not begin to apply dozen of patches at this stage are rather obvious, hopefully :). > FWIW, Microsoft has a monopoly on a fully functional PDO mssql driver > which is only implemented on MS platforms. If we want portability of > PHP applications, then the PDO DBLIB driver must be fully functional > on releases. That's not correct. PHP 5.3+ has no SqlServer support on Windows. The SqlSrv driver is more than welcome as it solves this problem. The PDO support is still beta (CTP2). However all other platforms do have SqlServer support by default in the core. > BTW, This extension is experimental and subject to change. Well it > did, and they were warned. Hence the worries? :) -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org --- ## #49001 — Stanley Sufficool — 2010-07-04T02:47:43+00:00 URL: https://externals.io/message/48994#49001 · In reply to: #49000 > hi, > > > > > […] > > They should, only not right now in 5.3.3/5.2.14 as we are in the > second release candidates. The reasons why we should not begin to > apply dozen of patches at this stage are rather obvious, hopefully :). > Got it. Thanks. > > > […] > > That's not correct. PHP 5.3+ has no SqlServer support on Windows. The > SqlSrv driver is more than welcome as it solves this problem. The PDO > support is still beta (CTP2). However all other platforms do have > SqlServer support by default in the core. Sorry, I was incorrect, the Microsoft PDO SqlServer is still in release candidate stages. I'm just hoping to have an on-par PDO implementation available on all platforms before everyone starts coding for the platform dependent driver. > > > […] > > Hence the worries? :) I am saying that this extension on the PHP doc pages is marked as experimental and as such the users should not expect the behavior to stay consistent. But none-the-less, the patches do not affect any _existing_ behavior. So no worries. :) > > -- > Pierre > > @pierrejoye | http://blog.thepimp.net | http://www.libgd.org --- ## #49002 — Pierre Joye — 2010-07-04T15:37:10+00:00 URL: https://externals.io/message/48994#49002 · In reply to: #49001 > > […] > > Sorry, I was incorrect, the Microsoft PDO SqlServer is still in > release candidate stages. I'm just hoping to have an on-par PDO > implementation available on all platforms before everyone starts > coding for the platform dependent driver. It does not matter for PDO. They have the same API and the queries should be the same. A couple of features may not work in the same way, mainly the auth parts. It is however the case for the sqlsrv driver API (non PDO). But even in this case the API is very close to what we have in mssql, only with less bugs ;) Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org --- ## #49006 — johannes@schlueters.de — 2010-07-06T08:08:58+00:00 URL: https://externals.io/message/48994#49006 · In reply to: #48994 > Can I get an affirmation if the pdo dblib code will be accepted in 5.2 > and 5.3 branches? In general bug fixes should go to all active branches. Right now these are 5.2, 5.3 and trunk. Right now 5.2 and 5.3 are in RC so only "critical" stuff should go in. Afaik this will be the last "regular" 5.2 release only followed only by security related releases from that branch, but that's up to Ilia. Now the question is about the definition for "critical" stuff, in doubt that has to be decided by the extension maintainer and the RMs case by case. (how critical is the issue for users? how complex(=risky) is the patch? ...) According to the EXTENSIONS file pdo_dblib isn't maintained right now so thank you for volunteering to take over that role. johannes --- ## #49029 — Ilia Alshanetsky — 2010-07-11T14:54:14+00:00 URL: https://externals.io/message/48994#49029 · In reply to: #48994 PHP 5.2 branch is really for bug fixes only, so new functionality should be introduced into it. > Can I get an affirmation if the pdo dblib code will be accepted in 5.2 > and 5.3 branches? --- ## #49030 — Pierre Joye — 2010-07-11T16:26:12+00:00 URL: https://externals.io/message/48994#49030 · In reply to: #49029 > PHP 5.2 branch is really for bug fixes only, so new functionality > should be introduced into it. +not :) -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org