# Newbie contributor question, nmake test will not run my patch - Thread: https://externals.io/message/47790 - Original archive: https://news-web.php.net/php.internals/47790 - Started by Justin Dearing on 2010-04-05T17:01:05+00:00 - Messages: 4 - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #47790 — Justin Dearing — 2010-04-05T17:01:05+00:00 URL: https://externals.io/message/47790#47790 Hi, So I wrote a test for bug 50698 (http://bugs.php.net/bug.php?id=50698), but it doesn't show up in the test output when i run nmake test. I don't see anything on the QA site about what to do to make a test run. I placed it in the right directory and named it right as far as I can tell. What am I doing wrong and where is the link explaining what I am doing wrong? Justin --- ## #47791 — Pierre Joye — 2010-04-05T17:08:17+00:00 URL: https://externals.io/message/47790#47791 · In reply to: #47790 hi, What do you mean by "does not show up"? to run tests, use: php run-test.php [options, use -h to see all options] ext/soap/tests Cheers, > Hi, > > So I wrote a test for bug 50698 (http://bugs.php.net/bug.php?id=50698), but > it doesn't show up in the test output when i run nmake test. I don't see > anything on the QA site about what to do to make a test run. I placed it in > the right directory and named it right as far as I can tell. > > What am I doing wrong and where is the link explaining what I am doing > wrong? > > Justin > -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org --- ## #47792 — Pierre Joye — 2010-04-05T17:08:27+00:00 URL: https://externals.io/message/47790#47792 · In reply to: #47790 hi, What do you mean by "does not show up"? to run tests, use: php run-test.php [options, use -h to see all options] ext/soap/tests Cheers, > Hi, > > So I wrote a test for bug 50698 (http://bugs.php.net/bug.php?id=50698), but > it doesn't show up in the test output when i run nmake test. I don't see > anything on the QA site about what to do to make a test run. I placed it in > the right directory and named it right as far as I can tell. > > What am I doing wrong and where is the link explaining what I am doing > wrong? > > Justin > -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org --- ## #47796 — Justin Dearing — 2010-04-05T20:57:04+00:00 URL: https://externals.io/message/47790#47796 I did not hit "reply-all" ---------- Forwarded message ---------- From: Justin Dearing Date: Mon, Apr 5, 2010 at 4:50 PM Subject: Re: [PHP-DEV] Newbie contributor question, nmake test will not run my patch To: Pierre Joye Pierre, Thank you for your reply. Allow me to clarify. I meant that I ran "nmake test," saved the output, opened it in a text editor and found no mention of bug50698.phpt. I then ran run-tests.php directly as you suggested, and saved the output to a html file. In that html file it said the test was skipped because the copy of PHP.exe did nto have CGI support. I reran configure, recompiled and ran run-tests.php one more time. This time the test passed. However, when I reran "nmake test" there was still no mention of bug50698.phpt in the build output. I opened the makefile and the only action for target tests: is: "$(BUILD_DIR)\php.exe" -d open_basedir= -d output_buffering=0 run-tests.php $(TESTS) -p "$(BUILD_DIR)\php.exe" I could not determine what set $(TESTS) so I used (http://processhacker( processhacker.sf.net) to get the command line arguments of the running PHP process. It was: Debug_TS\php.exe -d open_basedir= -d output_buffering=0 run-tests.php -p "Debug_TS\php.exe" So I don't understand why some tests are getting skipped, or not mentioned in the log file at least. To determine if its a logging problem I am currently running php.exe -d open_basedir= -d output_buffering=0 run-tests.php -p "Debug_TS\php.exe" --html nmake-test-report.html on my machine. Its a pentium IV so it will take a while I will report the results when it is done. Justin > hi, > > What do you mean by "does not show up"? > > to run tests, use: > > php run-test.php [options, use -h to see all options] ext/soap/tests > > Cheers, > > On Mon, Apr 5, 2010 at 7:01 PM, Justin Dearing > wrote: > > […] > but > > […] > in > > […] > > > > -- > Pierre > > @pierrejoye | http://blog.thepimp.net | http://www.libgd.org