# HEAD tests

- Thread: https://externals.io/message/45273
- Original archive: https://news-web.php.net/php.internals/45273
- Started by Stanislav Malyshev on 2009-08-13T19:57:46+00:00
- Messages: 3
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #45273 — Stanislav Malyshev — 2009-08-13T19:57:46+00:00

URL: https://externals.io/message/45273#45273

Hi!

I was recently working on fixing some things in HEAD in 
ext/standard/strings.c and when I tried to run tests to check if my 
fixes are OK I discovered that huge amount of strings tests now fail - 
out of ~800 tests we have 420 fails! Most of them seem to be some 
trivial matters like string/unicode mismatch or different error message 
syntax but this thing makes the tests totally useless, as it is 
impossible to verify fixes against them.
Is someone going to fix it?
-- 
Stanislav Malyshev, Zend Software Architect
stas@zend.com   http://www.zend.com/
(408)253-8829   MSN: stas@zend.com

---

## #45274 — Rasmus Lerdorf — 2009-08-13T22:22:10+00:00

URL: https://externals.io/message/45273#45274 · In reply to: #45273

Stanislav Malyshev wrote:
> I was recently working on fixing some things in HEAD in
> ext/standard/strings.c and when I tried to run tests to check if my
> fixes are OK I discovered that huge amount of strings tests now fail -
> out of ~800 tests we have 420 fails! Most of them seem to be some
> trivial matters like string/unicode mismatch or different error message
> syntax but this thing makes the tests totally useless, as it is
> impossible to verify fixes against them.
> Is someone going to fix it?

I have actually been fixing tests, so this surprised me.  I checked with
Stas on irc and it turned out to be a case of user error on his part :)
We don't have 420 failed string tests in HEAD.  We still have 22 though,
plus a number of borked tests due to charset issues, so please pitch in
and work on these.

-Rasmus

---

## #45275 — Stanislav Malyshev — 2009-08-13T23:08:53+00:00

URL: https://externals.io/message/45273#45275 · In reply to: #45274

Hi!

> I have actually been fixing tests, so this surprised me.  I checked with
> Stas on irc and it turned out to be a case of user error on his part :)
> We don't have 420 failed string tests in HEAD.  We still have 22 though,
> plus a number of borked tests due to charset issues, so please pitch in
> and work on these.

Yes, you are right, it was my broken setup, sorry :( With setup fixed, 
amount of broken tests back to normal.
-- 
Stanislav Malyshev, Zend Software Architect
stas@zend.com   http://www.zend.com/
(408)253-8829   MSN: stas@zend.com