# Tests contributions

- Thread: https://externals.io/message/45035
- Original archive: https://news-web.php.net/php.internals/45035
- Started by Patrick ALLAERT on 2009-07-20T08:09:27+00:00
- Messages: 6
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #45035 — Patrick ALLAERT — 2009-07-20T08:09:27+00:00

URL: https://externals.io/message/45035#45035

Hi lists,

Running many "make test" on different platforms (including Solaris and
OpenVMS), I'd like to contribute a little bit more than my karma let
me do.
For now, I have access to php-src/ext/ldap only, however I'd like to
backport changes in phpt files that have been done in HEAD and/or
PHP_5_3 to PHP_5_2.

One example of this is backporting r265951:
http://svn.php.net/viewvc?view=revision&revision=265951

Would you agree granting me access to */tests so that I can improve
testability of PHP_5_2?

Thanks,

-- 
Patrick Allaert
---
http://code.google.com/p/peclapm/ - Alternative PHP Monitor

---

## #45036 — Pierre Joye — 2009-07-20T09:13:09+00:00

URL: https://externals.io/message/45035#45036 · In reply to: #45035

hi,

Please remember me your username :)

Cheers,

On Mon, Jul 20, 2009 at 10:09 AM, Patrick
ALLAERT<patrick.allaert@gmail.com> wrote:
> Hi lists,
>
> Running many "make test" on different platforms (including Solaris and
> OpenVMS), I'd like to contribute a little bit more than my karma let
> me do.
> For now, I have access to php-src/ext/ldap only, however I'd like to
> backport changes in phpt files that have been done in HEAD and/or
> PHP_5_3 to PHP_5_2.
>
> One example of this is backporting r265951:
> http://svn.php.net/viewvc?view=revision&revision=265951
>
> Would you agree granting me access to */tests so that I can improve
> testability of PHP_5_2?
>
> Thanks,
>
> --
> Patrick Allaert
> ---
> http://code.google.com/p/peclapm/ - Alternative PHP Monitor
>
> --
> 
> 
>
>



-- 
Pierre

http://blog.thepimp.net | http://www.libgd.org

---

## #45039 — Hannes Magnusson — 2009-07-20T10:10:22+00:00

URL: https://externals.io/message/45035#45039 · In reply to: #45036

> hi,
>
> Please remember me your username :)

patrickallaert

-Hannes

---

## #45040 — Pierre Joye — 2009-07-20T10:20:53+00:00

URL: https://externals.io/message/45035#45040 · In reply to: #45035

hi,

On Mon, Jul 20, 2009 at 10:09 AM, Patrick
ALLAERT<patrick.allaert@gmail.com> wrote:
> Hi lists,
>
> Running many "make test" on different platforms (including Solaris and
> OpenVMS), I'd like to contribute a little bit more than my karma let
> me do.
> For now, I have access to php-src/ext/ldap only, however I'd like to
> backport changes in phpt files that have been done in HEAD and/or
> PHP_5_3 to PHP_5_2.
>
> One example of this is backporting r265951:
> http://svn.php.net/viewvc?view=revision&revision=265951
>
> Would you agree granting me access to */tests so that I can improve
> testability of PHP_5_2?

Done (and NEWS too). Also try to commit the tests in all branches at
the same time, see http://news.php.net/php.internals/44993 for a
detailed explanation :)

Cheers,
-- 
Pierre

http://blog.thepimp.net | http://www.libgd.org

---

## #45052 — Patrick ALLAERT — 2009-07-20T15:41:23+00:00

URL: https://externals.io/message/45035#45052 · In reply to: #45040

2009/7/20 Pierre Joye <pierre.php@gmail.com>:
> hi,
>
> On Mon, Jul 20, 2009 at 10:09 AM, Patrick
> ALLAERT<patrick.allaert@gmail.com> wrote:
> > […]
>
> Done (and NEWS too). Also try to commit the tests in all branches at
> the same time, see http://news.php.net/php.internals/44993 for a
> detailed explanation :)

Thanks Pierre,

Concerning Rasmus' method, I agree, but partially.

Merge shouldn't be done with something else than "svn merge" or a
frontend to it, SVN having merge tracking since v1.5 we shoudn't use
plain diff/patch when the operation could be done 100% natively. Ok
otherwise.

MFH/MFB should be avoided and native tracking through svn:mergeinfo
should be promoted. Mixing the two will lead to not taking the benefit
of SVN against CVS IMHO.

My best practices:
1) commit to HEAD.
2) "svn merge" for every supported branches.
3) one single commit for all the branches as Rasmus explained.

Doesn't need any fancy tool or frontend, 100% native and tracking included.

To be validated by RM's maybe ? :-)

Patrick

---

## #45053 — Pierre Joye — 2009-07-20T15:43:38+00:00

URL: https://externals.io/message/45035#45053 · In reply to: #45052

On Mon, Jul 20, 2009 at 5:41 PM, Patrick
ALLAERT<patrick.allaert@gmail.com> wrote:
> 2009/7/20 Pierre Joye <pierre.php@gmail.com>:
> > […]
>
> Thanks Pierre,

> 3) one single commit for all the branches as Rasmus explained.

That's what matters :)

Cheers,
-- 
Pierre

http://blog.thepimp.net | http://www.libgd.org
