# Removing zend_hash_func in PHP 6.0 - Thread: https://externals.io/message/44062 - Original archive: https://news-web.php.net/php.internals/44062 - Started by David Soria Parra on 2009-05-26T12:13:39+00:00 - Messages: 8 - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #44062 — David Soria Parra — 2009-05-26T12:13:39+00:00 URL: https://externals.io/message/44062#44062 Hi List, I recently discovered that zend_hash_func is equal to zend_get_hash_value. To clean this up, I would like to remove zend_hash_func in favor of zend_get_hash in HEAD. If there are no objections I would commit a patch in a few days. David --- ## #44063 — David Coallier — 2009-05-26T12:17:21+00:00 URL: https://externals.io/message/44062#44063 · In reply to: #44062 2009/5/26 David Soria Parra : > Hi List, > > I recently discovered that zend_hash_func is equal to zend_get_hash_value. > To clean this up, I would like to remove zend_hash_func in favor of > zend_get_hash in HEAD. If there are no objections I would commit a patch in > a few days. Did you grep through pecl and the source to make sure it won't break anything? If you did, then I see no problems. -- Slan, David --- ## #44064 — Antony Dovgal — 2009-05-26T12:36:10+00:00 URL: https://externals.io/message/44062#44064 · In reply to: #44062 > Hi List, > > I recently discovered that zend_hash_func is equal to > zend_get_hash_value. To clean this up, I would like to remove > zend_hash_func in favor of zend_get_hash in HEAD. If there are no > objections I would commit a patch in a few days. 12:48 <@tony2001> dsp__: I see no point in removing it completely and breaking BC for no reason 12:48 <@tony2001> you can remove it, but leave a macro to make sure old code still works -- Wbr, Antony Dovgal --- http://pinba.org - realtime statistics for PHP --- ## #44071 — shire — 2009-05-26T23:09:54+00:00 URL: https://externals.io/message/44062#44071 · In reply to: #44064 Antony Dovgal wrote: > > > […] > > 12:48<@tony2001> dsp__: I see no point in removing it completely and breaking BC for no reason > 12:48<@tony2001> you can remove it, but leave a macro to make sure old code still works > I would like to see us clean up items like this as part of the PHP-6 release, part of the list of todo items was to get rid of any bits like this that can be unnecessarily confusing etc. I do think it should be done in a way that deprecates one of the functions, but not the other to make migration easier for extensions (unless we have a compelling reason for a complete rename). -shire --- ## #44092 — crrodriguez@suse.de — 2009-05-29T12:51:16+00:00 URL: https://externals.io/message/44062#44092 · In reply to: #44062 David Soria Parra escribió: > Hi List, > > I recently discovered that zend_hash_func is equal to > zend_get_hash_value. To clean this up, I would like to remove > zend_hash_func in favor of zend_get_hash in HEAD. If there are no > objections I would commit a patch in a few days. We can start with the attached patch and then remove it in the future... -- "If this is the best God can do, I am not impressed" -George Carlin (1937-2008) Cristian Rodríguez R. Software Developer Platform/OpenSUSE - Core Services SUSE LINUX Products GmbH Research & Development http://www.opensuse.org/ --- ## #44095 — shire — 2009-05-29T23:29:55+00:00 URL: https://externals.io/message/44062#44095 · In reply to: #44092 Cristian Rodríguez wrote: > David Soria Parra escribió: > > […] > > We can start with the attached patch and then remove it in the future... Yeah, althoughI would suggest we put this patch as a TODO for php-5.4, and then completely remove it in 6 -shire --- ## #44096 — Lukas Kahwe Smith — 2009-05-29T23:48:17+00:00 URL: https://externals.io/message/44062#44096 · In reply to: #44095 > Cristian Rodríguez wrote: > > […] > > Yeah, althoughI would suggest we put this patch as a TODO for > php-5.4, and then completely remove it in 6 just FYI .. from all i have heard from people, the next version will be 6.0, there might be a 5.4 after 6.0 that back ports some stuff and more importantly adds soem forwards compatibility. but for now lets focus on 6.0 (well after relasing 5.3). regards, Lukas Kahwe Smith mls@pooteeweet.org --- ## #44118 — crrodriguez@suse.de — 2009-06-02T13:37:04+00:00 URL: https://externals.io/message/44062#44118 · In reply to: #44064 > 12:48<@tony2001> you can remove it, but leave a macro to make sure old code still works or just use __attribute__((alias("...."))); ...