# Bug 47468: enabling readline/libedit/pcntl/ncurses with --enable-embed - Thread: https://externals.io/message/43864 - Original archive: https://news-web.php.net/php.internals/43864 - Started by Paul Biggar on 2009-05-06T19:42:10+00:00 - Messages: 7 - Reply by email to internals@lists.php.net - More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt --- ## #43864 — Paul Biggar — 2009-05-06T19:42:10+00:00 URL: https://externals.io/message/43864#43864 Hi folks, Could I get someone to look at http://bugs.php.net/bug.php?id=47468?. It includes a patch which is confirmed to fix the problem. Thanks, Paul -- Paul Biggar paul.biggar@gmail.com --- ## #43872 — Arnaud Le Blanc — 2009-05-08T13:11:59+00:00 URL: https://externals.io/message/43864#43872 · In reply to: #43864 Hi, > Hi folks, > > Could I get someone to look at http://bugs.php.net/bug.php?id=47468?. > It includes a patch which is confirmed to fix the problem. Does the following patch works for you ? (use ./buildconf after applying, then reconfigure). It does the same thing as yours, but moves the decision of allowing "cli" extensions to SAPI's config.m4. Lukas, Johannes, any objection ? Regards, Arnaud --- ## #43873 — Paul Biggar — 2009-05-08T15:12:39+00:00 URL: https://externals.io/message/43864#43873 · In reply to: #43872 Hi Arnaud, Thanks for looking at this. > Does the following patch works for you ? (use ./buildconf after > applying, then reconfigure). It does the same thing as yours, but moves > the decision of allowing "cli" extensions to SAPI's config.m4. I tested this on CVS 5.3 (with the configure command: ./configure --with-readline --enable-embed --enable-maintainer-zts --enable-debug). It applies cleanly, and I checked the readline symbols were present. I have also forwarded it to two of phc's users who reported the bug. I expect they'll be back to me within a day or two, if you prefer to wait for further confirmation. FWIW, I like the new patch better than my hack. However, I don't understand the how it works from the comment (that bit of acinclude is very shoddily documented in general). Thanks again, Paul -- Paul Biggar paul.biggar@gmail.com --- ## #43874 — Arnaud Le Blanc — 2009-05-08T16:00:03+00:00 URL: https://externals.io/message/43864#43874 · In reply to: #43873 > Hi Arnaud, > > Thanks for looking at this. > > > > […] > > I tested this on CVS 5.3 (with the configure command: ./configure > --with-readline --enable-embed --enable-maintainer-zts > --enable-debug). It applies cleanly, and I checked the readline > symbols were present. I have also forwarded it to two of phc's users > who reported the bug. I expect they'll be back to me within a day or > two, if you prefer to wait for further confirmation. > > FWIW, I like the new patch better than my hack. However, I don't > understand the how it works from the comment (that bit of acinclude is > very shoddily documented in general). The build system allows to build two SAPIs at a time: the CLI and a SAPI of choice. Some extensions are irrelevant for webserver SAPIs, so they mark themselves as CLI-only extensions. This allows one to enable these extensions in the CLI without enabling them in the server SAPI. This patch allows a SAPI to mark itself as allowing those extensions. Regards, Arnaud --- ## #43876 — Jani Taskinen — 2009-05-09T00:45:53+00:00 URL: https://externals.io/message/43864#43876 · In reply to: #43874 Arnaud Le Blanc kirjoitti: > > > […] > > The build system allows to build two SAPIs at a time: the CLI and a SAPI > of choice. Some extensions are irrelevant for webserver SAPIs, so they > mark themselves as CLI-only extensions. This allows one to enable these > extensions in the CLI without enabling them in the server SAPI. This > patch allows a SAPI to mark itself as allowing those extensions. I really need to sleep before I read this again, but with a quick look at the patch I couldn't figure what you're fixing and where. :) PLEASE don't commit this before I can check it out. --Jani --- ## #43877 — Arnaud Le Blanc — 2009-05-09T13:30:42+00:00 URL: https://externals.io/message/43864#43877 · In reply to: #43876 > Arnaud Le Blanc kirjoitti: > > […] > > I really need to sleep before I read this again, but with a quick look at the > patch I couldn't figure what you're fixing and where. :) Reproduce code: "./configure --with-readline --enable-embed && make" Expected result: libphp5.so with readline extension builtin Actual result: libphp5.so without readline extension Regards, Arnaud --- ## #43878 — Jani Taskinen — 2009-05-09T20:28:59+00:00 URL: https://externals.io/message/43864#43878 · In reply to: #43877 Arnaud Le Blanc kirjoitti: > > > […] > > Reproduce code: > "./configure --with-readline --enable-embed && make" > > Expected result: > libphp5.so with readline extension builtin > > Actual result: > libphp5.so without readline extension I fixed this the simplest way. Please, KISS with this is better than adding yet-another-parameter to forget. --Jani