# rfc1867.c question

- Thread: https://externals.io/message/43816
- Original archive: https://news-web.php.net/php.internals/43816
- Started by Andrei Zmievski on 2009-04-30T18:40:51+00:00
- Messages: 4
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #43816 — Andrei Zmievski — 2009-04-30T18:40:51+00:00

URL: https://externals.io/message/43816#43816

Why do we have safe_php_register_variable() calls there with `NULL` for track_vars_array? 
The underlying code simply returns if that parameter is NULL. Is it an oversight or some 
legacy stuff?

-Andrei

---

## #43818 — Jani Taskinen — 2009-04-30T20:02:46+00:00

URL: https://externals.io/message/43816#43818 · In reply to: #43816

Andrei Zmievski kirjoitti:
> Why do we have safe_php_register_variable() calls there with `NULL` for 
> track_vars_array? The underlying code simply returns if that parameter 
> is NULL. Is it an oversight or some legacy stuff?

What branch and what lines? I checked PHP_5_2 and as far as I can tell, there is 
no such function that simply returns when passed track_vars_array is NULL..

Maybe HEAD is different, but that branch doesn't even compile so I don't really 
have time for it.. :)

--Jani

---

## #43820 — Andrei Zmievski — 2009-04-30T21:58:27+00:00

URL: https://externals.io/message/43816#43820 · In reply to: #43818

Jani Taskinen wrote:
> What branch and what lines? I checked PHP_5_2 and as far as I can tell, 
> there is no such function that simply returns when passed 
> track_vars_array is NULL..
> 
> Maybe HEAD is different, but that branch doesn't even compile so I don't 
> really have time for it.. :)

I was talking about HEAD. And it compiles just fine.

-Andrei

---

## #43823 — Jani Taskinen — 2009-05-01T17:52:04+00:00

URL: https://externals.io/message/43816#43823 · In reply to: #43820

Andrei Zmievski kirjoitti:
> Jani Taskinen wrote:
> > […]
> 
> I was talking about HEAD. And it compiles just fine.

Ah..and my build problems were caused by ext/intl..disabling that made the build 
work.

--Jani