# Tidying up PDO tests

- Thread: https://externals.io/message/43056
- Original archive: https://news-web.php.net/php.internals/43056
- Started by Lester Caine on 2009-02-15T18:31:51+00:00
- Messages: 3
- Reply by email to internals@lists.php.net
- More for agents: search with https://externals.io/search.md?q={query} · JSON API at https://externals.io/api · documentation at https://externals.io/llms.txt

---

## #43056 — Lester Caine — 2009-02-15T18:31:51+00:00

URL: https://externals.io/message/43056#43056

I've been looking into the failures on
http://gcov.php.net/viewer.php?version=PHP_5_3&func=tests
with relation to the firebird pdo driver, and the first problem that 
needs to be addressed is the SQL differences in order for the different 
drivers to work. I'm seeing specific fixes for some drivers in the 
tests, but how should the fact that PDO does not handle the different 
SQL requirements be addressed in these generic tests?

Obviously the first problem is identifying driver bugs from bugs in the 
tests themselves, in particular the upper/lower case 'defaults', and the 
use of non standard field definitions.

-- 
Lester Caine - G8HFL
-----------------------------
Contact - http://lsces.co.uk/lsces/wiki/?page=contact
L.S.Caine Electronic Services - http://lsces.co.uk
EnquirySolve - http://enquirysolve.com/
Model Engineers Digital Workshop - http://medw.co.uk//
Firebird - http://www.firebirdsql.org/index.php

---

## #43060 — Felipe Pena — 2009-02-16T01:45:38+00:00

URL: https://externals.io/message/43056#43060 · In reply to: #43056

Hi Lester,

Em Dom, 2009-02-15 às 18:31 +0000, Lester Caine escreveu:
> I've been looking into the failures on
> http://gcov.php.net/viewer.php?version=PHP_5_3&func=tests
> with relation to the firebird pdo driver, and the first problem that 
> needs to be addressed is the SQL differences in order for the different 
> drivers to work. I'm seeing specific fixes for some drivers in the 
> tests, but how should the fact that PDO does not handle the different 
> SQL requirements be addressed in these generic tests?
> 
> Obviously the first problem is identifying driver bugs from bugs in the 
> tests themselves, in particular the upper/lower case 'defaults', and the 
> use of non standard field definitions.
> 

I'm looking at this. I'll check each test and will try to be fixing the
bugs as soon as possible. Please, report whatever bug that you found. :)


Thanks for the heads up!

-- 
Regards,
Felipe Pena

---

## #43064 — Lester Caine — 2009-02-16T10:23:34+00:00

URL: https://externals.io/message/43056#43064 · In reply to: #43060

Felipe Pena wrote:
> Hi Lester,
> 
> Em Dom, 2009-02-15 às 18:31 +0000, Lester Caine escreveu:
> > […]
> 
> I'm looking at this. I'll check each test and will try to be fixing the
> bugs as soon as possible. Please, report whatever bug that you found. :)

The OCI driver is failing a number of the same tests as Firebird. Both 
work in a similar way internally which is why I believe that the tests 
need sorting before trying to fix non existent bugs? Since I don't use 
oci, making generic changes to the tests is a little difficult for me.

I have now found the switch to force upper case returns from PDO, but 
'natural' returns should at least follow the current SQL standards, 
which seems not to be the case. I'm being pressed to at least look at 
the Firebird PDO driver, but it's method of working introduces another 
level of processing inside ADOdb - on which all my work is based - so I 
only see disadvantages in enabling it. All the projects I'm involved 
with switch cleanly between different databases. YES things could be 
faster if we selected just one database, but customers seem to have this 
idea that THEIR favourite database is best. PDO is not a stepping stone 
to database abstraction, it's introducing it's own restrictions to clean 
cross database working, and messing up the current clean paths :(

-- 
Lester Caine - G8HFL
-----------------------------
Contact - http://lsces.co.uk/lsces/wiki/?page=contact
L.S.Caine Electronic Services - http://lsces.co.uk
EnquirySolve - http://enquirysolve.com/
Model Engineers Digital Workshop - http://medw.co.uk//
Firebird - http://www.firebirdsql.org/index.php